From: Jyri Sarha <jsarha@ti.com>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Xiubo Li <Li.Xiubo@freescale.com>,
linux-kernel@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [alsa-devel] [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links
Date: Mon, 17 Mar 2014 12:19:46 +0200 [thread overview]
Message-ID: <190d334218a324f12078f81d769322ca@kapsi.fi> (raw)
In-Reply-To: <d054780a0edf4b2338a52e48bff9144e19aa614f.1394883134.git.moinejf@free.fr>
On 2014-03-15 13:30, Jean-Francois Moine wrote:
> There may be many couples of CPU/CODEC DAI links.
> The example 2 is extracted from the Cubox DT.
>
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
[...]
This binding forces all the dai links to share the same card level
properties. I find it problematic in these cases:
>> - simple-audio-card,format : CPU/CODEC common audio format.
>> "i2s", "right_j", "left_j" , "dsp_a"
>> "dsp_b", "ac97", "pdm", "msb", "lsb"
The code allows having the format parameter in sub nodes too, but the
document does no mention it. Adding a mention would solve this problem
at least partly.
Neither does the document mention that
"simple-audio-card,bitclock-inversion" and
"simple-audio-card,frame-inversion" are also allowed in card level.
Currently the code uses simple bit-wise-or from card-level and dai-level
daifmt parameters, which may lead to broken daifmt setting. However,
this on directly related to this patch.
>> - dai-tdm-slot-num : Please refer to tdm-slot.txt.
>> - dai-tdm-slot-width : Please refer to tdm-slot.txt.
These properties are actually only taken from sub-nodes so the document
is broken but the code is ok.
In general this binding would look better if another sub-node level
would added for dai-link related properties, including the cpu and codec
sub-nodes, but that would break the backwards compatibility.
Best regards,
Jyri
WARNING: multiple messages have this Message-ID (diff)
From: Jyri Sarha <jsarha-l0cyMroinI0@public.gmane.org>
To: Jean-Francois Moine <moinejf-GANU6spQydw@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Kuninori Morimoto
<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [alsa-devel] [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links
Date: Mon, 17 Mar 2014 12:19:46 +0200 [thread overview]
Message-ID: <190d334218a324f12078f81d769322ca@kapsi.fi> (raw)
In-Reply-To: <d054780a0edf4b2338a52e48bff9144e19aa614f.1394883134.git.moinejf-GANU6spQydw@public.gmane.org>
On 2014-03-15 13:30, Jean-Francois Moine wrote:
> There may be many couples of CPU/CODEC DAI links.
> The example 2 is extracted from the Cubox DT.
>
> Signed-off-by: Jean-Francois Moine <moinejf-GANU6spQydw@public.gmane.org>
> ---
[...]
This binding forces all the dai links to share the same card level
properties. I find it problematic in these cases:
>> - simple-audio-card,format : CPU/CODEC common audio format.
>> "i2s", "right_j", "left_j" , "dsp_a"
>> "dsp_b", "ac97", "pdm", "msb", "lsb"
The code allows having the format parameter in sub nodes too, but the
document does no mention it. Adding a mention would solve this problem
at least partly.
Neither does the document mention that
"simple-audio-card,bitclock-inversion" and
"simple-audio-card,frame-inversion" are also allowed in card level.
Currently the code uses simple bit-wise-or from card-level and dai-level
daifmt parameters, which may lead to broken daifmt setting. However,
this on directly related to this patch.
>> - dai-tdm-slot-num : Please refer to tdm-slot.txt.
>> - dai-tdm-slot-width : Please refer to tdm-slot.txt.
These properties are actually only taken from sub-nodes so the document
is broken but the code is ok.
In general this binding would look better if another sub-node level
would added for dai-link related properties, including the cpu and codec
sub-nodes, but that would break the backwards compatibility.
Best regards,
Jyri
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-17 10:19 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 11:32 [PATCH v3 0/4] ASoC: simple-card: multi DAI links extension Jean-Francois Moine
2014-03-15 11:32 ` Jean-Francois Moine
2014-03-15 10:32 ` [PATCH v3 1/4] ASoC: simple-card: Simplify code Jean-Francois Moine
2014-03-15 10:32 ` Jean-Francois Moine
2014-03-17 16:24 ` Mark Brown
2014-03-15 11:09 ` [PATCH v3 2/4] ASoC: simple-card: dynamically allocate the DAI link and properties Jean-Francois Moine
2014-03-17 9:29 ` [alsa-devel] " Jyri Sarha
2014-03-17 9:29 ` Jyri Sarha
2014-03-17 10:23 ` Jean-Francois Moine
2014-03-17 10:23 ` Jean-Francois Moine
2014-03-17 10:27 ` [alsa-devel] " Jyri Sarha
2014-03-17 10:27 ` Jyri Sarha
2014-03-17 16:24 ` Mark Brown
2014-03-18 20:18 ` Mark Brown
2014-03-15 11:26 ` [PATCH v3 3/4] ASoC: simple-card: Handle many DAI links Jean-Francois Moine
2014-03-17 16:29 ` Mark Brown
2014-03-15 11:30 ` [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links Jean-Francois Moine
2014-03-17 10:19 ` Jyri Sarha [this message]
2014-03-17 10:19 ` [alsa-devel] " Jyri Sarha
2014-03-17 16:43 ` Mark Brown
2014-03-17 16:43 ` Mark Brown
2014-03-18 8:17 ` Jean-Francois Moine
2014-03-18 10:41 ` Mark Brown
2014-03-18 10:41 ` Mark Brown
2014-03-19 10:08 ` Jyri Sarha
2014-03-19 10:08 ` Jyri Sarha
2014-03-19 13:46 ` Mark Brown
2014-03-19 13:46 ` Mark Brown
2014-03-19 18:32 ` Jyri Sarha
2014-03-19 18:32 ` Jyri Sarha
2014-03-19 19:14 ` Mark Brown
2014-03-19 19:14 ` Mark Brown
2014-03-19 16:07 ` Jean-Francois Moine
2014-03-19 16:07 ` Jean-Francois Moine
2014-03-19 18:51 ` [alsa-devel] " Lars-Peter Clausen
2014-03-19 18:51 ` Lars-Peter Clausen
2014-03-19 19:15 ` Jyri Sarha
2014-03-19 19:15 ` Jyri Sarha
2014-03-19 19:21 ` Mark Brown
2014-03-19 19:21 ` Mark Brown
2014-03-19 19:31 ` Lars-Peter Clausen
2014-03-19 19:31 ` Lars-Peter Clausen
2014-03-20 11:24 ` Jyri Sarha
2014-03-20 11:24 ` Jyri Sarha
2014-03-17 3:49 ` [PATCH v3 0/4] ASoC: simple-card: multi DAI links extension Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=190d334218a324f12078f81d769322ca@kapsi.fi \
--to=jsarha@ti.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.