From: Jyri Sarha <jsarha@ti.com> To: Jean-Francois Moine <moinejf@free.fr>, Mark Brown <broonie@kernel.org> Cc: <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, <linux-kernel@vger.kernel.org>, Xiubo Li <Li.Xiubo@freescale.com> Subject: Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links Date: Wed, 19 Mar 2014 12:08:55 +0200 [thread overview] Message-ID: <53296CB7.1000909@ti.com> (raw) In-Reply-To: <20140318091728.1d2240ca@armhf> On 03/18/2014 10:17 AM, Jean-Francois Moine wrote: > On Mon, 17 Mar 2014 16:43:39 +0000 > Mark Brown <broonie@kernel.org> wrote: > >> On Sat, Mar 15, 2014 at 12:30:05PM +0100, Jean-Francois Moine wrote: > [snip] ... > > I agree. I see two possible syntaxes: > > 1) keep the same definitions in the containers: > > sound { > compatible = "simple-audio-card"; > simple-audio-card,name = "Cubox Audio"; > > simple-audio-card,dai-link@0 { /* I2S - HDMI */ > simple-audio-card,cpu { > sound-dai = <&audio1 0>; > format = "i2s"; > }; > simple-audio-card,codec { > sound-dai = <&tda998x 0>; > }; > }; > > simple-audio-card,dai-link@1 { /* S/PDIF - HDMI */ > simple-audio-card,cpu { > sound-dai = <&audio1 1>; > }; > simple-audio-card,codec { > sound-dai = <&tda998x 1>; > } > }; > ... > I vote for the version above. As Mark said there is need for dai specific properties. While we are at it we could update the bitclock-master and frame-master syntax to be like this: bitclock-master = "cpu" frame-master = "codec" With the above explicit definition all the daifmt settings could be defined in link level. For backwards compatibility we could still define that omitting the value equals "codec" and omitting the property equals "cpu". It may sometimes be helpful to allow overwriting link level settings in dai level. In order to do that it should be possible to write all daifmt settings explicitly like this: bitclock-inversion = <0>; /* <0> = no bitclock-inversion */ If backward compatibility is necessary we could recognize the syntax version from the existence dai-link node. sound { compatible = "simple-audio-card"; simple-audio-card,name = "Simple Audio"; simple-audio-card,widgets = ... simple-audio-card,routing = ... simple-audio-card,dai-link@0 { /* I2S - codec */ format = "i2s"; bitclock-master = "codec"; frame-master = "codec"; bitclock-inversion = <1>; simple-audio-card,cpu { sound-dai = <&audio1 0>; bitclock-inversion = <0>; }; simple-audio-card,codec { sound-dai = <&codec 0>; system-clock-frequency = <12000000>; }; }; ... I can participate in the implementation too. Best regards, Jyro
WARNING: multiple messages have this Message-ID (diff)
From: Jyri Sarha <jsarha-l0cyMroinI0@public.gmane.org> To: Jean-Francois Moine <moinejf-GANU6spQydw@public.gmane.org>, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Xiubo Li <Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org> Subject: Re: [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links Date: Wed, 19 Mar 2014 12:08:55 +0200 [thread overview] Message-ID: <53296CB7.1000909@ti.com> (raw) In-Reply-To: <20140318091728.1d2240ca@armhf> On 03/18/2014 10:17 AM, Jean-Francois Moine wrote: > On Mon, 17 Mar 2014 16:43:39 +0000 > Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > >> On Sat, Mar 15, 2014 at 12:30:05PM +0100, Jean-Francois Moine wrote: > [snip] ... > > I agree. I see two possible syntaxes: > > 1) keep the same definitions in the containers: > > sound { > compatible = "simple-audio-card"; > simple-audio-card,name = "Cubox Audio"; > > simple-audio-card,dai-link@0 { /* I2S - HDMI */ > simple-audio-card,cpu { > sound-dai = <&audio1 0>; > format = "i2s"; > }; > simple-audio-card,codec { > sound-dai = <&tda998x 0>; > }; > }; > > simple-audio-card,dai-link@1 { /* S/PDIF - HDMI */ > simple-audio-card,cpu { > sound-dai = <&audio1 1>; > }; > simple-audio-card,codec { > sound-dai = <&tda998x 1>; > } > }; > ... > I vote for the version above. As Mark said there is need for dai specific properties. While we are at it we could update the bitclock-master and frame-master syntax to be like this: bitclock-master = "cpu" frame-master = "codec" With the above explicit definition all the daifmt settings could be defined in link level. For backwards compatibility we could still define that omitting the value equals "codec" and omitting the property equals "cpu". It may sometimes be helpful to allow overwriting link level settings in dai level. In order to do that it should be possible to write all daifmt settings explicitly like this: bitclock-inversion = <0>; /* <0> = no bitclock-inversion */ If backward compatibility is necessary we could recognize the syntax version from the existence dai-link node. sound { compatible = "simple-audio-card"; simple-audio-card,name = "Simple Audio"; simple-audio-card,widgets = ... simple-audio-card,routing = ... simple-audio-card,dai-link@0 { /* I2S - codec */ format = "i2s"; bitclock-master = "codec"; frame-master = "codec"; bitclock-inversion = <1>; simple-audio-card,cpu { sound-dai = <&audio1 0>; bitclock-inversion = <0>; }; simple-audio-card,codec { sound-dai = <&codec 0>; system-clock-frequency = <12000000>; }; }; ... I can participate in the implementation too. Best regards, Jyro -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-19 10:09 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-03-15 11:32 [PATCH v3 0/4] ASoC: simple-card: multi DAI links extension Jean-Francois Moine 2014-03-15 11:32 ` Jean-Francois Moine 2014-03-15 10:32 ` [PATCH v3 1/4] ASoC: simple-card: Simplify code Jean-Francois Moine 2014-03-15 10:32 ` Jean-Francois Moine 2014-03-17 16:24 ` Mark Brown 2014-03-15 11:09 ` [PATCH v3 2/4] ASoC: simple-card: dynamically allocate the DAI link and properties Jean-Francois Moine 2014-03-17 9:29 ` [alsa-devel] " Jyri Sarha 2014-03-17 9:29 ` Jyri Sarha 2014-03-17 10:23 ` Jean-Francois Moine 2014-03-17 10:23 ` Jean-Francois Moine 2014-03-17 10:27 ` [alsa-devel] " Jyri Sarha 2014-03-17 10:27 ` Jyri Sarha 2014-03-17 16:24 ` Mark Brown 2014-03-18 20:18 ` Mark Brown 2014-03-15 11:26 ` [PATCH v3 3/4] ASoC: simple-card: Handle many DAI links Jean-Francois Moine 2014-03-17 16:29 ` Mark Brown 2014-03-15 11:30 ` [PATCH v3 4/4] ASoC: simple-card: Add DT documentation for multi-DAI links Jean-Francois Moine 2014-03-17 10:19 ` [alsa-devel] " Jyri Sarha 2014-03-17 10:19 ` Jyri Sarha 2014-03-17 16:43 ` Mark Brown 2014-03-17 16:43 ` Mark Brown 2014-03-18 8:17 ` Jean-Francois Moine 2014-03-18 10:41 ` Mark Brown 2014-03-18 10:41 ` Mark Brown 2014-03-19 10:08 ` Jyri Sarha [this message] 2014-03-19 10:08 ` Jyri Sarha 2014-03-19 13:46 ` Mark Brown 2014-03-19 13:46 ` Mark Brown 2014-03-19 18:32 ` Jyri Sarha 2014-03-19 18:32 ` Jyri Sarha 2014-03-19 19:14 ` Mark Brown 2014-03-19 19:14 ` Mark Brown 2014-03-19 16:07 ` Jean-Francois Moine 2014-03-19 16:07 ` Jean-Francois Moine 2014-03-19 18:51 ` [alsa-devel] " Lars-Peter Clausen 2014-03-19 18:51 ` Lars-Peter Clausen 2014-03-19 19:15 ` Jyri Sarha 2014-03-19 19:15 ` Jyri Sarha 2014-03-19 19:21 ` Mark Brown 2014-03-19 19:21 ` Mark Brown 2014-03-19 19:31 ` Lars-Peter Clausen 2014-03-19 19:31 ` Lars-Peter Clausen 2014-03-20 11:24 ` Jyri Sarha 2014-03-20 11:24 ` Jyri Sarha 2014-03-17 3:49 ` [PATCH v3 0/4] ASoC: simple-card: multi DAI links extension Li.Xiubo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=53296CB7.1000909@ti.com \ --to=jsarha@ti.com \ --cc=Li.Xiubo@freescale.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=linux-kernel@vger.kernel.org \ --cc=moinejf@free.fr \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.