From: Wen Gong <wgong@qti.qualcomm.com>
To: "Michał Kazior" <kazikcz@gmail.com>, "Wen Gong" <wgong@codeaurora.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: RE: [PATCH] ath10k: Remove ATH10K_STATE_RESTARTED in simulate fw crash
Date: Mon, 7 Jan 2019 07:16:08 +0000 [thread overview]
Message-ID: <195f3bb0c88c43a6b1ca0ad336f947c0@aptaiexm02f.ap.qualcomm.com> (raw)
In-Reply-To: <CABvG-CWg-VXAtoN8HZumW-ZdP6dX9cO_8fWJ58C22kD2yDcXdw@mail.gmail.com>
> > It is because the state has not changed to ATH10K_STATE_ON
> > immediately, then it will have more than two simulate crash process
> > running meanwhile, and complete/wakeup some field twice, it destroy
> > the normal recovery process.
>
> This was intended to allow testing not only firmware crash path (and
> recovery) but also firmware crash while recovering from a firmware crash.
>
If firmware is recovering from crash, then simulate a new crash will trigger error.
So remove it.
>
> Michał
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <wgong@qti.qualcomm.com>
To: "Michał Kazior" <kazikcz@gmail.com>, "Wen Gong" <wgong@codeaurora.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: RE: [PATCH] ath10k: Remove ATH10K_STATE_RESTARTED in simulate fw crash
Date: Mon, 7 Jan 2019 07:16:08 +0000 [thread overview]
Message-ID: <195f3bb0c88c43a6b1ca0ad336f947c0@aptaiexm02f.ap.qualcomm.com> (raw)
In-Reply-To: <CABvG-CWg-VXAtoN8HZumW-ZdP6dX9cO_8fWJ58C22kD2yDcXdw@mail.gmail.com>
> > It is because the state has not changed to ATH10K_STATE_ON
> > immediately, then it will have more than two simulate crash process
> > running meanwhile, and complete/wakeup some field twice, it destroy
> > the normal recovery process.
>
> This was intended to allow testing not only firmware crash path (and
> recovery) but also firmware crash while recovering from a firmware crash.
>
If firmware is recovering from crash, then simulate a new crash will trigger error.
So remove it.
>
> Michał
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-01-07 7:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 2:50 [PATCH] ath10k: Remove ATH10K_STATE_RESTARTED in simulate fw crash Wen Gong
2018-11-14 2:50 ` Wen Gong
2018-11-14 7:48 ` Michał Kazior
2018-11-14 7:48 ` Michał Kazior
2019-01-07 7:16 ` Wen Gong [this message]
2019-01-07 7:16 ` Wen Gong
2019-01-07 8:35 ` Michał Kazior
2019-01-07 8:35 ` Michał Kazior
2019-01-08 8:45 ` Wen Gong
2019-01-08 8:45 ` Wen Gong
2019-02-08 13:32 ` Kalle Valo
2019-02-08 13:32 ` Kalle Valo
2019-02-08 13:34 ` Kalle Valo
2019-02-08 13:34 ` Kalle Valo
2019-04-01 6:11 ` Wen Gong
2019-04-01 6:11 ` Wen Gong
2019-04-08 10:19 ` Wen Gong
2019-04-08 10:19 ` Wen Gong
2019-04-08 17:27 ` Michał Kazior
2019-04-08 17:27 ` Michał Kazior
2019-04-09 5:09 ` Wen Gong
2019-04-09 5:09 ` Wen Gong
2019-04-09 23:25 ` Brian Norris
2019-04-09 23:25 ` Brian Norris
2019-04-10 2:45 ` Wen Gong
2019-04-10 2:45 ` Wen Gong
2019-05-28 2:49 ` Wen Gong
2019-05-28 2:49 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=195f3bb0c88c43a6b1ca0ad336f947c0@aptaiexm02f.ap.qualcomm.com \
--to=wgong@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=kazikcz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.