All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Kazior" <kazikcz@gmail.com>
To: Wen Gong <wgong@codeaurora.org>
Cc: ath10k@lists.infradead.org,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: Remove ATH10K_STATE_RESTARTED in simulate fw crash
Date: Wed, 14 Nov 2018 08:48:49 +0100	[thread overview]
Message-ID: <CABvG-CWg-VXAtoN8HZumW-ZdP6dX9cO_8fWJ58C22kD2yDcXdw@mail.gmail.com> (raw)
In-Reply-To: <1542163824-795-1-git-send-email-wgong@codeaurora.org>

On Wed, 14 Nov 2018 at 03:51, Wen Gong <wgong@codeaurora.org> wrote:
>
> When test simulate firmware crash, it is easy to trigger error.
> command:
> echo soft > /sys/kernel/debug/ieee80211/phyxx/ath10k/simulate_fw_crash.
>
> If input more than two times continuously, then it will have error.
> Error message:
> ath10k_pci 0000:02:00.0: failed to set vdev 1 RX wake policy: -108
> ath10k_pci 0000:02:00.0: device is wedged, will not restart
>
> It is because the state has not changed to ATH10K_STATE_ON immediately,
> then it will have more than two simulate crash process running meanwhile,
> and complete/wakeup some field twice, it destroy the normal recovery
> process.

This was intended to allow testing not only firmware crash path (and
recovery) but also firmware crash while recovering from a firmware
crash.


Michał

WARNING: multiple messages have this Message-ID (diff)
From: "Michał Kazior" <kazikcz@gmail.com>
To: Wen Gong <wgong@codeaurora.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Remove ATH10K_STATE_RESTARTED in simulate fw crash
Date: Wed, 14 Nov 2018 08:48:49 +0100	[thread overview]
Message-ID: <CABvG-CWg-VXAtoN8HZumW-ZdP6dX9cO_8fWJ58C22kD2yDcXdw@mail.gmail.com> (raw)
In-Reply-To: <1542163824-795-1-git-send-email-wgong@codeaurora.org>

On Wed, 14 Nov 2018 at 03:51, Wen Gong <wgong@codeaurora.org> wrote:
>
> When test simulate firmware crash, it is easy to trigger error.
> command:
> echo soft > /sys/kernel/debug/ieee80211/phyxx/ath10k/simulate_fw_crash.
>
> If input more than two times continuously, then it will have error.
> Error message:
> ath10k_pci 0000:02:00.0: failed to set vdev 1 RX wake policy: -108
> ath10k_pci 0000:02:00.0: device is wedged, will not restart
>
> It is because the state has not changed to ATH10K_STATE_ON immediately,
> then it will have more than two simulate crash process running meanwhile,
> and complete/wakeup some field twice, it destroy the normal recovery
> process.

This was intended to allow testing not only firmware crash path (and
recovery) but also firmware crash while recovering from a firmware
crash.


Michał

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2018-11-14  7:49 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14  2:50 [PATCH] ath10k: Remove ATH10K_STATE_RESTARTED in simulate fw crash Wen Gong
2018-11-14  2:50 ` Wen Gong
2018-11-14  7:48 ` Michał Kazior [this message]
2018-11-14  7:48   ` Michał Kazior
2019-01-07  7:16   ` Wen Gong
2019-01-07  7:16     ` Wen Gong
2019-01-07  8:35     ` Michał Kazior
2019-01-07  8:35       ` Michał Kazior
2019-01-08  8:45       ` Wen Gong
2019-01-08  8:45         ` Wen Gong
2019-02-08 13:32         ` Kalle Valo
2019-02-08 13:32           ` Kalle Valo
2019-02-08 13:34           ` Kalle Valo
2019-02-08 13:34             ` Kalle Valo
2019-04-01  6:11       ` Wen Gong
2019-04-01  6:11         ` Wen Gong
2019-04-08 10:19         ` Wen Gong
2019-04-08 10:19           ` Wen Gong
2019-04-08 17:27           ` Michał Kazior
2019-04-08 17:27             ` Michał Kazior
2019-04-09  5:09             ` Wen Gong
2019-04-09  5:09               ` Wen Gong
2019-04-09 23:25               ` Brian Norris
2019-04-09 23:25                 ` Brian Norris
2019-04-10  2:45                 ` Wen Gong
2019-04-10  2:45                   ` Wen Gong
2019-05-28  2:49                   ` Wen Gong
2019-05-28  2:49                     ` Wen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABvG-CWg-VXAtoN8HZumW-ZdP6dX9cO_8fWJ58C22kD2yDcXdw@mail.gmail.com \
    --to=kazikcz@gmail.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wgong@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.