Re: [PATCH] cpuidle: clps711x: convert to devm_platform_ioremap_resource

From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Yangtao Li <tiny.windzz@gmail.com>
Cc: shc_work@mail.ru, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuidle: clps711x: convert to devm_platform_ioremap_resource
Date: Mon, 16 Dec 2019 16:44:56 +0100	[thread overview]
Message-ID: <19ceef1b-1f70-9a2b-3610-a8389b72f0cc@linaro.org> (raw)
In-Reply-To: <5309821.Xs2qqjuCkx@kreacher>

On 16/12/2019 12:20, Rafael J. Wysocki wrote:
> On Sunday, December 15, 2019 2:02:05 PM CET Yangtao Li wrote:
>> Use devm_platform_ioremap_resource() to simplify code.
>>
>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>> ---
>>  drivers/cpuidle/cpuidle-clps711x.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/cpuidle/cpuidle-clps711x.c b/drivers/cpuidle/cpuidle-clps711x.c
>> index 6e36740f5719..fc22c59b6c73 100644
>> --- a/drivers/cpuidle/cpuidle-clps711x.c
>> +++ b/drivers/cpuidle/cpuidle-clps711x.c
>> @@ -37,10 +37,7 @@ static struct cpuidle_driver clps711x_idle_driver = {
>>  
>>  static int __init clps711x_cpuidle_probe(struct platform_device *pdev)
>>  {
>> -	struct resource *res;
>> -
>> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -	clps711x_halt = devm_ioremap_resource(&pdev->dev, res);
>> +	clps711x_halt = devm_platform_ioremap_resource(pdev, 0);
>>  	if (IS_ERR(clps711x_halt))
>>  		return PTR_ERR(clps711x_halt);
>>  
>>
> 
> Daniel, any concerns here?

I'm fine with those changes also. Maybe a bit more elaborated changelog,
but not sure it is worth to resend a new patch for that. May be you can
just update it with an answer and Rafael can take it into account.

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog