From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Yangtao Li <tiny.windzz@gmail.com>
Cc: shc_work@mail.ru, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
Date: Mon, 16 Dec 2019 16:45:44 +0100 [thread overview]
Message-ID: <a2121917-c9e3-5695-3e35-1c95a635dc88@linaro.org> (raw)
In-Reply-To: <6350875.0eM1BVzdex@kreacher>
On 16/12/2019 12:21, Rafael J. Wysocki wrote:
> On Sunday, December 15, 2019 2:02:06 PM CET Yangtao Li wrote:
>> Use devm_platform_ioremap_resource() to simplify code.
>>
>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>> ---
>> drivers/cpuidle/cpuidle-kirkwood.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
>> index d23d8f468c12..511c4f46027a 100644
>> --- a/drivers/cpuidle/cpuidle-kirkwood.c
>> +++ b/drivers/cpuidle/cpuidle-kirkwood.c
>> @@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {
>> /* Initialize CPU idle by registering the idle states */
>> static int kirkwood_cpuidle_probe(struct platform_device *pdev)
>> {
>> - struct resource *res;
>> -
>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
>> + ddr_operation_base = devm_platform_ioremap_resource(pdev, 0);
>> if (IS_ERR(ddr_operation_base))
>> return PTR_ERR(ddr_operation_base);
>>
>>
>
> Daniel, any concerns here?
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Yangtao Li <tiny.windzz@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, shc_work@mail.ru,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
Date: Mon, 16 Dec 2019 16:45:44 +0100 [thread overview]
Message-ID: <a2121917-c9e3-5695-3e35-1c95a635dc88@linaro.org> (raw)
In-Reply-To: <6350875.0eM1BVzdex@kreacher>
On 16/12/2019 12:21, Rafael J. Wysocki wrote:
> On Sunday, December 15, 2019 2:02:06 PM CET Yangtao Li wrote:
>> Use devm_platform_ioremap_resource() to simplify code.
>>
>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>> ---
>> drivers/cpuidle/cpuidle-kirkwood.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
>> index d23d8f468c12..511c4f46027a 100644
>> --- a/drivers/cpuidle/cpuidle-kirkwood.c
>> +++ b/drivers/cpuidle/cpuidle-kirkwood.c
>> @@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {
>> /* Initialize CPU idle by registering the idle states */
>> static int kirkwood_cpuidle_probe(struct platform_device *pdev)
>> {
>> - struct resource *res;
>> -
>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
>> + ddr_operation_base = devm_platform_ioremap_resource(pdev, 0);
>> if (IS_ERR(ddr_operation_base))
>> return PTR_ERR(ddr_operation_base);
>>
>>
>
> Daniel, any concerns here?
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-16 15:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 13:02 [PATCH] cpuidle: clps711x: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-15 13:02 ` Yangtao Li
2019-12-15 13:02 ` [PATCH 1/2] cpuidle: kirkwood: " Yangtao Li
2019-12-15 13:02 ` Yangtao Li
2019-12-15 15:01 ` Andrew Lunn
2019-12-15 15:01 ` Andrew Lunn
2019-12-16 11:21 ` Rafael J. Wysocki
2019-12-16 11:21 ` Rafael J. Wysocki
2019-12-16 15:45 ` Daniel Lezcano [this message]
2019-12-16 15:45 ` Daniel Lezcano
2019-12-20 9:16 ` Rafael J. Wysocki
2019-12-20 9:16 ` Rafael J. Wysocki
2019-12-16 11:20 ` [PATCH] cpuidle: clps711x: " Rafael J. Wysocki
2019-12-16 11:20 ` Rafael J. Wysocki
2019-12-16 15:44 ` Daniel Lezcano
2019-12-16 15:44 ` Daniel Lezcano
2019-12-20 9:17 ` Rafael J. Wysocki
2019-12-20 9:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2121917-c9e3-5695-3e35-1c95a635dc88@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shc_work@mail.ru \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.