From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Sean Paul <sean@poorly.run>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
Vinod Polimera <quic_vpolimer@quicinc.com>,
Kuogee Hsieh <quic_khsieh@quicinc.com>
Subject: Re: [PATCH 1/7] drm/msm/dp: Replace open-coded drm_dp_read_dpcd_caps()
Date: Mon, 4 Sep 2023 01:37:15 +0300 [thread overview]
Message-ID: <1c7b1397-de05-49f7-8e26-3244fbd1573f@linaro.org> (raw)
In-Reply-To: <20230829184735.2841739-2-swboyd@chromium.org>
On 29/08/2023 21:47, Stephen Boyd wrote:
> This function duplicates the common function drm_dp_read_dpcd_caps().
> The array of DPCD registers filled in is one size larger than the
> function takes, but from what I can tell that extra byte was never used.
> Resize the array and use the common function to reduce the code here.
>
> Cc: Vinod Polimera <quic_vpolimer@quicinc.com>
> Cc: Kuogee Hsieh <quic_khsieh@quicinc.com>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/gpu/drm/msm/dp/dp_panel.c | 42 ++++---------------------------
> drivers/gpu/drm/msm/dp/dp_panel.h | 4 +--
> 2 files changed, 6 insertions(+), 40 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Sean Paul <sean@poorly.run>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Vinod Polimera <quic_vpolimer@quicinc.com>,
patches@lists.linux.dev, Kuogee Hsieh <quic_khsieh@quicinc.com>,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH 1/7] drm/msm/dp: Replace open-coded drm_dp_read_dpcd_caps()
Date: Mon, 4 Sep 2023 01:37:15 +0300 [thread overview]
Message-ID: <1c7b1397-de05-49f7-8e26-3244fbd1573f@linaro.org> (raw)
In-Reply-To: <20230829184735.2841739-2-swboyd@chromium.org>
On 29/08/2023 21:47, Stephen Boyd wrote:
> This function duplicates the common function drm_dp_read_dpcd_caps().
> The array of DPCD registers filled in is one size larger than the
> function takes, but from what I can tell that extra byte was never used.
> Resize the array and use the common function to reduce the code here.
>
> Cc: Vinod Polimera <quic_vpolimer@quicinc.com>
> Cc: Kuogee Hsieh <quic_khsieh@quicinc.com>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/gpu/drm/msm/dp/dp_panel.c | 42 ++++---------------------------
> drivers/gpu/drm/msm/dp/dp_panel.h | 4 +--
> 2 files changed, 6 insertions(+), 40 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-09-03 22:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 18:47 [PATCH 0/7] drm/msm/dp: Simplify DPCD related code with helpers Stephen Boyd
2023-08-29 18:47 ` Stephen Boyd
2023-08-29 18:47 ` [PATCH 1/7] drm/msm/dp: Replace open-coded drm_dp_read_dpcd_caps() Stephen Boyd
2023-08-29 18:47 ` Stephen Boyd
2023-08-31 20:27 ` Kuogee Hsieh
2023-08-31 20:27 ` Kuogee Hsieh
2023-09-03 22:37 ` Dmitry Baryshkov [this message]
2023-09-03 22:37 ` Dmitry Baryshkov
2023-08-29 18:47 ` [PATCH 2/7] drm/msm/dp: Use drm_dp_read_sink_count() helper Stephen Boyd
2023-08-29 18:47 ` Stephen Boyd
2023-08-31 20:27 ` Kuogee Hsieh
2023-08-31 20:27 ` Kuogee Hsieh
2023-09-03 22:37 ` Dmitry Baryshkov
2023-09-03 22:37 ` Dmitry Baryshkov
2023-08-29 18:47 ` [PATCH 3/7] drm/msm/dp: Remove dead code related to downstream cap info Stephen Boyd
2023-08-29 18:47 ` Stephen Boyd
2023-08-31 20:28 ` Kuogee Hsieh
2023-08-31 20:28 ` Kuogee Hsieh
2023-08-31 20:28 ` Kuogee Hsieh
2023-08-31 20:28 ` Kuogee Hsieh
2023-09-03 22:39 ` Dmitry Baryshkov
2023-09-03 22:39 ` Dmitry Baryshkov
2023-08-29 18:47 ` [PATCH 4/7] drm/msm/dp: Remove aux_cfg_update_done and related code Stephen Boyd
2023-08-29 18:47 ` Stephen Boyd
2023-08-31 20:28 ` Kuogee Hsieh
2023-08-31 20:28 ` Kuogee Hsieh
2023-09-03 22:39 ` Dmitry Baryshkov
2023-09-03 22:39 ` Dmitry Baryshkov
2023-08-29 18:47 ` [PATCH 5/7] drm/msm/dp: Simplify with drm_dp_{max_link_rate, max_lane_count}() Stephen Boyd
2023-08-29 18:47 ` [PATCH 5/7] drm/msm/dp: Simplify with drm_dp_{max_link_rate,max_lane_count}() Stephen Boyd
2023-08-31 20:29 ` Kuogee Hsieh
2023-08-31 20:29 ` Kuogee Hsieh
2023-09-03 22:39 ` Dmitry Baryshkov
2023-09-03 22:39 ` Dmitry Baryshkov
2023-08-29 18:47 ` [PATCH 6/7] drm/msm/dp: Inline dp_link_parse_sink_count() Stephen Boyd
2023-08-29 18:47 ` Stephen Boyd
2023-08-31 20:29 ` Kuogee Hsieh
2023-08-31 20:29 ` Kuogee Hsieh
2023-09-03 22:39 ` Dmitry Baryshkov
2023-09-03 22:39 ` Dmitry Baryshkov
2023-08-29 18:47 ` [PATCH 7/7] drm/msm/dp: Remove dp_display_is_ds_bridge() Stephen Boyd
2023-08-29 18:47 ` Stephen Boyd
2023-08-31 20:29 ` Kuogee Hsieh
2023-08-31 20:29 ` Kuogee Hsieh
2023-09-03 22:40 ` Dmitry Baryshkov
2023-09-03 22:40 ` Dmitry Baryshkov
2023-09-05 21:52 ` Stephen Boyd
2023-09-05 21:52 ` Stephen Boyd
2023-09-03 22:45 ` [PATCH 0/7] drm/msm/dp: Simplify DPCD related code with helpers Dmitry Baryshkov
2023-09-03 22:45 ` Dmitry Baryshkov
2023-10-08 14:01 ` Dmitry Baryshkov
2023-10-08 14:01 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c7b1397-de05-49f7-8e26-3244fbd1573f@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_vpolimer@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.