From: Kuogee Hsieh <quic_khsieh@quicinc.com> To: Stephen Boyd <swboyd@chromium.org>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: <linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>, Sean Paul <sean@poorly.run>, <dri-devel@lists.freedesktop.org>, <freedreno@lists.freedesktop.org>, Vinod Polimera <quic_vpolimer@quicinc.com> Subject: Re: [PATCH 7/7] drm/msm/dp: Remove dp_display_is_ds_bridge() Date: Thu, 31 Aug 2023 13:29:42 -0700 [thread overview] Message-ID: <c498fd06-f99d-6dc8-2c22-c332a5b6084d@quicinc.com> (raw) In-Reply-To: <20230829184735.2841739-8-swboyd@chromium.org> On 8/29/2023 11:47 AM, Stephen Boyd wrote: > This function is simply drm_dp_is_branch() so use that instead of > open-coding it. > > Cc: Vinod Polimera <quic_vpolimer@quicinc.com> > Cc: Kuogee Hsieh <quic_khsieh@quicinc.com> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> Tested-by: Kuogee Hsieh <quic_khsieh@quicinc.com> Reviewed-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > --- > drivers/gpu/drm/msm/dp/dp_display.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 76f13954015b..96bbf6fec2f1 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -341,19 +341,12 @@ static const struct component_ops dp_display_comp_ops = { > .unbind = dp_display_unbind, > }; > > -static bool dp_display_is_ds_bridge(struct dp_panel *panel) > -{ > - return (panel->dpcd[DP_DOWNSTREAMPORT_PRESENT] & > - DP_DWN_STRM_PORT_PRESENT); > -} > - > static bool dp_display_is_sink_count_zero(struct dp_display_private *dp) > { > drm_dbg_dp(dp->drm_dev, "present=%#x sink_count=%d\n", > dp->panel->dpcd[DP_DOWNSTREAMPORT_PRESENT], > dp->link->sink_count); > - return dp_display_is_ds_bridge(dp->panel) && > - (dp->link->sink_count == 0); > + return drm_dp_is_branch(dp->panel->dpcd) && dp->link->sink_count == 0; > } > > static void dp_display_send_hpd_event(struct msm_dp *dp_display)
WARNING: multiple messages have this Message-ID (diff)
From: Kuogee Hsieh <quic_khsieh@quicinc.com> To: Stephen Boyd <swboyd@chromium.org>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Sean Paul <sean@poorly.run>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Vinod Polimera <quic_vpolimer@quicinc.com>, patches@lists.linux.dev, freedreno@lists.freedesktop.org Subject: Re: [PATCH 7/7] drm/msm/dp: Remove dp_display_is_ds_bridge() Date: Thu, 31 Aug 2023 13:29:42 -0700 [thread overview] Message-ID: <c498fd06-f99d-6dc8-2c22-c332a5b6084d@quicinc.com> (raw) In-Reply-To: <20230829184735.2841739-8-swboyd@chromium.org> On 8/29/2023 11:47 AM, Stephen Boyd wrote: > This function is simply drm_dp_is_branch() so use that instead of > open-coding it. > > Cc: Vinod Polimera <quic_vpolimer@quicinc.com> > Cc: Kuogee Hsieh <quic_khsieh@quicinc.com> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> Tested-by: Kuogee Hsieh <quic_khsieh@quicinc.com> Reviewed-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > --- > drivers/gpu/drm/msm/dp/dp_display.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 76f13954015b..96bbf6fec2f1 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -341,19 +341,12 @@ static const struct component_ops dp_display_comp_ops = { > .unbind = dp_display_unbind, > }; > > -static bool dp_display_is_ds_bridge(struct dp_panel *panel) > -{ > - return (panel->dpcd[DP_DOWNSTREAMPORT_PRESENT] & > - DP_DWN_STRM_PORT_PRESENT); > -} > - > static bool dp_display_is_sink_count_zero(struct dp_display_private *dp) > { > drm_dbg_dp(dp->drm_dev, "present=%#x sink_count=%d\n", > dp->panel->dpcd[DP_DOWNSTREAMPORT_PRESENT], > dp->link->sink_count); > - return dp_display_is_ds_bridge(dp->panel) && > - (dp->link->sink_count == 0); > + return drm_dp_is_branch(dp->panel->dpcd) && dp->link->sink_count == 0; > } > > static void dp_display_send_hpd_event(struct msm_dp *dp_display)
next prev parent reply other threads:[~2023-08-31 20:29 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-29 18:47 [PATCH 0/7] drm/msm/dp: Simplify DPCD related code with helpers Stephen Boyd 2023-08-29 18:47 ` Stephen Boyd 2023-08-29 18:47 ` [PATCH 1/7] drm/msm/dp: Replace open-coded drm_dp_read_dpcd_caps() Stephen Boyd 2023-08-29 18:47 ` Stephen Boyd 2023-08-31 20:27 ` Kuogee Hsieh 2023-08-31 20:27 ` Kuogee Hsieh 2023-09-03 22:37 ` Dmitry Baryshkov 2023-09-03 22:37 ` Dmitry Baryshkov 2023-08-29 18:47 ` [PATCH 2/7] drm/msm/dp: Use drm_dp_read_sink_count() helper Stephen Boyd 2023-08-29 18:47 ` Stephen Boyd 2023-08-31 20:27 ` Kuogee Hsieh 2023-08-31 20:27 ` Kuogee Hsieh 2023-09-03 22:37 ` Dmitry Baryshkov 2023-09-03 22:37 ` Dmitry Baryshkov 2023-08-29 18:47 ` [PATCH 3/7] drm/msm/dp: Remove dead code related to downstream cap info Stephen Boyd 2023-08-29 18:47 ` Stephen Boyd 2023-08-31 20:28 ` Kuogee Hsieh 2023-08-31 20:28 ` Kuogee Hsieh 2023-08-31 20:28 ` Kuogee Hsieh 2023-08-31 20:28 ` Kuogee Hsieh 2023-09-03 22:39 ` Dmitry Baryshkov 2023-09-03 22:39 ` Dmitry Baryshkov 2023-08-29 18:47 ` [PATCH 4/7] drm/msm/dp: Remove aux_cfg_update_done and related code Stephen Boyd 2023-08-29 18:47 ` Stephen Boyd 2023-08-31 20:28 ` Kuogee Hsieh 2023-08-31 20:28 ` Kuogee Hsieh 2023-09-03 22:39 ` Dmitry Baryshkov 2023-09-03 22:39 ` Dmitry Baryshkov 2023-08-29 18:47 ` [PATCH 5/7] drm/msm/dp: Simplify with drm_dp_{max_link_rate, max_lane_count}() Stephen Boyd 2023-08-29 18:47 ` [PATCH 5/7] drm/msm/dp: Simplify with drm_dp_{max_link_rate,max_lane_count}() Stephen Boyd 2023-08-31 20:29 ` Kuogee Hsieh 2023-08-31 20:29 ` Kuogee Hsieh 2023-09-03 22:39 ` Dmitry Baryshkov 2023-09-03 22:39 ` Dmitry Baryshkov 2023-08-29 18:47 ` [PATCH 6/7] drm/msm/dp: Inline dp_link_parse_sink_count() Stephen Boyd 2023-08-29 18:47 ` Stephen Boyd 2023-08-31 20:29 ` Kuogee Hsieh 2023-08-31 20:29 ` Kuogee Hsieh 2023-09-03 22:39 ` Dmitry Baryshkov 2023-09-03 22:39 ` Dmitry Baryshkov 2023-08-29 18:47 ` [PATCH 7/7] drm/msm/dp: Remove dp_display_is_ds_bridge() Stephen Boyd 2023-08-29 18:47 ` Stephen Boyd 2023-08-31 20:29 ` Kuogee Hsieh [this message] 2023-08-31 20:29 ` Kuogee Hsieh 2023-09-03 22:40 ` Dmitry Baryshkov 2023-09-03 22:40 ` Dmitry Baryshkov 2023-09-05 21:52 ` Stephen Boyd 2023-09-05 21:52 ` Stephen Boyd 2023-09-03 22:45 ` [PATCH 0/7] drm/msm/dp: Simplify DPCD related code with helpers Dmitry Baryshkov 2023-09-03 22:45 ` Dmitry Baryshkov 2023-10-08 14:01 ` Dmitry Baryshkov 2023-10-08 14:01 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c498fd06-f99d-6dc8-2c22-c332a5b6084d@quicinc.com \ --to=quic_khsieh@quicinc.com \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=patches@lists.linux.dev \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_vpolimer@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.