From: Denton Liu <liu.denton@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: [PATCH 2/3] apply.h: include missing header
Date: Mon, 23 Sep 2019 11:34:55 -0700 [thread overview]
Message-ID: <1fc6dfc5fa45eec6ed20a06efb445c344b8a64af.1569263631.git.liu.denton@gmail.com> (raw)
In-Reply-To: <cover.1569263631.git.liu.denton@gmail.com>
When running `make hdr-check`, we got the following error messages:
apply.h:146:22: error: use of undeclared identifier 'GIT_MAX_HEXSZ'
char old_oid_prefix[GIT_MAX_HEXSZ + 1];
^
apply.h:147:22: error: use of undeclared identifier 'GIT_MAX_HEXSZ'
char new_oid_prefix[GIT_MAX_HEXSZ + 1];
^
apply.h:151:33: error: array has incomplete element type 'struct object_id'
struct object_id threeway_stage[3];
^
./strbuf.h:79:8: note: forward declaration of 'struct object_id'
struct object_id;
^
3 errors generated.
make: *** [apply.hco] Error 1
Include the missing "hash.h" header to fix these errors.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
apply.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/apply.h b/apply.h
index a795193435..da3d95fa50 100644
--- a/apply.h
+++ b/apply.h
@@ -1,6 +1,7 @@
#ifndef APPLY_H
#define APPLY_H
+#include "hash.h"
#include "lockfile.h"
#include "string-list.h"
--
2.23.0.565.g1cc52d20df
next prev parent reply other threads:[~2019-09-23 18:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 18:34 [PATCH 0/3] fixes related to `make hdr-check` Denton Liu
2019-09-23 18:34 ` [PATCH 1/3] Makefile: use $(ALL_CFLAGS) in $(HCO) target Denton Liu
2019-09-26 12:49 ` Johannes Schindelin
2019-09-26 17:38 ` Denton Liu
2019-09-26 19:47 ` Johannes Schindelin
2019-09-28 4:59 ` Junio C Hamano
2019-09-23 18:34 ` Denton Liu [this message]
2019-09-23 18:34 ` [PATCH 3/3] promisor-remote.h: include missing header Denton Liu
2019-09-24 9:08 ` [PATCH 4/3] pack-bitmap.h: fix unused variable warning Denton Liu
2019-09-24 21:34 ` Jeff King
2019-09-24 21:38 ` Jeff King
2019-09-25 8:20 ` [PATCH v2 0/4] fixes related to `make hdr-check` Denton Liu
2019-09-25 8:20 ` [PATCH v2 1/4] apply.h: include missing header Denton Liu
2019-09-25 8:20 ` [PATCH v2 2/4] promisor-remote.h: " Denton Liu
2019-09-25 8:20 ` [PATCH v2 3/4] pack-bitmap.h: remove magic number Denton Liu
2019-09-25 8:21 ` [PATCH v2 4/4] Makefile: emulate compile in $(HCO) target better Denton Liu
2019-10-02 15:41 ` Jeff King
2019-09-26 12:57 ` [PATCH 0/3] fixes related to `make hdr-check` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fc6dfc5fa45eec6ed20a06efb445c344b8a64af.1569263631.git.liu.denton@gmail.com \
--to=liu.denton@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.