From: Denton Liu <liu.denton@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: Jeff King <peff@peff.net>
Subject: [PATCH v2 2/4] promisor-remote.h: include missing header
Date: Wed, 25 Sep 2019 01:20:56 -0700 [thread overview]
Message-ID: <2befc450fb04dde1f676ec9d0cf04da9b1a1ca70.1569398897.git.liu.denton@gmail.com> (raw)
In-Reply-To: <cover.1569398897.git.liu.denton@gmail.com>
When we ran `make hdr-check`, we got the following warning message:
promisor-remote.h:21:46: warning: declaration of 'struct repository' will not be visible outside of this function [-Wvisibility]
extern int promisor_remote_get_direct(struct repository *repo,
^
1 warning generated.
This was caused by a missing reference to `struct repository`, which is
defined in "repository.h".
Include this missing header to fix this warning.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
promisor-remote.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/promisor-remote.h b/promisor-remote.h
index 8200dfc940..76e8d86c7c 100644
--- a/promisor-remote.h
+++ b/promisor-remote.h
@@ -1,6 +1,8 @@
#ifndef PROMISOR_REMOTE_H
#define PROMISOR_REMOTE_H
+#include "repository.h"
+
struct object_id;
/*
--
2.23.0.248.g3a9dd8fb08
next prev parent reply other threads:[~2019-09-25 8:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 18:34 [PATCH 0/3] fixes related to `make hdr-check` Denton Liu
2019-09-23 18:34 ` [PATCH 1/3] Makefile: use $(ALL_CFLAGS) in $(HCO) target Denton Liu
2019-09-26 12:49 ` Johannes Schindelin
2019-09-26 17:38 ` Denton Liu
2019-09-26 19:47 ` Johannes Schindelin
2019-09-28 4:59 ` Junio C Hamano
2019-09-23 18:34 ` [PATCH 2/3] apply.h: include missing header Denton Liu
2019-09-23 18:34 ` [PATCH 3/3] promisor-remote.h: " Denton Liu
2019-09-24 9:08 ` [PATCH 4/3] pack-bitmap.h: fix unused variable warning Denton Liu
2019-09-24 21:34 ` Jeff King
2019-09-24 21:38 ` Jeff King
2019-09-25 8:20 ` [PATCH v2 0/4] fixes related to `make hdr-check` Denton Liu
2019-09-25 8:20 ` [PATCH v2 1/4] apply.h: include missing header Denton Liu
2019-09-25 8:20 ` Denton Liu [this message]
2019-09-25 8:20 ` [PATCH v2 3/4] pack-bitmap.h: remove magic number Denton Liu
2019-09-25 8:21 ` [PATCH v2 4/4] Makefile: emulate compile in $(HCO) target better Denton Liu
2019-10-02 15:41 ` Jeff King
2019-09-26 12:57 ` [PATCH 0/3] fixes related to `make hdr-check` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2befc450fb04dde1f676ec9d0cf04da9b1a1ca70.1569398897.git.liu.denton@gmail.com \
--to=liu.denton@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.