From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 0/3] fixes related to `make hdr-check`
Date: Thu, 26 Sep 2019 14:57:27 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1909261452340.15067@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <cover.1569263631.git.liu.denton@gmail.com>
Hi Denton,
On Mon, 23 Sep 2019, Denton Liu wrote:
> This patchset relates to `make hdr-check`. The first patch addresses
> getting it to run on platforms which require custom CFLAGS.
>
> The other two patches address errors/warnings caught by actually running
> `make hdr-check`.
>
>
> Denton Liu (3):
> Makefile: use $(ALL_CFLAGS) in $(HCO) target
> apply.h: include missing header
> promisor-remote.h: include missing header
These all make sense to me (including 4/3). I wonder whether we would
want a 5/3 that essentially does this:
-- snipsnap --
diff --git a/ci/run-static-analysis.sh b/ci/run-static-analysis.sh
index a19aa7ebbc0..65bcebda41a 100755
--- a/ci/run-static-analysis.sh
+++ b/ci/run-static-analysis.sh
@@ -26,4 +26,7 @@ then
exit 1
fi
+make hdr-check ||
+exit 1
+
save_good_tree
prev parent reply other threads:[~2019-09-26 12:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 18:34 [PATCH 0/3] fixes related to `make hdr-check` Denton Liu
2019-09-23 18:34 ` [PATCH 1/3] Makefile: use $(ALL_CFLAGS) in $(HCO) target Denton Liu
2019-09-26 12:49 ` Johannes Schindelin
2019-09-26 17:38 ` Denton Liu
2019-09-26 19:47 ` Johannes Schindelin
2019-09-28 4:59 ` Junio C Hamano
2019-09-23 18:34 ` [PATCH 2/3] apply.h: include missing header Denton Liu
2019-09-23 18:34 ` [PATCH 3/3] promisor-remote.h: " Denton Liu
2019-09-24 9:08 ` [PATCH 4/3] pack-bitmap.h: fix unused variable warning Denton Liu
2019-09-24 21:34 ` Jeff King
2019-09-24 21:38 ` Jeff King
2019-09-25 8:20 ` [PATCH v2 0/4] fixes related to `make hdr-check` Denton Liu
2019-09-25 8:20 ` [PATCH v2 1/4] apply.h: include missing header Denton Liu
2019-09-25 8:20 ` [PATCH v2 2/4] promisor-remote.h: " Denton Liu
2019-09-25 8:20 ` [PATCH v2 3/4] pack-bitmap.h: remove magic number Denton Liu
2019-09-25 8:21 ` [PATCH v2 4/4] Makefile: emulate compile in $(HCO) target better Denton Liu
2019-10-02 15:41 ` Jeff King
2019-09-26 12:57 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1909261452340.15067@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.