From: Jerome Brunet <jbrunet@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Dmitry Shmidt <dimitrysh@google.com>
Subject: Re: [PATCH 1/2] Revert "ASoC: meson: axg-tdm-interface: manage formatters in trigger"
Date: Thu, 21 Apr 2022 18:17:02 +0200 [thread overview]
Message-ID: <1jwnfixuwc.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20220421155725.2589089-1-narmstrong@baylibre.com>
On Thu 21 Apr 2022 at 17:57, Neil Armstrong <narmstrong@baylibre.com> wrote:
> This reverts commit bf5e4887eeddb48480568466536aa08ec7f179a5 because
> the following and required commit e138233e56e9829e65b6293887063a1a3ccb2d68
> causes the following system crash when using audio:
> BUG: sleeping function called from invalid context at kernel/locking/mutex.c:282
>
> Reported-by: Dmitry Shmidt <dimitrysh@google.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
For both:
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
The main reason for the this was to be able to configure the start order
between the DPCM Backend and Frontend. Only the trigger() callback has
that capability for now.
This HW require the BE to start before FE, otherwise channels get randomly
shifted in the output stream if there is more than 2 slots on the link,
mainly on the capture path.
This HW require mutexes to handle the TDM formatters (because it uses
the CCF API). This why I moved to non-atomic to use trigger(),
forgetting that doing so would make period_elapsed() take a mutex from
the IRQ ... :/
To properly fix this, I'll need to extend ASoC so the prepare() callback
BE/FE call order can also be configured.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Dmitry Shmidt <dimitrysh@google.com>
Subject: Re: [PATCH 1/2] Revert "ASoC: meson: axg-tdm-interface: manage formatters in trigger"
Date: Thu, 21 Apr 2022 18:17:02 +0200 [thread overview]
Message-ID: <1jwnfixuwc.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20220421155725.2589089-1-narmstrong@baylibre.com>
On Thu 21 Apr 2022 at 17:57, Neil Armstrong <narmstrong@baylibre.com> wrote:
> This reverts commit bf5e4887eeddb48480568466536aa08ec7f179a5 because
> the following and required commit e138233e56e9829e65b6293887063a1a3ccb2d68
> causes the following system crash when using audio:
> BUG: sleeping function called from invalid context at kernel/locking/mutex.c:282
>
> Reported-by: Dmitry Shmidt <dimitrysh@google.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
For both:
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
The main reason for the this was to be able to configure the start order
between the DPCM Backend and Frontend. Only the trigger() callback has
that capability for now.
This HW require the BE to start before FE, otherwise channels get randomly
shifted in the output stream if there is more than 2 slots on the link,
mainly on the capture path.
This HW require mutexes to handle the TDM formatters (because it uses
the CCF API). This why I moved to non-atomic to use trigger(),
forgetting that doing so would make period_elapsed() take a mutex from
the IRQ ... :/
To properly fix this, I'll need to extend ASoC so the prepare() callback
BE/FE call order can also be configured.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Dmitry Shmidt <dimitrysh@google.com>
Subject: Re: [PATCH 1/2] Revert "ASoC: meson: axg-tdm-interface: manage formatters in trigger"
Date: Thu, 21 Apr 2022 18:17:02 +0200 [thread overview]
Message-ID: <1jwnfixuwc.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20220421155725.2589089-1-narmstrong@baylibre.com>
On Thu 21 Apr 2022 at 17:57, Neil Armstrong <narmstrong@baylibre.com> wrote:
> This reverts commit bf5e4887eeddb48480568466536aa08ec7f179a5 because
> the following and required commit e138233e56e9829e65b6293887063a1a3ccb2d68
> causes the following system crash when using audio:
> BUG: sleeping function called from invalid context at kernel/locking/mutex.c:282
>
> Reported-by: Dmitry Shmidt <dimitrysh@google.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
For both:
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
The main reason for the this was to be able to configure the start order
between the DPCM Backend and Frontend. Only the trigger() callback has
that capability for now.
This HW require the BE to start before FE, otherwise channels get randomly
shifted in the output stream if there is more than 2 slots on the link,
mainly on the capture path.
This HW require mutexes to handle the TDM formatters (because it uses
the CCF API). This why I moved to non-atomic to use trigger(),
forgetting that doing so would make period_elapsed() take a mutex from
the IRQ ... :/
To properly fix this, I'll need to extend ASoC so the prepare() callback
BE/FE call order can also be configured.
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>, broonie@kernel.org
Cc: linux-amlogic@lists.infradead.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Dmitry Shmidt <dimitrysh@google.com>
Subject: Re: [PATCH 1/2] Revert "ASoC: meson: axg-tdm-interface: manage formatters in trigger"
Date: Thu, 21 Apr 2022 18:17:02 +0200 [thread overview]
Message-ID: <1jwnfixuwc.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20220421155725.2589089-1-narmstrong@baylibre.com>
On Thu 21 Apr 2022 at 17:57, Neil Armstrong <narmstrong@baylibre.com> wrote:
> This reverts commit bf5e4887eeddb48480568466536aa08ec7f179a5 because
> the following and required commit e138233e56e9829e65b6293887063a1a3ccb2d68
> causes the following system crash when using audio:
> BUG: sleeping function called from invalid context at kernel/locking/mutex.c:282
>
> Reported-by: Dmitry Shmidt <dimitrysh@google.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
For both:
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
The main reason for the this was to be able to configure the start order
between the DPCM Backend and Frontend. Only the trigger() callback has
that capability for now.
This HW require the BE to start before FE, otherwise channels get randomly
shifted in the output stream if there is more than 2 slots on the link,
mainly on the capture path.
This HW require mutexes to handle the TDM formatters (because it uses
the CCF API). This why I moved to non-atomic to use trigger(),
forgetting that doing so would make period_elapsed() take a mutex from
the IRQ ... :/
To properly fix this, I'll need to extend ASoC so the prepare() callback
BE/FE call order can also be configured.
next prev parent reply other threads:[~2022-04-21 16:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 15:57 [PATCH 1/2] Revert "ASoC: meson: axg-tdm-interface: manage formatters in trigger" Neil Armstrong
2022-04-21 15:57 ` Neil Armstrong
2022-04-21 15:57 ` Neil Armstrong
2022-04-21 15:57 ` Neil Armstrong
2022-04-21 15:57 ` [PATCH 2/2] Revert "ASoC: meson: axg-card: make links nonatomic" Neil Armstrong
2022-04-21 15:57 ` Neil Armstrong
2022-04-21 15:57 ` Neil Armstrong
2022-04-21 15:57 ` Neil Armstrong
2022-04-21 16:17 ` Jerome Brunet [this message]
2022-04-21 16:17 ` [PATCH 1/2] Revert "ASoC: meson: axg-tdm-interface: manage formatters in trigger" Jerome Brunet
2022-04-21 16:17 ` Jerome Brunet
2022-04-21 16:17 ` Jerome Brunet
2022-04-21 16:58 ` Mark Brown
2022-04-21 16:58 ` Mark Brown
2022-04-21 16:58 ` Mark Brown
2022-04-21 16:58 ` Mark Brown
2022-04-21 17:20 ` Mark Brown
2022-04-21 17:20 ` Mark Brown
2022-04-21 17:20 ` Mark Brown
2022-04-21 17:20 ` Mark Brown
2022-04-22 8:26 ` Neil Armstrong
2022-04-22 8:26 ` Neil Armstrong
2022-04-22 8:26 ` Neil Armstrong
2022-04-22 8:26 ` Neil Armstrong
2022-04-21 19:18 ` Mark Brown
2022-04-21 19:18 ` Mark Brown
2022-04-21 19:18 ` Mark Brown
2022-04-21 19:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jwnfixuwc.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dimitrysh@google.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.