From: Neil Armstrong <narmstrong@baylibre.com>
To: jbrunet@baylibre.com, broonie@kernel.org
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
Dmitry Shmidt <dimitrysh@google.com>
Subject: [PATCH 2/2] Revert "ASoC: meson: axg-card: make links nonatomic"
Date: Thu, 21 Apr 2022 17:57:25 +0200 [thread overview]
Message-ID: <20220421155725.2589089-2-narmstrong@baylibre.com> (raw)
In-Reply-To: <20220421155725.2589089-1-narmstrong@baylibre.com>
This commit e138233e56e9829e65b6293887063a1a3ccb2d68 causes the
following system crash when using audio on G12A/G12B & SM1 systems:
BUG: sleeping function called from invalid context at kernel/locking/mutex.c:282
in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 0, name: swapper/0
preempt_count: 10001, expected: 0
RCU nest depth: 0, expected: 0
Preemption disabled at:
schedule_preempt_disabled+0x20/0x2c
CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 5.17.0-rc6-03747-gd403c3588f77-dirty #957
Hardware name: SEI Robotics SEI610 (DT)
Call trace:
dump_backtrace+0xd8/0xf4
show_stack+0x18/0x30
dump_stack_lvl+0x70/0x8c
dump_stack+0x18/0x38
__might_resched+0x154/0x164
__might_sleep+0x48/0x78
mutex_lock+0x24/0x60
_snd_pcm_stream_lock_irqsave+0x20/0x3c
snd_pcm_period_elapsed+0x24/0xa4
axg_fifo_pcm_irq_block+0x64/0xdc
__handle_irq_event_percpu+0x104/0x264
handle_irq_event+0x48/0xb4
...
start_kernel+0x3f0/0x484
__primary_switched+0xc0/0xc8
Revert this commit until the crash is fixed.
Reported-by: Dmitry Shmidt <dimitrysh@google.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
sound/soc/meson/axg-card.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c
index cbbaa55d92a6..2b77010c2c5c 100644
--- a/sound/soc/meson/axg-card.c
+++ b/sound/soc/meson/axg-card.c
@@ -320,7 +320,6 @@ static int axg_card_add_link(struct snd_soc_card *card, struct device_node *np,
dai_link->cpus = cpu;
dai_link->num_cpus = 1;
- dai_link->nonatomic = true;
ret = meson_card_parse_dai(card, np, &dai_link->cpus->of_node,
&dai_link->cpus->dai_name);
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: jbrunet@baylibre.com, broonie@kernel.org
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
Dmitry Shmidt <dimitrysh@google.com>
Subject: [PATCH 2/2] Revert "ASoC: meson: axg-card: make links nonatomic"
Date: Thu, 21 Apr 2022 17:57:25 +0200 [thread overview]
Message-ID: <20220421155725.2589089-2-narmstrong@baylibre.com> (raw)
In-Reply-To: <20220421155725.2589089-1-narmstrong@baylibre.com>
This commit e138233e56e9829e65b6293887063a1a3ccb2d68 causes the
following system crash when using audio on G12A/G12B & SM1 systems:
BUG: sleeping function called from invalid context at kernel/locking/mutex.c:282
in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 0, name: swapper/0
preempt_count: 10001, expected: 0
RCU nest depth: 0, expected: 0
Preemption disabled at:
schedule_preempt_disabled+0x20/0x2c
CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 5.17.0-rc6-03747-gd403c3588f77-dirty #957
Hardware name: SEI Robotics SEI610 (DT)
Call trace:
dump_backtrace+0xd8/0xf4
show_stack+0x18/0x30
dump_stack_lvl+0x70/0x8c
dump_stack+0x18/0x38
__might_resched+0x154/0x164
__might_sleep+0x48/0x78
mutex_lock+0x24/0x60
_snd_pcm_stream_lock_irqsave+0x20/0x3c
snd_pcm_period_elapsed+0x24/0xa4
axg_fifo_pcm_irq_block+0x64/0xdc
__handle_irq_event_percpu+0x104/0x264
handle_irq_event+0x48/0xb4
...
start_kernel+0x3f0/0x484
__primary_switched+0xc0/0xc8
Revert this commit until the crash is fixed.
Reported-by: Dmitry Shmidt <dimitrysh@google.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
sound/soc/meson/axg-card.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c
index cbbaa55d92a6..2b77010c2c5c 100644
--- a/sound/soc/meson/axg-card.c
+++ b/sound/soc/meson/axg-card.c
@@ -320,7 +320,6 @@ static int axg_card_add_link(struct snd_soc_card *card, struct device_node *np,
dai_link->cpus = cpu;
dai_link->num_cpus = 1;
- dai_link->nonatomic = true;
ret = meson_card_parse_dai(card, np, &dai_link->cpus->of_node,
&dai_link->cpus->dai_name);
--
2.25.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: jbrunet@baylibre.com, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, Dmitry Shmidt <dimitrysh@google.com>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] Revert "ASoC: meson: axg-card: make links nonatomic"
Date: Thu, 21 Apr 2022 17:57:25 +0200 [thread overview]
Message-ID: <20220421155725.2589089-2-narmstrong@baylibre.com> (raw)
In-Reply-To: <20220421155725.2589089-1-narmstrong@baylibre.com>
This commit e138233e56e9829e65b6293887063a1a3ccb2d68 causes the
following system crash when using audio on G12A/G12B & SM1 systems:
BUG: sleeping function called from invalid context at kernel/locking/mutex.c:282
in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 0, name: swapper/0
preempt_count: 10001, expected: 0
RCU nest depth: 0, expected: 0
Preemption disabled at:
schedule_preempt_disabled+0x20/0x2c
CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 5.17.0-rc6-03747-gd403c3588f77-dirty #957
Hardware name: SEI Robotics SEI610 (DT)
Call trace:
dump_backtrace+0xd8/0xf4
show_stack+0x18/0x30
dump_stack_lvl+0x70/0x8c
dump_stack+0x18/0x38
__might_resched+0x154/0x164
__might_sleep+0x48/0x78
mutex_lock+0x24/0x60
_snd_pcm_stream_lock_irqsave+0x20/0x3c
snd_pcm_period_elapsed+0x24/0xa4
axg_fifo_pcm_irq_block+0x64/0xdc
__handle_irq_event_percpu+0x104/0x264
handle_irq_event+0x48/0xb4
...
start_kernel+0x3f0/0x484
__primary_switched+0xc0/0xc8
Revert this commit until the crash is fixed.
Reported-by: Dmitry Shmidt <dimitrysh@google.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
sound/soc/meson/axg-card.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c
index cbbaa55d92a6..2b77010c2c5c 100644
--- a/sound/soc/meson/axg-card.c
+++ b/sound/soc/meson/axg-card.c
@@ -320,7 +320,6 @@ static int axg_card_add_link(struct snd_soc_card *card, struct device_node *np,
dai_link->cpus = cpu;
dai_link->num_cpus = 1;
- dai_link->nonatomic = true;
ret = meson_card_parse_dai(card, np, &dai_link->cpus->of_node,
&dai_link->cpus->dai_name);
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: jbrunet@baylibre.com, broonie@kernel.org
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
Dmitry Shmidt <dimitrysh@google.com>
Subject: [PATCH 2/2] Revert "ASoC: meson: axg-card: make links nonatomic"
Date: Thu, 21 Apr 2022 17:57:25 +0200 [thread overview]
Message-ID: <20220421155725.2589089-2-narmstrong@baylibre.com> (raw)
In-Reply-To: <20220421155725.2589089-1-narmstrong@baylibre.com>
This commit e138233e56e9829e65b6293887063a1a3ccb2d68 causes the
following system crash when using audio on G12A/G12B & SM1 systems:
BUG: sleeping function called from invalid context at kernel/locking/mutex.c:282
in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 0, name: swapper/0
preempt_count: 10001, expected: 0
RCU nest depth: 0, expected: 0
Preemption disabled at:
schedule_preempt_disabled+0x20/0x2c
CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 5.17.0-rc6-03747-gd403c3588f77-dirty #957
Hardware name: SEI Robotics SEI610 (DT)
Call trace:
dump_backtrace+0xd8/0xf4
show_stack+0x18/0x30
dump_stack_lvl+0x70/0x8c
dump_stack+0x18/0x38
__might_resched+0x154/0x164
__might_sleep+0x48/0x78
mutex_lock+0x24/0x60
_snd_pcm_stream_lock_irqsave+0x20/0x3c
snd_pcm_period_elapsed+0x24/0xa4
axg_fifo_pcm_irq_block+0x64/0xdc
__handle_irq_event_percpu+0x104/0x264
handle_irq_event+0x48/0xb4
...
start_kernel+0x3f0/0x484
__primary_switched+0xc0/0xc8
Revert this commit until the crash is fixed.
Reported-by: Dmitry Shmidt <dimitrysh@google.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
sound/soc/meson/axg-card.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c
index cbbaa55d92a6..2b77010c2c5c 100644
--- a/sound/soc/meson/axg-card.c
+++ b/sound/soc/meson/axg-card.c
@@ -320,7 +320,6 @@ static int axg_card_add_link(struct snd_soc_card *card, struct device_node *np,
dai_link->cpus = cpu;
dai_link->num_cpus = 1;
- dai_link->nonatomic = true;
ret = meson_card_parse_dai(card, np, &dai_link->cpus->of_node,
&dai_link->cpus->dai_name);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-21 15:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 15:57 [PATCH 1/2] Revert "ASoC: meson: axg-tdm-interface: manage formatters in trigger" Neil Armstrong
2022-04-21 15:57 ` Neil Armstrong
2022-04-21 15:57 ` Neil Armstrong
2022-04-21 15:57 ` Neil Armstrong
2022-04-21 15:57 ` Neil Armstrong [this message]
2022-04-21 15:57 ` [PATCH 2/2] Revert "ASoC: meson: axg-card: make links nonatomic" Neil Armstrong
2022-04-21 15:57 ` Neil Armstrong
2022-04-21 15:57 ` Neil Armstrong
2022-04-21 16:17 ` [PATCH 1/2] Revert "ASoC: meson: axg-tdm-interface: manage formatters in trigger" Jerome Brunet
2022-04-21 16:17 ` Jerome Brunet
2022-04-21 16:17 ` Jerome Brunet
2022-04-21 16:17 ` Jerome Brunet
2022-04-21 16:58 ` Mark Brown
2022-04-21 16:58 ` Mark Brown
2022-04-21 16:58 ` Mark Brown
2022-04-21 16:58 ` Mark Brown
2022-04-21 17:20 ` Mark Brown
2022-04-21 17:20 ` Mark Brown
2022-04-21 17:20 ` Mark Brown
2022-04-21 17:20 ` Mark Brown
2022-04-22 8:26 ` Neil Armstrong
2022-04-22 8:26 ` Neil Armstrong
2022-04-22 8:26 ` Neil Armstrong
2022-04-22 8:26 ` Neil Armstrong
2022-04-21 19:18 ` Mark Brown
2022-04-21 19:18 ` Mark Brown
2022-04-21 19:18 ` Mark Brown
2022-04-21 19:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421155725.2589089-2-narmstrong@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dimitrysh@google.com \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.