From: Oliver Neukum <oliver@neukum.org>
To: linux-pm@lists.linux-foundation.org
Cc: Greg KH <gregkh@suse.de>,
linux-pci@vger.kernel.org, linux-usb@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] usb: Add support for runtime power management of the hcd
Date: Thu, 13 Aug 2009 14:16:41 +0200 [thread overview]
Message-ID: <200908131416.42189.oliver__46390.8495651141$1250165825$gmane$org@neukum.org> (raw)
In-Reply-To: <20090813003544.GB2532@srcf.ucam.org>
Am Donnerstag, 13. August 2009 02:35:44 schrieb Matthew Garrett:
> The power savings from this are measurable but not huge - it still seems
How large?
> like a decent optimisation. The main problem is that BIOS bugs on some
> Dell laptops will kill USB if this is used, so we either default to off
> or add some quirks to handle that case (I have some ideas in that
> respect).
Your earlier failures don't look promising regarding BIOSes.
What do you have in mind?
> @@ -1968,6 +1972,9 @@ struct usb_hcd *usb_create_hcd (const struct
> hc_driver *driver, INIT_WORK(&hcd->wakeup_work, hcd_resume_work);
> #endif
>
> + pm_runtime_enable(dev);
So you don't get a reference from that?
> + pm_runtime_get(dev);
What happens if you get a runtime suspend request in between? Is this a flaw
of the API?
Regards
Oliver
next prev parent reply other threads:[~2009-08-13 12:16 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-08 14:25 [PATCH] PM: Introduce core framework for run-time PM of I/O devices (rev. 14) Rafael J. Wysocki
2009-08-09 21:13 ` [PATCH update] PM: Introduce core framework for run-time PM of I/O devices (rev. 15) Rafael J. Wysocki
2009-08-09 21:13 ` Rafael J. Wysocki
2009-08-12 10:37 ` Magnus Damm
2009-08-12 15:47 ` Alan Stern
2009-08-12 15:47 ` Alan Stern
2009-08-12 20:13 ` Rafael J. Wysocki
2009-08-12 20:13 ` Rafael J. Wysocki
2009-08-12 10:37 ` Magnus Damm
2009-08-13 0:29 ` [RFC] PCI: Runtime power management Matthew Garrett
2009-08-13 0:29 ` Matthew Garrett
2009-08-13 0:35 ` [RFC] usb: Add support for runtime power management of the hcd Matthew Garrett
2009-08-13 12:16 ` Oliver Neukum [this message]
2009-08-13 12:16 ` [linux-pm] " Oliver Neukum
2009-08-13 12:30 ` Matthew Garrett
2009-08-13 12:30 ` [linux-pm] " Matthew Garrett
2009-08-13 14:26 ` Oliver Neukum
2009-08-13 14:26 ` [linux-pm] " Oliver Neukum
2009-08-13 21:42 ` Matthew Garrett
2009-08-13 21:42 ` Matthew Garrett
2009-08-13 15:22 ` Alan Stern
2009-08-13 15:22 ` Alan Stern
2009-08-13 21:47 ` Matthew Garrett
2009-08-13 21:47 ` Matthew Garrett
2009-08-13 0:35 ` Matthew Garrett
2009-08-13 15:17 ` [RFC] PCI: Runtime power management Alan Stern
2009-08-13 21:47 ` Matthew Garrett
2009-08-14 12:30 ` Matthew Garrett
2009-08-14 12:30 ` [linux-pm] " Matthew Garrett
2009-08-14 14:43 ` Alan Stern
2009-08-14 14:43 ` [linux-pm] " Alan Stern
2009-08-14 17:05 ` Rafael J. Wysocki
2009-08-14 17:05 ` [linux-pm] " Rafael J. Wysocki
2009-08-14 17:13 ` Rafael J. Wysocki
2009-08-14 17:13 ` [linux-pm] " Rafael J. Wysocki
2009-08-14 19:01 ` Alan Stern
2009-08-14 19:01 ` Alan Stern
2009-08-14 20:05 ` [linux-pm] " Rafael J. Wysocki
2009-08-14 22:21 ` Matthew Garrett
2009-08-15 14:18 ` Rafael J. Wysocki
2009-08-15 14:18 ` [linux-pm] " Rafael J. Wysocki
2009-08-15 15:53 ` Alan Stern
2009-08-15 15:53 ` [linux-pm] " Alan Stern
2009-08-15 20:54 ` Rafael J. Wysocki
2009-08-15 20:54 ` [linux-pm] " Rafael J. Wysocki
2009-08-15 20:58 ` Matthew Garrett
2009-08-15 20:58 ` [linux-pm] " Matthew Garrett
2009-08-15 21:21 ` Rafael J. Wysocki
2009-08-15 21:21 ` Rafael J. Wysocki
2009-08-15 21:27 ` [linux-pm] " Matthew Garrett
2009-08-15 21:44 ` Rafael J. Wysocki
2009-08-15 21:44 ` [linux-pm] " Rafael J. Wysocki
2009-08-16 16:09 ` Alan Stern
2009-08-16 16:09 ` Alan Stern
2009-08-15 21:27 ` Matthew Garrett
2009-08-16 15:57 ` Alan Stern
2009-08-16 15:57 ` [linux-pm] " Alan Stern
2009-08-16 16:04 ` Matthew Garrett
2009-08-16 16:04 ` [linux-pm] " Matthew Garrett
2009-08-16 15:50 ` Alan Stern
2009-08-16 15:50 ` [linux-pm] " Alan Stern
2009-08-14 22:21 ` Matthew Garrett
2009-08-14 20:05 ` Rafael J. Wysocki
2009-08-13 21:47 ` Matthew Garrett
2009-08-13 15:17 ` Alan Stern
2009-08-14 17:37 ` Jesse Barnes
2009-08-14 17:37 ` Jesse Barnes
2009-08-14 19:15 ` Rafael J. Wysocki
2009-08-14 19:15 ` Rafael J. Wysocki
2009-08-14 21:22 ` Rafael J. Wysocki
2009-08-14 22:30 ` Matthew Garrett
2009-08-14 22:30 ` Matthew Garrett
2009-08-15 14:41 ` Rafael J. Wysocki
2009-08-15 15:24 ` Rafael J. Wysocki
2009-08-15 15:24 ` Rafael J. Wysocki
2009-08-15 14:41 ` Rafael J. Wysocki
2009-08-14 21:22 ` Rafael J. Wysocki
2009-08-13 20:56 ` [PATCH update 2x] PM: Introduce core framework for run-time PM of I/O devices (rev. 16) Rafael J. Wysocki
2009-08-13 21:03 ` Paul Mundt
2009-08-13 21:03 ` Paul Mundt
2009-08-13 21:14 ` Rafael J. Wysocki
2009-08-13 21:14 ` Rafael J. Wysocki
2009-08-14 9:08 ` Magnus Damm
2009-08-14 17:19 ` Rafael J. Wysocki
2009-08-14 17:19 ` Rafael J. Wysocki
2009-08-14 9:08 ` Magnus Damm
2009-08-14 17:25 ` [PATCH update 3x] PM: Introduce core framework for run-time PM of I/O devices (rev. 17) Rafael J. Wysocki
2009-08-14 17:25 ` Rafael J. Wysocki
2009-08-13 20:56 ` [PATCH update 2x] PM: Introduce core framework for run-time PM of I/O devices (rev. 16) Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='200908131416.42189.oliver__46390.8495651141$1250165825$gmane$org@neukum.org' \
--to=oliver@neukum.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.