From: Alan Stern <stern@rowland.harvard.edu>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-usb@vger.kernel.org, linux-pci@vger.kernel.org,
Greg KH <gregkh@suse.de>, LKML <linux-kernel@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>
Subject: Re: [RFC] PCI: Runtime power management
Date: Thu, 13 Aug 2009 11:17:05 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.0908131100440.2940-100000__33074.7976586737$1250176826$gmane$org@iolanthe.rowland.org> (raw)
In-Reply-To: <20090813002925.GA2532@srcf.ucam.org>
On Thu, 13 Aug 2009, Matthew Garrett wrote:
> --- a/drivers/pci/pci-driver.c
> +++ b/drivers/pci/pci-driver.c
> +#ifdef CONFIG_PM_RUNTIME
> +
> +static int pci_pm_runtime_suspend(struct device *dev)
> +{
> + struct pci_dev *pci_dev = to_pci_dev(dev);
> + struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;
> + int error;
> +
> + device_set_wakeup_enable(dev, 1);
This is a userspace policy parameter. Kernel code should not alter it.
Instead you should test device_may_wakeup.
> + error = pci_enable_runtime_wake(pci_dev, true);
> +
> + if (error)
> + return -EBUSY;
> +
> + if (pm && pm->runtime_suspend)
> + error = pm->runtime_suspend(dev);
> +
> + if (error)
> + goto out;
> +
> + error = pci_pm_suspend(dev);
> +
> + if (error)
> + goto resume;
> +
> + disable_irq(pci_dev->irq);
> + error = pci_pm_suspend_noirq(dev);
> + enable_irq(pci_dev->irq);
> +
> + if (error)
> + goto resume_noirq;
> +
> + return 0;
> +
> +resume_noirq:
> + disable_irq(pci_dev->irq);
> + pci_pm_resume_noirq(dev);
> + enable_irq(pci_dev->irq);
> +resume:
> + pci_pm_resume(dev);
> +out:
> + pci_enable_runtime_wake(pci_dev, false);
> + return error;
> +}
The goto statements and unwinding code don't match up.
> +static int pci_pm_runtime_resume(struct device *dev)
> +{
> + struct pci_dev *pci_dev = to_pci_dev(dev);
> + struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;
> + int error = 0;
> +
> + disable_irq(pci_dev->irq);
> + error = pci_pm_resume_noirq(dev);
> + enable_irq(pci_dev->irq);
> +
> + if (error)
> + return error;
> +
> + error = pci_pm_resume(dev);
> +
> + if (error)
> + return error;
> +
> + if (pm->runtime_resume)
> + error = pm->runtime_resume(dev);
> +
> + if (error)
> + return error;
> +
> + error = pci_enable_runtime_wake(pci_dev, false);
> +
> + if (error)
> + return error;
> +
> + return 0;
> +}
Log an error message when something goes wrong?
> +static void pci_pm_runtime_idle(struct device *dev)
> +{
> + struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;
> +
> + if (pm && pm->runtime_idle)
> + pm->runtime_idle(dev);
> +
> + pm_schedule_suspend(dev, 0);
> +}
This misses the point. The whole idea of runtime_idle is to tell you
that the device is idle and might be ready to be suspended. If you're
going to call pm_schedule_suspend anyway, there's no reason to invoke
pm->runtime_idle.
Alan Stern
next prev parent reply other threads:[~2009-08-13 15:17 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-08 14:25 [PATCH] PM: Introduce core framework for run-time PM of I/O devices (rev. 14) Rafael J. Wysocki
2009-08-09 21:13 ` [PATCH update] PM: Introduce core framework for run-time PM of I/O devices (rev. 15) Rafael J. Wysocki
2009-08-09 21:13 ` Rafael J. Wysocki
2009-08-12 10:37 ` Magnus Damm
2009-08-12 15:47 ` Alan Stern
2009-08-12 15:47 ` Alan Stern
2009-08-12 20:13 ` Rafael J. Wysocki
2009-08-12 20:13 ` Rafael J. Wysocki
2009-08-12 10:37 ` Magnus Damm
2009-08-13 0:29 ` [RFC] PCI: Runtime power management Matthew Garrett
2009-08-13 0:29 ` Matthew Garrett
2009-08-13 0:35 ` [RFC] usb: Add support for runtime power management of the hcd Matthew Garrett
2009-08-13 12:16 ` Oliver Neukum
2009-08-13 12:16 ` [linux-pm] " Oliver Neukum
2009-08-13 12:30 ` Matthew Garrett
2009-08-13 12:30 ` [linux-pm] " Matthew Garrett
2009-08-13 14:26 ` Oliver Neukum
2009-08-13 14:26 ` [linux-pm] " Oliver Neukum
2009-08-13 21:42 ` Matthew Garrett
2009-08-13 21:42 ` Matthew Garrett
2009-08-13 15:22 ` Alan Stern
2009-08-13 15:22 ` Alan Stern
2009-08-13 21:47 ` Matthew Garrett
2009-08-13 21:47 ` Matthew Garrett
2009-08-13 0:35 ` Matthew Garrett
2009-08-13 15:17 ` [RFC] PCI: Runtime power management Alan Stern
2009-08-13 21:47 ` Matthew Garrett
2009-08-14 12:30 ` Matthew Garrett
2009-08-14 12:30 ` [linux-pm] " Matthew Garrett
2009-08-14 14:43 ` Alan Stern
2009-08-14 14:43 ` [linux-pm] " Alan Stern
2009-08-14 17:05 ` Rafael J. Wysocki
2009-08-14 17:05 ` [linux-pm] " Rafael J. Wysocki
2009-08-14 17:13 ` Rafael J. Wysocki
2009-08-14 17:13 ` [linux-pm] " Rafael J. Wysocki
2009-08-14 19:01 ` Alan Stern
2009-08-14 19:01 ` Alan Stern
2009-08-14 20:05 ` [linux-pm] " Rafael J. Wysocki
2009-08-14 22:21 ` Matthew Garrett
2009-08-15 14:18 ` Rafael J. Wysocki
2009-08-15 14:18 ` [linux-pm] " Rafael J. Wysocki
2009-08-15 15:53 ` Alan Stern
2009-08-15 15:53 ` [linux-pm] " Alan Stern
2009-08-15 20:54 ` Rafael J. Wysocki
2009-08-15 20:54 ` [linux-pm] " Rafael J. Wysocki
2009-08-15 20:58 ` Matthew Garrett
2009-08-15 20:58 ` [linux-pm] " Matthew Garrett
2009-08-15 21:21 ` Rafael J. Wysocki
2009-08-15 21:21 ` Rafael J. Wysocki
2009-08-15 21:27 ` [linux-pm] " Matthew Garrett
2009-08-15 21:44 ` Rafael J. Wysocki
2009-08-15 21:44 ` [linux-pm] " Rafael J. Wysocki
2009-08-16 16:09 ` Alan Stern
2009-08-16 16:09 ` Alan Stern
2009-08-15 21:27 ` Matthew Garrett
2009-08-16 15:57 ` Alan Stern
2009-08-16 15:57 ` [linux-pm] " Alan Stern
2009-08-16 16:04 ` Matthew Garrett
2009-08-16 16:04 ` [linux-pm] " Matthew Garrett
2009-08-16 15:50 ` Alan Stern
2009-08-16 15:50 ` [linux-pm] " Alan Stern
2009-08-14 22:21 ` Matthew Garrett
2009-08-14 20:05 ` Rafael J. Wysocki
2009-08-13 21:47 ` Matthew Garrett
2009-08-13 15:17 ` Alan Stern [this message]
2009-08-14 17:37 ` Jesse Barnes
2009-08-14 17:37 ` Jesse Barnes
2009-08-14 19:15 ` Rafael J. Wysocki
2009-08-14 19:15 ` Rafael J. Wysocki
2009-08-14 21:22 ` Rafael J. Wysocki
2009-08-14 22:30 ` Matthew Garrett
2009-08-14 22:30 ` Matthew Garrett
2009-08-15 14:41 ` Rafael J. Wysocki
2009-08-15 15:24 ` Rafael J. Wysocki
2009-08-15 15:24 ` Rafael J. Wysocki
2009-08-15 14:41 ` Rafael J. Wysocki
2009-08-14 21:22 ` Rafael J. Wysocki
2009-08-13 20:56 ` [PATCH update 2x] PM: Introduce core framework for run-time PM of I/O devices (rev. 16) Rafael J. Wysocki
2009-08-13 21:03 ` Paul Mundt
2009-08-13 21:03 ` Paul Mundt
2009-08-13 21:14 ` Rafael J. Wysocki
2009-08-13 21:14 ` Rafael J. Wysocki
2009-08-14 9:08 ` Magnus Damm
2009-08-14 17:19 ` Rafael J. Wysocki
2009-08-14 17:19 ` Rafael J. Wysocki
2009-08-14 9:08 ` Magnus Damm
2009-08-14 17:25 ` [PATCH update 3x] PM: Introduce core framework for run-time PM of I/O devices (rev. 17) Rafael J. Wysocki
2009-08-14 17:25 ` Rafael J. Wysocki
2009-08-13 20:56 ` [PATCH update 2x] PM: Introduce core framework for run-time PM of I/O devices (rev. 16) Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='Pine.LNX.4.44L0.0908131100440.2940-100000__33074.7976586737$1250176826$gmane$org@iolanthe.rowland.org' \
--to=stern@rowland.harvard.edu \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.