From: Paul Walmsley <paul@pwsan.com> To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/8] OMAP clock: convert static definitions in header files to C files Date: Thu, 03 Dec 2009 03:06:58 -0700 [thread overview] Message-ID: <20091203095830.1203.76290.stgit@localhost.localdomain> (raw) The OMAP clock code has traditionally defined its clock nodes statically in header files (e.g., mach-omap1/clock.h). This violates the general guideline that including a header file should be side-effect free, or at least as side-effect free as possible. This series moves all of the statically-allocated data from header files into C files that are linked into kernels. It moves OPP data (or at least the proto-OPP data in OMAP1 and OMAP2xxx) into separate files. It also resolves all of the checkpatch errors that appear as a result of the move. This series has been boot-tested on OMAP1 (on a 5912 OSK), OMAP2 (on N800 and 2430 SDP), and OMAP3 (BeagleBoard). This series was prompted by a comment from Russell King <rmk+kernel@arm.linux.org.uk>, who suggested the basic layout that these patches implement. - Paul --- size: text data bss dec hex filename 3582959 199264 107176 3889399 3b58f7 vmlinux.beagle.orig 3583063 199264 107176 3889503 3b595f vmlinux.beagle Paul Walmsley (8): OMAP1/2/3 clock: remove paranoid checks in preparation for clock{,2xxx,3xxx}_data.c OMAP2 clock: APLL code shouldn't rely on static clocks in its local namespace OMAP2/3: move SDRC macros to mach-omap2/sdrc.h OMAP2xxx clock: remove implicit dependency between rate CPU flag and clkdev_omap CPU flag OMAP3 clock: convert clock34xx.h to clock34xx_data.c OMAP2 clock: convert clock24xx.h to clock2xxx_data.c, opp2xxx* OMAP1 clock: convert test in disable_unused() to use ENABLE_ON_INIT OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c arch/arm/mach-omap1/Makefile | 3 arch/arm/mach-omap1/clock.c | 415 --- arch/arm/mach-omap1/clock.h | 652 ----- arch/arm/mach-omap1/clock_data.c | 443 +++- arch/arm/mach-omap1/io.c | 3 arch/arm/mach-omap1/opp.h | 28 arch/arm/mach-omap1/opp_data.c | 59 arch/arm/mach-omap2/Makefile | 8 arch/arm/mach-omap2/clock.h | 30 arch/arm/mach-omap2/clock24xx.c | 805 ------- arch/arm/mach-omap2/clock2xxx.c | 564 +++++ arch/arm/mach-omap2/clock2xxx.h | 44 arch/arm/mach-omap2/clock2xxx_data.c | 844 ++----- arch/arm/mach-omap2/clock34xx.c | 471 ---- arch/arm/mach-omap2/clock34xx.h | 3013 ------------------------- arch/arm/mach-omap2/clock34xx_data.c | 364 +++ arch/arm/mach-omap2/clock_common_data.c | 39 arch/arm/mach-omap2/opp2420_data.c | 126 + arch/arm/mach-omap2/opp2430_data.c | 133 + arch/arm/mach-omap2/opp2xxx.h | 424 ++++ arch/arm/mach-omap2/sdrc.h | 19 arch/arm/plat-omap/include/plat/clkdev_omap.h | 41 arch/arm/plat-omap/include/plat/clock.h | 2 23 files changed, 2592 insertions(+), 5938 deletions(-) copy arch/arm/mach-omap1/{clock.h => clock_data.c} (58%) create mode 100644 arch/arm/mach-omap1/opp.h create mode 100644 arch/arm/mach-omap1/opp_data.c delete mode 100644 arch/arm/mach-omap2/clock24xx.c create mode 100644 arch/arm/mach-omap2/clock2xxx.c create mode 100644 arch/arm/mach-omap2/clock2xxx.h rename arch/arm/mach-omap2/{clock24xx.h => clock2xxx_data.c} (73%) copy arch/arm/mach-omap2/{clock34xx.h => clock34xx_data.c} (86%) create mode 100644 arch/arm/mach-omap2/clock_common_data.c create mode 100644 arch/arm/mach-omap2/opp2420_data.c create mode 100644 arch/arm/mach-omap2/opp2430_data.c create mode 100644 arch/arm/mach-omap2/opp2xxx.h create mode 100644 arch/arm/plat-omap/include/plat/clkdev_omap.h
WARNING: multiple messages have this Message-ID (diff)
From: paul@pwsan.com (Paul Walmsley) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/8] OMAP clock: convert static definitions in header files to C files Date: Thu, 03 Dec 2009 03:06:58 -0700 [thread overview] Message-ID: <20091203095830.1203.76290.stgit@localhost.localdomain> (raw) The OMAP clock code has traditionally defined its clock nodes statically in header files (e.g., mach-omap1/clock.h). This violates the general guideline that including a header file should be side-effect free, or at least as side-effect free as possible. This series moves all of the statically-allocated data from header files into C files that are linked into kernels. It moves OPP data (or at least the proto-OPP data in OMAP1 and OMAP2xxx) into separate files. It also resolves all of the checkpatch errors that appear as a result of the move. This series has been boot-tested on OMAP1 (on a 5912 OSK), OMAP2 (on N800 and 2430 SDP), and OMAP3 (BeagleBoard). This series was prompted by a comment from Russell King <rmk+kernel@arm.linux.org.uk>, who suggested the basic layout that these patches implement. - Paul --- size: text data bss dec hex filename 3582959 199264 107176 3889399 3b58f7 vmlinux.beagle.orig 3583063 199264 107176 3889503 3b595f vmlinux.beagle Paul Walmsley (8): OMAP1/2/3 clock: remove paranoid checks in preparation for clock{,2xxx,3xxx}_data.c OMAP2 clock: APLL code shouldn't rely on static clocks in its local namespace OMAP2/3: move SDRC macros to mach-omap2/sdrc.h OMAP2xxx clock: remove implicit dependency between rate CPU flag and clkdev_omap CPU flag OMAP3 clock: convert clock34xx.h to clock34xx_data.c OMAP2 clock: convert clock24xx.h to clock2xxx_data.c, opp2xxx* OMAP1 clock: convert test in disable_unused() to use ENABLE_ON_INIT OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c arch/arm/mach-omap1/Makefile | 3 arch/arm/mach-omap1/clock.c | 415 --- arch/arm/mach-omap1/clock.h | 652 ----- arch/arm/mach-omap1/clock_data.c | 443 +++- arch/arm/mach-omap1/io.c | 3 arch/arm/mach-omap1/opp.h | 28 arch/arm/mach-omap1/opp_data.c | 59 arch/arm/mach-omap2/Makefile | 8 arch/arm/mach-omap2/clock.h | 30 arch/arm/mach-omap2/clock24xx.c | 805 ------- arch/arm/mach-omap2/clock2xxx.c | 564 +++++ arch/arm/mach-omap2/clock2xxx.h | 44 arch/arm/mach-omap2/clock2xxx_data.c | 844 ++----- arch/arm/mach-omap2/clock34xx.c | 471 ---- arch/arm/mach-omap2/clock34xx.h | 3013 ------------------------- arch/arm/mach-omap2/clock34xx_data.c | 364 +++ arch/arm/mach-omap2/clock_common_data.c | 39 arch/arm/mach-omap2/opp2420_data.c | 126 + arch/arm/mach-omap2/opp2430_data.c | 133 + arch/arm/mach-omap2/opp2xxx.h | 424 ++++ arch/arm/mach-omap2/sdrc.h | 19 arch/arm/plat-omap/include/plat/clkdev_omap.h | 41 arch/arm/plat-omap/include/plat/clock.h | 2 23 files changed, 2592 insertions(+), 5938 deletions(-) copy arch/arm/mach-omap1/{clock.h => clock_data.c} (58%) create mode 100644 arch/arm/mach-omap1/opp.h create mode 100644 arch/arm/mach-omap1/opp_data.c delete mode 100644 arch/arm/mach-omap2/clock24xx.c create mode 100644 arch/arm/mach-omap2/clock2xxx.c create mode 100644 arch/arm/mach-omap2/clock2xxx.h rename arch/arm/mach-omap2/{clock24xx.h => clock2xxx_data.c} (73%) copy arch/arm/mach-omap2/{clock34xx.h => clock34xx_data.c} (86%) create mode 100644 arch/arm/mach-omap2/clock_common_data.c create mode 100644 arch/arm/mach-omap2/opp2420_data.c create mode 100644 arch/arm/mach-omap2/opp2430_data.c create mode 100644 arch/arm/mach-omap2/opp2xxx.h create mode 100644 arch/arm/plat-omap/include/plat/clkdev_omap.h
next reply other threads:[~2009-12-03 10:11 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-12-03 10:06 Paul Walmsley [this message] 2009-12-03 10:06 ` [PATCH 0/8] OMAP clock: convert static definitions in header files to C files Paul Walmsley 2009-12-03 10:07 ` [PATCH 1/8] OMAP1/2/3 clock: remove paranoid checks in preparation for clock{, 2xxx, 3xxx}_data.c Paul Walmsley 2009-12-03 10:07 ` Paul Walmsley 2009-12-03 10:07 ` [PATCH 2/8] OMAP2 clock: APLL code shouldn't rely on static clocks in its local namespace Paul Walmsley 2009-12-03 10:07 ` Paul Walmsley 2009-12-03 10:07 ` [PATCH 3/8] OMAP2/3: move SDRC macros to mach-omap2/sdrc.h Paul Walmsley 2009-12-03 10:07 ` Paul Walmsley 2009-12-03 10:07 ` [PATCH 4/8] OMAP2xxx clock: remove implicit dependency between rate CPU flag and clkdev_omap CPU flag Paul Walmsley 2009-12-03 10:07 ` Paul Walmsley 2009-12-03 10:07 ` [PATCH 5/8] OMAP3 clock: convert clock34xx.h to clock34xx_data.c Paul Walmsley 2009-12-03 10:07 ` Paul Walmsley 2009-12-03 10:07 ` [PATCH 6/8] OMAP2 clock: convert clock24xx.h to clock2xxx_data.c, opp2xxx* Paul Walmsley 2009-12-03 10:07 ` Paul Walmsley 2009-12-03 10:07 ` [PATCH 7/8] OMAP1 clock: convert test in disable_unused() to use ENABLE_ON_INIT Paul Walmsley 2009-12-03 10:07 ` Paul Walmsley 2009-12-03 10:07 ` [PATCH 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c Paul Walmsley 2009-12-03 10:07 ` Paul Walmsley 2009-12-03 10:27 ` Russell King 2009-12-03 10:27 ` Russell King 2009-12-03 10:36 ` Paul Walmsley 2009-12-03 10:36 ` Paul Walmsley 2009-12-03 10:43 ` Russell King - ARM Linux 2009-12-03 10:43 ` Russell King - ARM Linux 2009-12-03 10:57 ` Paul Walmsley 2009-12-03 10:57 ` Paul Walmsley 2009-12-03 11:22 ` [PATCH v2 5/8] OMAP3 clock: convert clock34xx.h to clock34xx_data.c Paul Walmsley 2009-12-03 11:22 ` Paul Walmsley 2009-12-03 11:23 ` [PATCH v2 6/8] OMAP2 clock: convert clock24xx.h to clock2xxx_data.c, opp2xxx* Paul Walmsley 2009-12-03 11:23 ` Paul Walmsley 2009-12-03 11:24 ` [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c Paul Walmsley 2009-12-03 11:24 ` Paul Walmsley 2009-12-03 12:11 ` Russell King - ARM Linux 2009-12-03 12:11 ` Russell King - ARM Linux 2009-12-03 12:33 ` Paul Walmsley 2009-12-03 12:33 ` Paul Walmsley 2009-12-03 15:03 ` Russell King - ARM Linux 2009-12-03 15:03 ` Russell King - ARM Linux 2009-12-03 15:26 ` Paul Walmsley 2009-12-03 15:26 ` Paul Walmsley 2009-12-03 16:18 ` [PATCH v3 5/8] OMAP3 clock: convert clock34xx.h to clock34xx_data.c Paul Walmsley 2009-12-03 16:18 ` Paul Walmsley 2009-12-03 16:19 ` [PATCH v3 6/8] OMAP2 clock: convert clock24xx.h to clock2xxx_data.c, opp2xxx* Paul Walmsley 2009-12-03 16:19 ` Paul Walmsley 2009-12-03 16:20 ` [PATCH v3 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c Paul Walmsley 2009-12-03 16:20 ` Paul Walmsley 2009-12-03 10:29 ` [PATCH " Russell King 2009-12-03 10:29 ` Russell King 2009-12-03 10:37 ` Paul Walmsley 2009-12-03 10:37 ` Paul Walmsley 2009-12-03 10:41 ` Russell King - ARM Linux 2009-12-03 10:41 ` Russell King - ARM Linux 2009-12-04 10:05 ` [PATCH 0/8] OMAP clock: convert static definitions in header files to C files Nayak, Rajendra 2009-12-04 10:05 ` Nayak, Rajendra 2009-12-04 10:13 ` Russell King - ARM Linux 2009-12-04 10:13 ` Russell King - ARM Linux 2009-12-07 12:58 ` Paul Walmsley 2009-12-07 12:58 ` Paul Walmsley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20091203095830.1203.76290.stgit@localhost.localdomain \ --to=paul@pwsan.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.