From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Nishanth Menon <nm@ti.com>, Felipe Balbi <felipe.balbi@nokia.com>
Subject: Re: [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
Date: Thu, 3 Dec 2009 15:03:00 +0000 [thread overview]
Message-ID: <20091203150300.GB26651@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.00.0912030520360.13408@utopia.booyaka.com>
On Thu, Dec 03, 2009 at 05:33:44AM -0700, Paul Walmsley wrote:
> My preference was to keep data separated from code in the source files; I
> think it is slightly more readable.
It's less readable because instead of having similar stuff together, it's
at opposite ends of the file.
> The other consideration is that there are some patches in the works here
> to move all of the struct clk function pointers into the struct clkops.
Oh for gods sake, why do people take things to the extreme?
I looked into doing exactly that and decided it was a *bad* *idea* because
it stupidly multiplies the number of ops structures. Instead of having a
few well-defined and well-understood ops structures, you end up with one
ops structure per special case.
Then you're going to be back into adding all that sodding crap that you
had back before I cleaned up the enable/disable shite.
No, please don't do this, this would definitely be a total backwards step.
Please take a moment to think about the changes you're doing.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c
Date: Thu, 3 Dec 2009 15:03:00 +0000 [thread overview]
Message-ID: <20091203150300.GB26651@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.00.0912030520360.13408@utopia.booyaka.com>
On Thu, Dec 03, 2009 at 05:33:44AM -0700, Paul Walmsley wrote:
> My preference was to keep data separated from code in the source files; I
> think it is slightly more readable.
It's less readable because instead of having similar stuff together, it's
at opposite ends of the file.
> The other consideration is that there are some patches in the works here
> to move all of the struct clk function pointers into the struct clkops.
Oh for gods sake, why do people take things to the extreme?
I looked into doing exactly that and decided it was a *bad* *idea* because
it stupidly multiplies the number of ops structures. Instead of having a
few well-defined and well-understood ops structures, you end up with one
ops structure per special case.
Then you're going to be back into adding all that sodding crap that you
had back before I cleaned up the enable/disable shite.
No, please don't do this, this would definitely be a total backwards step.
Please take a moment to think about the changes you're doing.
next prev parent reply other threads:[~2009-12-03 15:03 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 10:06 [PATCH 0/8] OMAP clock: convert static definitions in header files to C files Paul Walmsley
2009-12-03 10:06 ` Paul Walmsley
2009-12-03 10:07 ` [PATCH 1/8] OMAP1/2/3 clock: remove paranoid checks in preparation for clock{, 2xxx, 3xxx}_data.c Paul Walmsley
2009-12-03 10:07 ` Paul Walmsley
2009-12-03 10:07 ` [PATCH 2/8] OMAP2 clock: APLL code shouldn't rely on static clocks in its local namespace Paul Walmsley
2009-12-03 10:07 ` Paul Walmsley
2009-12-03 10:07 ` [PATCH 3/8] OMAP2/3: move SDRC macros to mach-omap2/sdrc.h Paul Walmsley
2009-12-03 10:07 ` Paul Walmsley
2009-12-03 10:07 ` [PATCH 4/8] OMAP2xxx clock: remove implicit dependency between rate CPU flag and clkdev_omap CPU flag Paul Walmsley
2009-12-03 10:07 ` Paul Walmsley
2009-12-03 10:07 ` [PATCH 5/8] OMAP3 clock: convert clock34xx.h to clock34xx_data.c Paul Walmsley
2009-12-03 10:07 ` Paul Walmsley
2009-12-03 10:07 ` [PATCH 6/8] OMAP2 clock: convert clock24xx.h to clock2xxx_data.c, opp2xxx* Paul Walmsley
2009-12-03 10:07 ` Paul Walmsley
2009-12-03 10:07 ` [PATCH 7/8] OMAP1 clock: convert test in disable_unused() to use ENABLE_ON_INIT Paul Walmsley
2009-12-03 10:07 ` Paul Walmsley
2009-12-03 10:07 ` [PATCH 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c Paul Walmsley
2009-12-03 10:07 ` Paul Walmsley
2009-12-03 10:27 ` Russell King
2009-12-03 10:27 ` Russell King
2009-12-03 10:36 ` Paul Walmsley
2009-12-03 10:36 ` Paul Walmsley
2009-12-03 10:43 ` Russell King - ARM Linux
2009-12-03 10:43 ` Russell King - ARM Linux
2009-12-03 10:57 ` Paul Walmsley
2009-12-03 10:57 ` Paul Walmsley
2009-12-03 11:22 ` [PATCH v2 5/8] OMAP3 clock: convert clock34xx.h to clock34xx_data.c Paul Walmsley
2009-12-03 11:22 ` Paul Walmsley
2009-12-03 11:23 ` [PATCH v2 6/8] OMAP2 clock: convert clock24xx.h to clock2xxx_data.c, opp2xxx* Paul Walmsley
2009-12-03 11:23 ` Paul Walmsley
2009-12-03 11:24 ` [PATCH v2 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c Paul Walmsley
2009-12-03 11:24 ` Paul Walmsley
2009-12-03 12:11 ` Russell King - ARM Linux
2009-12-03 12:11 ` Russell King - ARM Linux
2009-12-03 12:33 ` Paul Walmsley
2009-12-03 12:33 ` Paul Walmsley
2009-12-03 15:03 ` Russell King - ARM Linux [this message]
2009-12-03 15:03 ` Russell King - ARM Linux
2009-12-03 15:26 ` Paul Walmsley
2009-12-03 15:26 ` Paul Walmsley
2009-12-03 16:18 ` [PATCH v3 5/8] OMAP3 clock: convert clock34xx.h to clock34xx_data.c Paul Walmsley
2009-12-03 16:18 ` Paul Walmsley
2009-12-03 16:19 ` [PATCH v3 6/8] OMAP2 clock: convert clock24xx.h to clock2xxx_data.c, opp2xxx* Paul Walmsley
2009-12-03 16:19 ` Paul Walmsley
2009-12-03 16:20 ` [PATCH v3 8/8] OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c Paul Walmsley
2009-12-03 16:20 ` Paul Walmsley
2009-12-03 10:29 ` [PATCH " Russell King
2009-12-03 10:29 ` Russell King
2009-12-03 10:37 ` Paul Walmsley
2009-12-03 10:37 ` Paul Walmsley
2009-12-03 10:41 ` Russell King - ARM Linux
2009-12-03 10:41 ` Russell King - ARM Linux
2009-12-04 10:05 ` [PATCH 0/8] OMAP clock: convert static definitions in header files to C files Nayak, Rajendra
2009-12-04 10:05 ` Nayak, Rajendra
2009-12-04 10:13 ` Russell King - ARM Linux
2009-12-04 10:13 ` Russell King - ARM Linux
2009-12-07 12:58 ` Paul Walmsley
2009-12-07 12:58 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203150300.GB26651@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=felipe.balbi@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.