From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: remove BKL from uinput open function
Date: Fri, 29 Jan 2010 23:22:05 -0800 [thread overview]
Message-ID: <20100130072205.GA30378@core.coreip.homeip.net> (raw)
In-Reply-To: <201001300741.20954.arnd@arndb.de>
On Sat, Jan 30, 2010 at 07:41:20AM +0100, Arnd Bergmann wrote:
> On Friday 29 January 2010, Thadeu Lima de Souza Cascardo wrote:
> > Commit 8702965848ed4bee27486a3e3d2ae34ebba6dd83 has push down the BKL
> > into uinput open function. However, there's nothing that needs locking
> > in there.
> >
> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
>
> The change looks good, but the same driver also uses the BKL in the
> default_llseek function. It would be nice to get rid of that in the
> same patch, e.g. by adding a ".llseek = generic_file_llseek," line
> in the file_operations, or making it call nonseekable_open() if the
> driver does not require seek to do anything.
>
I am afraid you mixed up the drivers, I don't see uinput implementing
seek...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-01-30 7:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 21:23 [PATCH] input: remove BKL from uinput open function Thadeu Lima de Souza Cascardo
2010-01-30 6:41 ` Arnd Bergmann
2010-01-30 7:22 ` Dmitry Torokhov [this message]
2010-01-30 21:57 ` Arnd Bergmann
2010-01-30 23:07 ` John Kacur
2010-01-31 4:20 ` Arnd Bergmann
2010-01-31 5:29 ` Dmitry Torokhov
2010-02-01 20:22 ` John Kacur
2010-02-01 20:22 ` John Kacur
2010-02-01 20:27 ` John Kacur
2010-02-01 20:46 ` Thadeu Lima de Souza Cascardo
2010-02-01 21:04 ` John Kacur
2010-02-01 21:04 ` John Kacur
2010-02-01 21:21 ` Dmitry Torokhov
2010-02-01 21:21 ` Dmitry Torokhov
2010-02-01 21:50 ` John Kacur
2010-02-01 21:50 ` John Kacur
2010-02-01 22:08 ` Dmitry Torokhov
2010-02-01 22:08 ` Dmitry Torokhov
2010-02-01 23:18 ` John Kacur
2010-02-01 23:18 ` John Kacur
2010-02-03 5:07 ` Dmitry Torokhov
2010-02-04 7:32 ` Arnd Bergmann
2010-02-05 16:04 ` John Kacur
2010-01-30 7:57 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100130072205.GA30378@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=cascardo@holoscopio.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.