Re: [PATCH] input: remove BKL from uinput open function

From: Arnd Bergmann <arnd@arndb.de>
To: John Kacur <jkacur@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: remove BKL from uinput open function
Date: Sun, 31 Jan 2010 05:20:55 +0100	[thread overview]
Message-ID: <201001310520.55813.arnd@arndb.de> (raw)
In-Reply-To: <520f0cf11001301507k20e3cf8dqa73026e12f3a1767@mail.gmail.com>

On Sunday 31 January 2010, John Kacur wrote:
> > Sorry, I should have been clearer, but not implementing llseek
> > is the problem I was referring to: When a driver has no explicit
> > .llseek operation in its file operations and does not call
> > nonseekable_open from its open operation, the VFS layer will
> > implicitly use default_llseek, which takes the BKL. We're
> > in the process of changing drivers not to do this, one by one
> > so we can kill the BKL in the end.
> >
> 
> I know we've discussed this before, but why wouldn't the following
> make more sense?
>  .llseek         = no_llseek,

That's one of the possible solutions. Assigning it to generic_file_llseek
also gets rid of the BKL but keeps the current behaviour (calling seek
returns success without having an effect, no_llseek returns -ESPIPE),
while calling nonseekable_open has the other side-effect of making
pread/pwrite fail with -ESPIPE, which is more consistent than
only failing seek.

	Arnd