From: Arnd Bergmann <arnd@arndb.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: remove BKL from uinput open function
Date: Sat, 30 Jan 2010 22:57:09 +0100 [thread overview]
Message-ID: <201001302257.09354.arnd@arndb.de> (raw)
In-Reply-To: <20100130072205.GA30378@core.coreip.homeip.net>
On Saturday 30 January 2010, Dmitry Torokhov wrote:
> On Sat, Jan 30, 2010 at 07:41:20AM +0100, Arnd Bergmann wrote:
> > The change looks good, but the same driver also uses the BKL in the
> > default_llseek function. It would be nice to get rid of that in the
> > same patch, e.g. by adding a ".llseek = generic_file_llseek," line
> > in the file_operations, or making it call nonseekable_open() if the
> > driver does not require seek to do anything.
> >
>
> I am afraid you mixed up the drivers, I don't see uinput implementing
> seek...
Sorry, I should have been clearer, but not implementing llseek
is the problem I was referring to: When a driver has no explicit
.llseek operation in its file operations and does not call
nonseekable_open from its open operation, the VFS layer will
implicitly use default_llseek, which takes the BKL. We're
in the process of changing drivers not to do this, one by one
so we can kill the BKL in the end.
Arnd
next prev parent reply other threads:[~2010-01-30 22:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 21:23 [PATCH] input: remove BKL from uinput open function Thadeu Lima de Souza Cascardo
2010-01-30 6:41 ` Arnd Bergmann
2010-01-30 7:22 ` Dmitry Torokhov
2010-01-30 21:57 ` Arnd Bergmann [this message]
2010-01-30 23:07 ` John Kacur
2010-01-31 4:20 ` Arnd Bergmann
2010-01-31 5:29 ` Dmitry Torokhov
2010-02-01 20:22 ` John Kacur
2010-02-01 20:22 ` John Kacur
2010-02-01 20:27 ` John Kacur
2010-02-01 20:46 ` Thadeu Lima de Souza Cascardo
2010-02-01 21:04 ` John Kacur
2010-02-01 21:04 ` John Kacur
2010-02-01 21:21 ` Dmitry Torokhov
2010-02-01 21:21 ` Dmitry Torokhov
2010-02-01 21:50 ` John Kacur
2010-02-01 21:50 ` John Kacur
2010-02-01 22:08 ` Dmitry Torokhov
2010-02-01 22:08 ` Dmitry Torokhov
2010-02-01 23:18 ` John Kacur
2010-02-01 23:18 ` John Kacur
2010-02-03 5:07 ` Dmitry Torokhov
2010-02-04 7:32 ` Arnd Bergmann
2010-02-05 16:04 ` John Kacur
2010-01-30 7:57 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001302257.09354.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cascardo@holoscopio.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.