From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> To: Marc Reilly <marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org> Cc: Uwe Kleine-K?nig <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCHv3 1/4] mc13xxx-core: Consolidate common code to prepare for separate i2c and spi Date: Mon, 20 Dec 2010 11:48:12 +0000 [thread overview] Message-ID: <20101220114811.GA14986@sirena.org.uk> (raw) In-Reply-To: <201012202100.29212.marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org> On Mon, Dec 20, 2010 at 09:00:29PM +1100, Marc Reilly wrote: > On Monday, December 20, 2010 07:31:20 pm Uwe Kleine-K?nig wrote: > > This list isn't complete, but see below. > Do you mean the list above is incomplete? I should have said "Changes to the > struct _include_". > I'm ignorant of "patch summary etiquette" (or what people otherwise like to > see) but I had just assumed that the patch comments were more like a > highlights reel - the real info is in the patch itself. No, the patch summary should generally be complete - if your patch is changing so many things that it's getting tedious to list them all then that's usually a sign that it should be split up into a series of changes.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv3 1/4] mc13xxx-core: Consolidate common code to prepare for separate i2c and spi Date: Mon, 20 Dec 2010 11:48:12 +0000 [thread overview] Message-ID: <20101220114811.GA14986@sirena.org.uk> (raw) In-Reply-To: <201012202100.29212.marc@cpdesign.com.au> On Mon, Dec 20, 2010 at 09:00:29PM +1100, Marc Reilly wrote: > On Monday, December 20, 2010 07:31:20 pm Uwe Kleine-K?nig wrote: > > This list isn't complete, but see below. > Do you mean the list above is incomplete? I should have said "Changes to the > struct _include_". > I'm ignorant of "patch summary etiquette" (or what people otherwise like to > see) but I had just assumed that the patch comments were more like a > highlights reel - the real info is in the patch itself. No, the patch summary should generally be complete - if your patch is changing so many things that it's getting tedious to list them all then that's usually a sign that it should be split up into a series of changes.
next prev parent reply other threads:[~2010-12-20 11:48 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-12-20 3:50 mc13xxx core support for i2c Marc Reilly 2010-12-20 3:50 ` Marc Reilly [not found] ` <1292817055-17715-1-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org> 2010-12-20 3:50 ` [PATCHv3 1/4] mc13xxx-core: Consolidate common code to prepare for separate i2c and spi Marc Reilly 2010-12-20 3:50 ` Marc Reilly [not found] ` <1292817055-17715-2-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org> 2010-12-20 8:31 ` Uwe Kleine-König 2010-12-20 8:31 ` Uwe Kleine-König [not found] ` <20101220083120.GP1940-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2010-12-20 10:00 ` Marc Reilly 2010-12-20 10:00 ` Marc Reilly [not found] ` <201012202100.29212.marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org> 2010-12-20 11:48 ` Mark Brown [this message] 2010-12-20 11:48 ` Mark Brown 2010-12-29 7:40 ` Grant Likely 2010-12-29 7:40 ` Grant Likely 2010-12-20 3:50 ` [PATCHv3 2/4] mc13xxx: Add spi driver Marc Reilly 2010-12-20 3:50 ` Marc Reilly 2010-12-20 3:50 ` [PATCHv3 3/4] mc13xxx: Add i2c driver Marc Reilly 2010-12-20 3:50 ` Marc Reilly 2010-12-20 3:50 ` [PATCHv3 4/4] mc13xxx: Add i2c and spi drivers to Kconfig and Makefile Marc Reilly 2010-12-20 3:50 ` Marc Reilly [not found] ` <1292817055-17715-5-git-send-email-marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org> 2010-12-20 8:38 ` Uwe Kleine-König 2010-12-20 8:38 ` Uwe Kleine-König [not found] ` <20101220083839.GQ1940-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2010-12-20 10:22 ` Marc Reilly 2010-12-20 10:22 ` Marc Reilly 2011-01-04 1:01 ` mc13xxx core support for i2c Ben Dooks 2011-01-04 1:01 ` Ben Dooks
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101220114811.GA14986@sirena.org.uk \ --to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=marc-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org \ --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \ --cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.