All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Len Brown <len.brown@intel.com>,
	linux-embedded@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	linux-pm@lists.linux-foundation.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] PM: Hide CONFIG_PM from users
Date: Mon, 7 Feb 2011 20:46:48 +0100	[thread overview]
Message-ID: <201102072046.48763.rjw__21072.4371173002$1297108069$gmane$org@sisk.pl> (raw)
In-Reply-To: <20110207193026.GT10564@opensource.wolfsonmicro.com>

On Monday, February 07, 2011, Mark Brown wrote:
> On Mon, Feb 07, 2011 at 08:14:03PM +0100, Rafael J. Wysocki wrote:
> > On Monday, February 07, 2011, Mark Brown wrote:
> 
> > >  config PM_DEBUG
> > >  	bool "Power Management Debug Support"
> 
> > I think it would be better to simply rename CONFIG_PM_OPS into CONFIG_PM.
> 
> That still leaves the IA64 emulator to worry about

Why exactly?

> but I'm not fundamentally opposed to that, it achieves a similar effect.  The
> main thing I'm looking for here is to cut down on the configuration options
> we have to maintain.

But I must say you chose a particularly bad time for that from my point of view.

> > However, there's a number of things that I'm afraid wouldn't build correctly
> > if none of CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME were set in that case.
> 
> Actually CONFIG_PM_OPS probably also wants to be on independantly of
> those two sometimes for .poweroff() which I'd expect to run even if we
> can't suspend.

If you worry about that, then add CONFIG_PM_POWEROFF and make CONFIG_PM(_OPS)
depend on it, but I don't think it really is worth it, because people
generally don't make the poweroff code depend on CONFIG_PM.

Thanks,
Rafael

  reply	other threads:[~2011-02-07 19:46 UTC|newest]

Thread overview: 139+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07 12:22 [PATCH] PM: Hide CONFIG_PM from users Mark Brown
2011-02-07 12:40 ` Geert Uytterhoeven
2011-02-07 13:26   ` Mark Brown
2011-02-07 13:26   ` Mark Brown
2011-02-07 12:40 ` Geert Uytterhoeven
2011-02-07 12:48 ` Ingo Molnar
2011-02-07 12:48 ` Ingo Molnar
2011-02-07 13:09   ` Mark Brown
2011-02-07 13:09   ` Mark Brown
2011-02-07 14:13 ` Stephen Rothwell
2011-02-07 14:13   ` Stephen Rothwell
2011-02-07 14:13   ` Stephen Rothwell
2011-02-07 14:18   ` Mark Brown
2011-02-07 14:18     ` Mark Brown
2011-02-07 14:44     ` Stephen Rothwell
2011-02-07 14:44     ` Stephen Rothwell
2011-02-07 14:44       ` Stephen Rothwell
2011-02-07 14:50       ` Mark Brown
2011-02-07 14:50       ` Mark Brown
2011-02-07 14:50         ` Mark Brown
2011-02-07 15:00         ` Geert Uytterhoeven
2011-02-07 15:00         ` Geert Uytterhoeven
2011-02-07 15:00           ` Geert Uytterhoeven
2011-02-07 15:00           ` Geert Uytterhoeven
2011-02-07 15:10           ` Stephen Rothwell
2011-02-07 15:10           ` Stephen Rothwell
2011-02-07 15:10             ` Stephen Rothwell
2011-02-07 15:19             ` Stephen Rothwell
2011-02-07 15:19             ` Stephen Rothwell
2011-02-07 15:19               ` Stephen Rothwell
2011-02-07 15:21               ` Mark Brown
2011-02-07 15:21               ` Mark Brown
2011-02-07 15:21                 ` Mark Brown
2011-02-07 15:36                 ` Alan Stern
2011-02-07 15:36                 ` Alan Stern
2011-02-07 15:36                   ` Alan Stern
2011-02-07 15:36                   ` Alan Stern
2011-02-07 15:49                   ` Mark Brown
2011-02-07 15:49                   ` Mark Brown
2011-02-07 15:49                     ` Mark Brown
2011-02-07 19:16                     ` Rafael J. Wysocki
2011-02-07 19:16                     ` Rafael J. Wysocki
2011-02-07 19:16                       ` Rafael J. Wysocki
2011-02-08  1:17                     ` Ray Lee
2011-02-08  1:17                     ` Ray Lee
2011-02-08  1:17                       ` Ray Lee
2011-02-08 11:18                       ` Mark Brown
2011-02-08 11:18                         ` Mark Brown
2011-02-08 11:18                       ` Mark Brown
2011-02-07 14:18   ` Mark Brown
2011-02-07 14:13 ` Stephen Rothwell
2011-02-07 19:14 ` Rafael J. Wysocki
2011-02-07 19:30   ` Mark Brown
2011-02-07 19:30   ` Mark Brown
2011-02-07 19:46     ` Rafael J. Wysocki [this message]
2011-02-07 19:46     ` Rafael J. Wysocki
2011-02-07 20:18       ` Mark Brown
2011-02-07 20:18       ` Mark Brown
2011-02-07 21:15         ` Rafael J. Wysocki
2011-02-07 21:15         ` Rafael J. Wysocki
2011-02-07 21:47           ` Dmitry Torokhov
2011-02-07 22:00             ` Rafael J. Wysocki
2011-02-07 22:23               ` Dmitry Torokhov
2011-02-07 22:23               ` Dmitry Torokhov
2011-02-07 23:05                 ` Rafael J. Wysocki
2011-02-07 23:05                   ` Rafael J. Wysocki
2011-02-08  0:50                   ` Dmitry Torokhov
2011-02-08  0:50                   ` Dmitry Torokhov
2011-02-08  9:23                     ` Rafael J. Wysocki
2011-02-08  9:23                     ` Rafael J. Wysocki
2011-02-08 16:48                   ` Paul Mundt
2011-02-08 16:48                   ` Paul Mundt
2011-02-07 22:00             ` Rafael J. Wysocki
2011-02-07 21:47           ` Dmitry Torokhov
2011-02-08 12:12           ` Mark Brown
2011-02-08 12:12           ` Mark Brown
2011-02-08 12:21           ` [PATCH] Remove CONFIG_PM altogether, enable power management all the time Ingo Molnar
2011-02-08 12:21           ` Ingo Molnar
2011-02-08 21:18             ` [PATCH 0/5] " Rafael J. Wysocki
2011-02-08 21:18             ` Rafael J. Wysocki
2011-02-08 21:20               ` [PATCH 1/5] ACPI / PM: Move references to pm_flags into sleep.c Rafael J. Wysocki
2011-02-08 23:40                 ` Linus Torvalds
2011-02-08 23:40                 ` Linus Torvalds
2011-02-09  0:37                   ` Rafael J. Wysocki
2011-02-09  0:37                   ` Rafael J. Wysocki
2011-02-09  1:04                     ` Linus Torvalds
2011-02-09  1:04                     ` Linus Torvalds
2011-02-08 21:20               ` Rafael J. Wysocki
2011-02-08 21:21               ` [PATCH 2/5] PM: Make CONFIG_PM depend on (CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME) Rafael J. Wysocki
2011-02-08 21:21               ` Rafael J. Wysocki
2011-02-08 21:21                 ` Rafael J. Wysocki
2011-02-08 21:21               ` [PATCH 3/5] PM: Reorder power management Kconfig options Rafael J. Wysocki
2011-02-08 21:21               ` Rafael J. Wysocki
2011-02-08 21:22               ` [PATCH 4/5] PM: Replace CONFIG_PM_OPS with CONFIG_PM Rafael J. Wysocki
2011-02-08 21:22               ` Rafael J. Wysocki
2011-02-08 21:23               ` [PATCH 5/5] PM: Clean up Kconfig dependencies Rafael J. Wysocki
2011-02-08 21:23               ` Rafael J. Wysocki
2011-02-08 23:43                 ` Linus Torvalds
2011-02-08 23:43                 ` Linus Torvalds
2011-02-10 23:32                 ` [Updated][PATCH 5/5] PM: Clean up PM_TRACE dependencies and drop unnecessary Kconfig option Rafael J. Wysocki
2011-02-10 23:32                 ` Rafael J. Wysocki
2011-02-08 23:35             ` [PATCH] Remove CONFIG_PM altogether, enable power management all the time Frank Rowand
2011-02-08 23:35             ` Frank Rowand
2011-02-08 23:35               ` Frank Rowand
2011-02-09 11:41               ` Mark Brown
2011-02-09 11:41               ` Mark Brown
2011-02-09 11:58                 ` Mark Brown
2011-02-09 11:58                 ` Mark Brown
2011-02-09 17:07                 ` Rafael J. Wysocki
2011-02-09 17:07                 ` Rafael J. Wysocki
2011-02-09 18:31                   ` Frank Rowand
2011-02-09 18:31                   ` Frank Rowand
2011-02-09 18:40                     ` Mark Brown
2011-02-09 18:40                     ` Mark Brown
2011-02-09 19:00                       ` Frank Rowand
2011-02-09 19:25                         ` Mark Brown
2011-02-09 19:53                           ` Tim Bird
2011-02-09 19:53                           ` Tim Bird
2011-02-09 19:59                             ` Mark Brown
2011-02-09 19:59                             ` Mark Brown
2011-02-09 20:09                               ` Alan Stern
2011-02-09 20:09                               ` Alan Stern
2011-02-09 20:10                                 ` Mark Brown
2011-02-09 20:10                                 ` Mark Brown
2011-02-09 19:25                         ` Mark Brown
2011-02-09 19:00                       ` Frank Rowand
2011-02-08 23:35             ` Tim Bird
2011-02-09  2:41               ` Ingo Molnar
2011-02-09  2:41               ` Ingo Molnar
2011-02-08 23:35             ` Tim Bird
2011-02-07 19:14 ` [PATCH] PM: Hide CONFIG_PM from users Rafael J. Wysocki
2011-02-08  2:52 ` Frank Rowand
2011-02-08  2:52 ` Frank Rowand
2011-02-08  2:52   ` Frank Rowand
2011-02-08 14:15   ` Mark Brown
2011-02-08 14:15   ` Mark Brown
2011-02-08 14:29 ` Pavel Machek
2011-02-08 14:29 ` Pavel Machek
2011-02-07 12:22 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='201102072046.48763.rjw__21072.4371173002$1297108069$gmane$org@sisk.pl' \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-embedded@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.