From: Arnd Bergmann <arnd@arndb.de>
To: Andy Green <andy@warmcat.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
patches@linaro.org, nicolas.pitre@linaro.org, x0132446@ti.com,
s-jan@ti.com, tony@atomide.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andy Green <andy.green@linaro.org>
Subject: Re: [RFC PATCH 2/2] OMAP2+: PANDA: Fix up random or missing MAC addresses for eth0 and wlan0
Date: Fri, 25 Mar 2011 12:39:53 +0100 [thread overview]
Message-ID: <201103251239.54243.arnd@arndb.de> (raw)
In-Reply-To: <20110324212737.14936.21228.stgit@otae.warmcat.com>
On Thursday 24 March 2011, Andy Green wrote:
> This patch registers a network device notifier callback to set the mac
> addresses for the onboard network assets of Panda correctly, despite the
> drivers involved have used a random or all-zeros MAC address.
>
> The technique was suggested by Alan Cox on lkml.
>
> It works by device path so it corrects the MAC addresses even if the
> drivers are in modules loaded in an order that changes their interface
> name from usual (eg, the onboard module might be "wlan1" if there is a
> USB wireless stick plugged in and its module is inserted first.)
>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Signed-off-by: Andy Green <andy.green@linaro.org>
It looks like this is the best solution so far.
Acked-by: Arnd Bergmann <arnd@arndb.de>
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/2] OMAP2+: PANDA: Fix up random or missing MAC addresses for eth0 and wlan0
Date: Fri, 25 Mar 2011 12:39:53 +0100 [thread overview]
Message-ID: <201103251239.54243.arnd@arndb.de> (raw)
In-Reply-To: <20110324212737.14936.21228.stgit@otae.warmcat.com>
On Thursday 24 March 2011, Andy Green wrote:
> This patch registers a network device notifier callback to set the mac
> addresses for the onboard network assets of Panda correctly, despite the
> drivers involved have used a random or all-zeros MAC address.
>
> The technique was suggested by Alan Cox on lkml.
>
> It works by device path so it corrects the MAC addresses even if the
> drivers are in modules loaded in an order that changes their interface
> name from usual (eg, the onboard module might be "wlan1" if there is a
> USB wireless stick plugged in and its module is inserted first.)
>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Signed-off-by: Andy Green <andy.green@linaro.org>
It looks like this is the best solution so far.
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2011-03-25 11:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 21:27 [RFC PATCH 0/2] OMAP2+: PANDA: Provide unique-ish MAC addresses for Ethernet and WLAN interfaces Andy Green
2011-03-24 21:27 ` Andy Green
2011-03-24 21:27 ` [RFC PATCH 1/2] OMAP2+: add cpu id register to MAC address helper Andy Green
2011-03-24 21:27 ` Andy Green
2011-03-25 11:49 ` Arnd Bergmann
2011-03-25 11:49 ` Arnd Bergmann
2011-03-25 12:08 ` Andy Green
2011-03-25 12:08 ` Andy Green
2011-03-25 13:24 ` Arnd Bergmann
2011-03-25 13:24 ` Arnd Bergmann
2011-03-25 13:34 ` Andy Green
2011-03-25 13:34 ` Andy Green
2011-03-25 14:50 ` Arnd Bergmann
2011-03-25 14:50 ` Arnd Bergmann
2011-03-25 15:00 ` Andy Green
2011-03-25 15:00 ` Andy Green
2011-03-24 21:27 ` [RFC PATCH 2/2] OMAP2+: PANDA: Fix up random or missing MAC addresses for eth0 and wlan0 Andy Green
2011-03-24 21:27 ` Andy Green
2011-03-25 7:39 ` Hema Kalliguddi
2011-03-25 7:39 ` Hema Kalliguddi
2011-03-25 20:13 ` Jason Kridner
2011-03-25 20:13 ` Jason Kridner
2011-03-25 20:20 ` Arnd Bergmann
2011-03-25 20:20 ` Arnd Bergmann
2011-03-25 20:23 ` Nicolas Pitre
2011-03-25 20:23 ` Nicolas Pitre
2011-03-28 12:54 ` Jason Kridner
2011-03-28 12:54 ` Jason Kridner
2011-03-25 20:30 ` Andy Green
2011-03-25 20:30 ` Andy Green
2011-03-25 11:39 ` Arnd Bergmann [this message]
2011-03-25 11:39 ` Arnd Bergmann
2012-06-28 14:18 ` [RFC PATCH 0/2] OMAP2+: PANDA: Provide unique-ish MAC addresses for Ethernet and WLAN interfaces Arnd Bergmann
2012-06-28 14:18 ` Arnd Bergmann
2012-06-28 14:45 ` Steven Rostedt
2012-06-28 14:45 ` Steven Rostedt
2012-06-28 14:49 ` "Andy Green (林安廸)"
2012-06-28 14:49 ` "Andy Green (林安廸)"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103251239.54243.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andy.green@linaro.org \
--cc=andy@warmcat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=patches@linaro.org \
--cc=s-jan@ti.com \
--cc=tony@atomide.com \
--cc=x0132446@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.