From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Jason Kridner <jkridner@beagleboard.org>
Cc: Hema Kalliguddi <hemahk@ti.com>, Andy Green <andy@warmcat.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
patches@linaro.org, arnd@arndb.de, David Anders <x0132446@ti.com>,
Sebastien Jan <s-jan@ti.com>,
tony@atomide.com, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andy Green <andy.green@linaro.org>
Subject: Re: [RFC PATCH 2/2] OMAP2+: PANDA: Fix up random or missing MAC addresses for eth0 and wlan0
Date: Fri, 25 Mar 2011 16:23:21 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1103251615380.11889@xanadu.home> (raw)
In-Reply-To: <AANLkTineUsH=Qz83YKJy8YZ1KSE1si-RddQ9eBsPjMdk@mail.gmail.com>
On Fri, 25 Mar 2011, Jason Kridner wrote:
> I very much like this approach. I believed the ability to use the die
> ID to get a unique code was reasonable approach and that is why I
> didn't get an EEPROM put onto the BeagleBoard, though Gerald is
> looking at adding one on a future revision because the lack of one
> wasn't well received. Minor questions below.
If this code had been available and/or the procedure well documented
before then I believe the reception would have been better.
> The use of the OMAP die id below makes this OMAP specific and the list
> referenced below of the devices to be referenced makes it Panda
> specific. Is there a way to make the list board specific, but to make
> these functions that will be used across many OMAP platforms reusable?
> I believe that this current code will result in a lot of
> cut-and-paste. My preference is that this is accepted and that we
> make this more general when we add this to other OMAP platforms, but
> it'd be great to capture your suggestions on how to do so before those
> cut-and-paste patch sets start coming in.
It is true that this might get copied. But as I suggested to Andy, it
is best to wait and see how often this happens before generalizing the
approach. Consolidation is easier when you can see what is actually
common and what is board specific. Otherwise it is easy to
fall into the over-engineering trap.
Nicolas
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.pitre@linaro.org (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/2] OMAP2+: PANDA: Fix up random or missing MAC addresses for eth0 and wlan0
Date: Fri, 25 Mar 2011 16:23:21 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1103251615380.11889@xanadu.home> (raw)
In-Reply-To: <AANLkTineUsH=Qz83YKJy8YZ1KSE1si-RddQ9eBsPjMdk@mail.gmail.com>
On Fri, 25 Mar 2011, Jason Kridner wrote:
> I very much like this approach. I believed the ability to use the die
> ID to get a unique code was reasonable approach and that is why I
> didn't get an EEPROM put onto the BeagleBoard, though Gerald is
> looking at adding one on a future revision because the lack of one
> wasn't well received. Minor questions below.
If this code had been available and/or the procedure well documented
before then I believe the reception would have been better.
> The use of the OMAP die id below makes this OMAP specific and the list
> referenced below of the devices to be referenced makes it Panda
> specific. Is there a way to make the list board specific, but to make
> these functions that will be used across many OMAP platforms reusable?
> I believe that this current code will result in a lot of
> cut-and-paste. My preference is that this is accepted and that we
> make this more general when we add this to other OMAP platforms, but
> it'd be great to capture your suggestions on how to do so before those
> cut-and-paste patch sets start coming in.
It is true that this might get copied. But as I suggested to Andy, it
is best to wait and see how often this happens before generalizing the
approach. Consolidation is easier when you can see what is actually
common and what is board specific. Otherwise it is easy to
fall into the over-engineering trap.
Nicolas
next prev parent reply other threads:[~2011-03-25 20:23 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 21:27 [RFC PATCH 0/2] OMAP2+: PANDA: Provide unique-ish MAC addresses for Ethernet and WLAN interfaces Andy Green
2011-03-24 21:27 ` Andy Green
2011-03-24 21:27 ` [RFC PATCH 1/2] OMAP2+: add cpu id register to MAC address helper Andy Green
2011-03-24 21:27 ` Andy Green
2011-03-25 11:49 ` Arnd Bergmann
2011-03-25 11:49 ` Arnd Bergmann
2011-03-25 12:08 ` Andy Green
2011-03-25 12:08 ` Andy Green
2011-03-25 13:24 ` Arnd Bergmann
2011-03-25 13:24 ` Arnd Bergmann
2011-03-25 13:34 ` Andy Green
2011-03-25 13:34 ` Andy Green
2011-03-25 14:50 ` Arnd Bergmann
2011-03-25 14:50 ` Arnd Bergmann
2011-03-25 15:00 ` Andy Green
2011-03-25 15:00 ` Andy Green
2011-03-24 21:27 ` [RFC PATCH 2/2] OMAP2+: PANDA: Fix up random or missing MAC addresses for eth0 and wlan0 Andy Green
2011-03-24 21:27 ` Andy Green
2011-03-25 7:39 ` Hema Kalliguddi
2011-03-25 7:39 ` Hema Kalliguddi
2011-03-25 20:13 ` Jason Kridner
2011-03-25 20:13 ` Jason Kridner
2011-03-25 20:20 ` Arnd Bergmann
2011-03-25 20:20 ` Arnd Bergmann
2011-03-25 20:23 ` Nicolas Pitre [this message]
2011-03-25 20:23 ` Nicolas Pitre
2011-03-28 12:54 ` Jason Kridner
2011-03-28 12:54 ` Jason Kridner
2011-03-25 20:30 ` Andy Green
2011-03-25 20:30 ` Andy Green
2011-03-25 11:39 ` Arnd Bergmann
2011-03-25 11:39 ` Arnd Bergmann
2012-06-28 14:18 ` [RFC PATCH 0/2] OMAP2+: PANDA: Provide unique-ish MAC addresses for Ethernet and WLAN interfaces Arnd Bergmann
2012-06-28 14:18 ` Arnd Bergmann
2012-06-28 14:45 ` Steven Rostedt
2012-06-28 14:45 ` Steven Rostedt
2012-06-28 14:49 ` "Andy Green (林安廸)"
2012-06-28 14:49 ` "Andy Green (林安廸)"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1103251615380.11889@xanadu.home \
--to=nicolas.pitre@linaro.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andy.green@linaro.org \
--cc=andy@warmcat.com \
--cc=arnd@arndb.de \
--cc=hemahk@ti.com \
--cc=jkridner@beagleboard.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=patches@linaro.org \
--cc=s-jan@ti.com \
--cc=tony@atomide.com \
--cc=x0132446@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.