From: Tony Lindgren <tony@atomide.com>
To: Rabin Vincent <rabin@rab.in>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] OMAP: don't trace functions called from sched_clock
Date: Tue, 31 May 2011 04:49:35 -0700 [thread overview]
Message-ID: <20110531114935.GY11352@atomide.com> (raw)
In-Reply-To: <BANLkTi=imJXEKriWdXOGE_wWWkQvdtLAHg@mail.gmail.com>
* Rabin Vincent <rabin@rab.in> [110527 08:36]:
> Tony,
>
> On Sun, May 8, 2011 at 14:51, Rabin Vincent <rabin@rab.in> wrote:
> > omap_readl() is used from the sched_clock() implementations and so must
> > be marked notrace to avoid recursion in ftrace. Same thing with
> > mpu_read() for OMAP1.
We should rather ioremap the 32KSYNCT_BASE in omap_init_clocksource_32k
and then use __raw_readl. That allows us to get rid of omap_read usage
here and simplifies the code.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP: don't trace functions called from sched_clock
Date: Tue, 31 May 2011 04:49:35 -0700 [thread overview]
Message-ID: <20110531114935.GY11352@atomide.com> (raw)
In-Reply-To: <BANLkTi=imJXEKriWdXOGE_wWWkQvdtLAHg@mail.gmail.com>
* Rabin Vincent <rabin@rab.in> [110527 08:36]:
> Tony,
>
> On Sun, May 8, 2011 at 14:51, Rabin Vincent <rabin@rab.in> wrote:
> > omap_readl() is used from the sched_clock() implementations and so must
> > be marked notrace to avoid recursion in ftrace. ?Same thing with
> > mpu_read() for OMAP1.
We should rather ioremap the 32KSYNCT_BASE in omap_init_clocksource_32k
and then use __raw_readl. That allows us to get rid of omap_read usage
here and simplifies the code.
Regards,
Tony
next prev parent reply other threads:[~2011-05-31 11:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 9:21 [PATCH] OMAP: don't trace functions called from sched_clock Rabin Vincent
2011-05-08 9:21 ` Rabin Vincent
2011-05-27 15:33 ` Rabin Vincent
2011-05-27 15:33 ` Rabin Vincent
2011-05-31 11:49 ` Tony Lindgren [this message]
2011-05-31 11:49 ` Tony Lindgren
2011-05-27 20:39 ` Kevin Hilman
2011-05-27 20:39 ` Kevin Hilman
2011-05-28 0:32 ` Kevin Hilman
2011-05-28 0:32 ` Kevin Hilman
2011-05-31 11:50 ` Tony Lindgren
2011-05-31 11:50 ` Tony Lindgren
2011-05-31 16:13 ` Kevin Hilman
2011-05-31 16:13 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531114935.GY11352@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.