From: Kevin Hilman <khilman@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Rabin Vincent <rabin@rab.in>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] OMAP: don't trace functions called from sched_clock
Date: Tue, 31 May 2011 09:13:07 -0700 [thread overview]
Message-ID: <87oc2isvak.fsf@ti.com> (raw)
In-Reply-To: <20110531115039.GZ11352@atomide.com> (Tony Lindgren's message of "Tue, 31 May 2011 04:50:40 -0700")
Tony Lindgren <tony@atomide.com> writes:
> * Kevin Hilman <khilman@ti.com> [110527 17:28]:
>> Kevin Hilman <khilman@ti.com> writes:
>>
>> > Rabin Vincent <rabin@rab.in> writes:
>> >
>> >> omap_readl() is used from the sched_clock() implementations and so must
>> >> be marked notrace to avoid recursion in ftrace. Same thing with
>> >> mpu_read() for OMAP1.
>> >>
>> >> Signed-off-by: Rabin Vincent <rabin@rab.in>
>> >
>> > Acked-by: Kevin Hilman <khilman@ti.com>
>>
>> I also meant to suggest this should probably queue for .40-rc series.
>
> Took a quick look and we should get rid of the omap_readl usage instead
> like I commented in another mail.
Agreed, that's a better approach.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP: don't trace functions called from sched_clock
Date: Tue, 31 May 2011 09:13:07 -0700 [thread overview]
Message-ID: <87oc2isvak.fsf@ti.com> (raw)
In-Reply-To: <20110531115039.GZ11352@atomide.com> (Tony Lindgren's message of "Tue, 31 May 2011 04:50:40 -0700")
Tony Lindgren <tony@atomide.com> writes:
> * Kevin Hilman <khilman@ti.com> [110527 17:28]:
>> Kevin Hilman <khilman@ti.com> writes:
>>
>> > Rabin Vincent <rabin@rab.in> writes:
>> >
>> >> omap_readl() is used from the sched_clock() implementations and so must
>> >> be marked notrace to avoid recursion in ftrace. Same thing with
>> >> mpu_read() for OMAP1.
>> >>
>> >> Signed-off-by: Rabin Vincent <rabin@rab.in>
>> >
>> > Acked-by: Kevin Hilman <khilman@ti.com>
>>
>> I also meant to suggest this should probably queue for .40-rc series.
>
> Took a quick look and we should get rid of the omap_readl usage instead
> like I commented in another mail.
Agreed, that's a better approach.
Kevin
next prev parent reply other threads:[~2011-05-31 16:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 9:21 [PATCH] OMAP: don't trace functions called from sched_clock Rabin Vincent
2011-05-08 9:21 ` Rabin Vincent
2011-05-27 15:33 ` Rabin Vincent
2011-05-27 15:33 ` Rabin Vincent
2011-05-31 11:49 ` Tony Lindgren
2011-05-31 11:49 ` Tony Lindgren
2011-05-27 20:39 ` Kevin Hilman
2011-05-27 20:39 ` Kevin Hilman
2011-05-28 0:32 ` Kevin Hilman
2011-05-28 0:32 ` Kevin Hilman
2011-05-31 11:50 ` Tony Lindgren
2011-05-31 11:50 ` Tony Lindgren
2011-05-31 16:13 ` Kevin Hilman [this message]
2011-05-31 16:13 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oc2isvak.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rabin@rab.in \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.