All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: "Cousson, Benoit" <b-cousson-l0cyMroinI0@public.gmane.org>
Cc: Ohad Ben-Cohen <ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>,
	"Hilman, Kevin" <khilman-l0cyMroinI0@public.gmane.org>,
	Mathieu Poirier
	<mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org"
	<tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
	"G, Manjunath Kondaiah" <manjugk-l0cyMroinI0@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [RFC PATCH 06/10] hwspinlock: OMAP4: Add spinlock support in DT
Date: Thu, 8 Sep 2011 18:03:39 +0200	[thread overview]
Message-ID: <201109081803.40328.arnd@arndb.de> (raw)
In-Reply-To: <4E68E09B.4050006-l0cyMroinI0@public.gmane.org>

On Thursday 08 September 2011, Cousson, Benoit wrote:
> OK, this is indeed much more aligned with the current practice, and what 
> DMA should do as well.
> 
> Practically speaking, that change will go beyond the original scope of 
> that patch that was just adding the DT support based on the existing 
> functionality.
> 
> Is it OK to handle that improvement in a further patch / series?

I think we should be very careful to get the device tree syntax right
at first. So if you have a good representation of the data in the device
tree but don't handle all possible cases in the kernel yet, that's ok.

E.g. the kernel code can assume for now that the device tree has only
one spinlock controller node. We can fix that later when we actually
need more, but we would not easily be able to fix the device trees
after the fact.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 06/10] hwspinlock: OMAP4: Add spinlock support in DT
Date: Thu, 8 Sep 2011 18:03:39 +0200	[thread overview]
Message-ID: <201109081803.40328.arnd@arndb.de> (raw)
In-Reply-To: <4E68E09B.4050006@ti.com>

On Thursday 08 September 2011, Cousson, Benoit wrote:
> OK, this is indeed much more aligned with the current practice, and what 
> DMA should do as well.
> 
> Practically speaking, that change will go beyond the original scope of 
> that patch that was just adding the DT support based on the existing 
> functionality.
> 
> Is it OK to handle that improvement in a further patch / series?

I think we should be very careful to get the device tree syntax right
at first. So if you have a good representation of the data in the device
tree but don't handle all possible cases in the kernel yet, that's ok.

E.g. the kernel code can assume for now that the device tree has only
one spinlock controller node. We can fix that later when we actually
need more, but we would not easily be able to fix the device trees
after the fact.

	Arnd

  parent reply	other threads:[~2011-09-08 16:03 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24 13:09 [RFC PATCH 00/10] OMAP: Add DT support for early init OMAP4 devices Benoit Cousson
2011-08-24 13:09 ` Benoit Cousson
     [not found] ` <1314191356-10963-1-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-08-24 13:09   ` [RFC PATCH 01/10] OMAP2+: l3-noc: Add support for device-tree Benoit Cousson
2011-08-24 13:09     ` Benoit Cousson
2011-09-08 18:01     ` Grant Likely
2011-09-08 18:01       ` Grant Likely
     [not found]       ` <20110908180148.GA2967-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-09-08 21:59         ` Cousson, Benoit
2011-09-08 21:59           ` Cousson, Benoit
2011-09-08 23:35           ` Grant Likely
2011-09-08 23:35             ` Grant Likely
2011-08-24 13:09   ` [RFC PATCH 02/10] arm/dts: OMAP4: Add a main ocp entry bound to l3-noc driver Benoit Cousson
2011-08-24 13:09     ` Benoit Cousson
     [not found]     ` <1314191356-10963-3-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:03       ` Grant Likely
2011-09-08 18:03         ` Grant Likely
2011-09-09  0:10         ` Cousson, Benoit
2011-09-09  0:10           ` Cousson, Benoit
2011-09-09  2:41           ` Grant Likely
2011-09-09  2:41             ` Grant Likely
2011-08-24 13:09   ` [RFC PATCH 03/10] documentation/dt: Add l3-noc bindings Benoit Cousson
2011-08-24 13:09     ` Benoit Cousson
2011-09-08 18:06     ` Grant Likely
2011-09-08 18:06       ` Grant Likely
2011-09-09  0:18       ` Cousson, Benoit
2011-09-09  0:18         ` Cousson, Benoit
2011-08-24 13:09   ` [RFC PATCH 06/10] hwspinlock: OMAP4: Add spinlock support in DT Benoit Cousson
2011-08-24 13:09     ` Benoit Cousson
2011-09-07 19:58     ` Ohad Ben-Cohen
2011-09-07 19:58       ` Ohad Ben-Cohen
2011-09-08  7:14       ` Cousson, Benoit
2011-09-08  7:14         ` Cousson, Benoit
2011-09-08  7:56         ` Ohad Ben-Cohen
2011-09-08  7:56           ` Ohad Ben-Cohen
2011-09-08  8:07           ` Cousson, Benoit
2011-09-08  8:07             ` Cousson, Benoit
2011-09-08  8:11             ` Ohad Ben-Cohen
2011-09-08  8:11               ` Ohad Ben-Cohen
2011-09-08 14:47               ` Arnd Bergmann
2011-09-08 14:47                 ` Arnd Bergmann
2011-09-08 15:34                 ` Cousson, Benoit
2011-09-08 15:34                   ` Cousson, Benoit
     [not found]                   ` <4E68E09B.4050006-l0cyMroinI0@public.gmane.org>
2011-09-08 16:03                     ` Arnd Bergmann [this message]
2011-09-08 16:03                       ` Arnd Bergmann
     [not found]                 ` <201109081647.55377.arnd-r2nGTMty4D4@public.gmane.org>
2011-09-08 16:36                   ` Ohad Ben-Cohen
2011-09-08 16:36                     ` Ohad Ben-Cohen
2011-09-09 12:58                     ` Arnd Bergmann
2011-09-09 12:58                       ` Arnd Bergmann
2011-09-11  7:57                       ` Ohad Ben-Cohen
2011-09-11  7:57                         ` Ohad Ben-Cohen
2011-09-12 14:32                         ` Arnd Bergmann
2011-09-12 14:32                           ` Arnd Bergmann
2011-08-24 13:09 ` [RFC PATCH 04/10] arm/dts: OMAP4: Add mpu, dsp and iva nodes Benoit Cousson
2011-08-24 13:09   ` Benoit Cousson
     [not found]   ` <1314191356-10963-5-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:07     ` Grant Likely
2011-09-08 18:07       ` Grant Likely
2011-08-24 13:09 ` [RFC PATCH 05/10] documentation/dt: Add mpu, dsp and iva bindings Benoit Cousson
2011-08-24 13:09   ` Benoit Cousson
     [not found]   ` <1314191356-10963-6-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:09     ` Grant Likely
2011-09-08 18:09       ` Grant Likely
2011-09-09  0:30       ` Cousson, Benoit
2011-09-09  0:30         ` Cousson, Benoit
2011-09-09  2:40         ` Grant Likely
2011-09-09  2:40           ` Grant Likely
2011-08-24 13:09 ` [RFC PATCH 07/10] documentation/dt: Add spinlock bindings Benoit Cousson
2011-08-24 13:09   ` Benoit Cousson
     [not found]   ` <1314191356-10963-8-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:10     ` Grant Likely
2011-09-08 18:10       ` Grant Likely
2011-09-09  0:32       ` Cousson, Benoit
2011-09-09  0:32         ` Cousson, Benoit
2011-08-24 13:09 ` [RFC PATCH 08/10] gpio/omap: Adapt GPIO driver to DT Benoit Cousson
2011-08-24 13:09   ` Benoit Cousson
     [not found]   ` <1314191356-10963-9-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:15     ` Grant Likely
2011-09-08 18:15       ` Grant Likely
2011-09-09  1:48       ` Cousson, Benoit
2011-09-09  1:48         ` Cousson, Benoit
2011-08-24 13:09 ` [RFC PATCH 09/10] arm/dts: OMAP4: Add gpio nodes Benoit Cousson
2011-08-24 13:09   ` Benoit Cousson
     [not found]   ` <1314191356-10963-10-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:16     ` Grant Likely
2011-09-08 18:16       ` Grant Likely
2011-08-24 13:09 ` [RFC PATCH 10/10] documentation/dt: Add OMAP GPIO properties Benoit Cousson
2011-08-24 13:09   ` Benoit Cousson
     [not found]   ` <1314191356-10963-11-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:18     ` Grant Likely
2011-09-08 18:18       ` Grant Likely
2011-09-09  1:51       ` Cousson, Benoit
2011-09-09  1:51         ` Cousson, Benoit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109081803.40328.arnd@arndb.de \
    --to=arnd-r2ngtmty4d4@public.gmane.org \
    --cc=b-cousson-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=khilman-l0cyMroinI0@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=manjugk-l0cyMroinI0@public.gmane.org \
    --cc=mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.