All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: "Hilman, Kevin" <khilman@ti.com>,
	"tony@atomide.com" <tony@atomide.com>,
	"G, Manjunath Kondaiah" <manjugk@ti.com>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 03/10] documentation/dt: Add l3-noc bindings
Date: Fri, 9 Sep 2011 02:18:47 +0200	[thread overview]
Message-ID: <4E695B67.1010607@ti.com> (raw)
In-Reply-To: <20110908180604.GC2967@ponder.secretlab.ca>

On 9/8/2011 8:06 PM, Grant Likely wrote:
> On Wed, Aug 24, 2011 at 03:09:09PM +0200, Benoit Cousson wrote:
>> Add documentation for the l3-noc bindings.
>>
>> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
>> Cc: Randy Dunlap<rdunlap@xenotime.net>
>> ---
>>   .../devicetree/bindings/arm/omap/l3-noc.txt        |   18 ++++++++++++++++++
>>   1 files changed, 18 insertions(+), 0 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/arm/omap/l3-noc.txt
>>
>> diff --git a/Documentation/devicetree/bindings/arm/omap/l3-noc.txt b/Documentation/devicetree/bindings/arm/omap/l3-noc.txt
>> new file mode 100644
>> index 0000000..dbfa878
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/omap/l3-noc.txt
>> @@ -0,0 +1,18 @@
>> +* TI - L3 Network On Chip (NoC)
>> +
>> +This version is an implementation of the generic NoC IP
>> +provided by Arteris.
>
> Hahaha.  Here's the documentation.  Okay.
>
>> +
>> +Required properties:
>> +- compatible : Should be "ti,l3-noc", "arteris,noc"
>
> Should probably be "ti,omap4-l3-noc", and it isn't necessary to have a
> value for the IP core vendor... or at least if an arteris value is
> provided, then it should have some form of ip-core version
> information.

OK, in that case, the noc version is clearly not obvious to get, so I'll 
get rid of that compatible value.

>
>> +- hwmods: "l3_main_1", ... One hwmod for each noc domain.
>
> Is there some documentation on how the "hwmods" property is to be
> used?

Yes, it is part of the generic OMAP bindings documentation:
http://lists.ozlabs.org/pipermail/devicetree-discuss/2011-August/007621.html

> I expect that this should be "ti,hwmods" because this is a TI
> specific property.

OK.

Benoit

WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 03/10] documentation/dt: Add l3-noc bindings
Date: Fri, 9 Sep 2011 02:18:47 +0200	[thread overview]
Message-ID: <4E695B67.1010607@ti.com> (raw)
In-Reply-To: <20110908180604.GC2967@ponder.secretlab.ca>

On 9/8/2011 8:06 PM, Grant Likely wrote:
> On Wed, Aug 24, 2011 at 03:09:09PM +0200, Benoit Cousson wrote:
>> Add documentation for the l3-noc bindings.
>>
>> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
>> Cc: Randy Dunlap<rdunlap@xenotime.net>
>> ---
>>   .../devicetree/bindings/arm/omap/l3-noc.txt        |   18 ++++++++++++++++++
>>   1 files changed, 18 insertions(+), 0 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/arm/omap/l3-noc.txt
>>
>> diff --git a/Documentation/devicetree/bindings/arm/omap/l3-noc.txt b/Documentation/devicetree/bindings/arm/omap/l3-noc.txt
>> new file mode 100644
>> index 0000000..dbfa878
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/omap/l3-noc.txt
>> @@ -0,0 +1,18 @@
>> +* TI - L3 Network On Chip (NoC)
>> +
>> +This version is an implementation of the generic NoC IP
>> +provided by Arteris.
>
> Hahaha.  Here's the documentation.  Okay.
>
>> +
>> +Required properties:
>> +- compatible : Should be "ti,l3-noc", "arteris,noc"
>
> Should probably be "ti,omap4-l3-noc", and it isn't necessary to have a
> value for the IP core vendor... or at least if an arteris value is
> provided, then it should have some form of ip-core version
> information.

OK, in that case, the noc version is clearly not obvious to get, so I'll 
get rid of that compatible value.

>
>> +- hwmods: "l3_main_1", ... One hwmod for each noc domain.
>
> Is there some documentation on how the "hwmods" property is to be
> used?

Yes, it is part of the generic OMAP bindings documentation:
http://lists.ozlabs.org/pipermail/devicetree-discuss/2011-August/007621.html

> I expect that this should be "ti,hwmods" because this is a TI
> specific property.

OK.

Benoit

  reply	other threads:[~2011-09-09  0:18 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24 13:09 [RFC PATCH 00/10] OMAP: Add DT support for early init OMAP4 devices Benoit Cousson
2011-08-24 13:09 ` Benoit Cousson
     [not found] ` <1314191356-10963-1-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-08-24 13:09   ` [RFC PATCH 01/10] OMAP2+: l3-noc: Add support for device-tree Benoit Cousson
2011-08-24 13:09     ` Benoit Cousson
2011-09-08 18:01     ` Grant Likely
2011-09-08 18:01       ` Grant Likely
     [not found]       ` <20110908180148.GA2967-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-09-08 21:59         ` Cousson, Benoit
2011-09-08 21:59           ` Cousson, Benoit
2011-09-08 23:35           ` Grant Likely
2011-09-08 23:35             ` Grant Likely
2011-08-24 13:09   ` [RFC PATCH 02/10] arm/dts: OMAP4: Add a main ocp entry bound to l3-noc driver Benoit Cousson
2011-08-24 13:09     ` Benoit Cousson
     [not found]     ` <1314191356-10963-3-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:03       ` Grant Likely
2011-09-08 18:03         ` Grant Likely
2011-09-09  0:10         ` Cousson, Benoit
2011-09-09  0:10           ` Cousson, Benoit
2011-09-09  2:41           ` Grant Likely
2011-09-09  2:41             ` Grant Likely
2011-08-24 13:09   ` [RFC PATCH 03/10] documentation/dt: Add l3-noc bindings Benoit Cousson
2011-08-24 13:09     ` Benoit Cousson
2011-09-08 18:06     ` Grant Likely
2011-09-08 18:06       ` Grant Likely
2011-09-09  0:18       ` Cousson, Benoit [this message]
2011-09-09  0:18         ` Cousson, Benoit
2011-08-24 13:09   ` [RFC PATCH 06/10] hwspinlock: OMAP4: Add spinlock support in DT Benoit Cousson
2011-08-24 13:09     ` Benoit Cousson
2011-09-07 19:58     ` Ohad Ben-Cohen
2011-09-07 19:58       ` Ohad Ben-Cohen
2011-09-08  7:14       ` Cousson, Benoit
2011-09-08  7:14         ` Cousson, Benoit
2011-09-08  7:56         ` Ohad Ben-Cohen
2011-09-08  7:56           ` Ohad Ben-Cohen
2011-09-08  8:07           ` Cousson, Benoit
2011-09-08  8:07             ` Cousson, Benoit
2011-09-08  8:11             ` Ohad Ben-Cohen
2011-09-08  8:11               ` Ohad Ben-Cohen
2011-09-08 14:47               ` Arnd Bergmann
2011-09-08 14:47                 ` Arnd Bergmann
2011-09-08 15:34                 ` Cousson, Benoit
2011-09-08 15:34                   ` Cousson, Benoit
     [not found]                   ` <4E68E09B.4050006-l0cyMroinI0@public.gmane.org>
2011-09-08 16:03                     ` Arnd Bergmann
2011-09-08 16:03                       ` Arnd Bergmann
     [not found]                 ` <201109081647.55377.arnd-r2nGTMty4D4@public.gmane.org>
2011-09-08 16:36                   ` Ohad Ben-Cohen
2011-09-08 16:36                     ` Ohad Ben-Cohen
2011-09-09 12:58                     ` Arnd Bergmann
2011-09-09 12:58                       ` Arnd Bergmann
2011-09-11  7:57                       ` Ohad Ben-Cohen
2011-09-11  7:57                         ` Ohad Ben-Cohen
2011-09-12 14:32                         ` Arnd Bergmann
2011-09-12 14:32                           ` Arnd Bergmann
2011-08-24 13:09 ` [RFC PATCH 04/10] arm/dts: OMAP4: Add mpu, dsp and iva nodes Benoit Cousson
2011-08-24 13:09   ` Benoit Cousson
     [not found]   ` <1314191356-10963-5-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:07     ` Grant Likely
2011-09-08 18:07       ` Grant Likely
2011-08-24 13:09 ` [RFC PATCH 05/10] documentation/dt: Add mpu, dsp and iva bindings Benoit Cousson
2011-08-24 13:09   ` Benoit Cousson
     [not found]   ` <1314191356-10963-6-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:09     ` Grant Likely
2011-09-08 18:09       ` Grant Likely
2011-09-09  0:30       ` Cousson, Benoit
2011-09-09  0:30         ` Cousson, Benoit
2011-09-09  2:40         ` Grant Likely
2011-09-09  2:40           ` Grant Likely
2011-08-24 13:09 ` [RFC PATCH 07/10] documentation/dt: Add spinlock bindings Benoit Cousson
2011-08-24 13:09   ` Benoit Cousson
     [not found]   ` <1314191356-10963-8-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:10     ` Grant Likely
2011-09-08 18:10       ` Grant Likely
2011-09-09  0:32       ` Cousson, Benoit
2011-09-09  0:32         ` Cousson, Benoit
2011-08-24 13:09 ` [RFC PATCH 08/10] gpio/omap: Adapt GPIO driver to DT Benoit Cousson
2011-08-24 13:09   ` Benoit Cousson
     [not found]   ` <1314191356-10963-9-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:15     ` Grant Likely
2011-09-08 18:15       ` Grant Likely
2011-09-09  1:48       ` Cousson, Benoit
2011-09-09  1:48         ` Cousson, Benoit
2011-08-24 13:09 ` [RFC PATCH 09/10] arm/dts: OMAP4: Add gpio nodes Benoit Cousson
2011-08-24 13:09   ` Benoit Cousson
     [not found]   ` <1314191356-10963-10-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:16     ` Grant Likely
2011-09-08 18:16       ` Grant Likely
2011-08-24 13:09 ` [RFC PATCH 10/10] documentation/dt: Add OMAP GPIO properties Benoit Cousson
2011-08-24 13:09   ` Benoit Cousson
     [not found]   ` <1314191356-10963-11-git-send-email-b-cousson-l0cyMroinI0@public.gmane.org>
2011-09-08 18:18     ` Grant Likely
2011-09-08 18:18       ` Grant Likely
2011-09-09  1:51       ` Cousson, Benoit
2011-09-09  1:51         ` Cousson, Benoit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E695B67.1010607@ti.com \
    --to=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=manjugk@ti.com \
    --cc=rdunlap@xenotime.net \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.