All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: dts: mxs: Add alternative I2C muxing options for imx28
Date: Thu, 23 Aug 2012 14:33:48 +0000	[thread overview]
Message-ID: <20120823143344.GJ24242@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1345711351-16367-3-git-send-email-maxime.ripard@free-electrons.com>

On Thu, Aug 23, 2012 at 10:42:29AM +0200, Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Brian Lilly <brian@crystalfontz.com>
> ---
>  arch/arm/boot/dts/imx28.dtsi |   11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 787efac..f6ffcd9 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -410,6 +410,17 @@
>  					fsl,pull-up = <1>;
>  				};
>  
> +				i2c0_pins_b: i2c0@1 {
> +					reg = <1>;
> +					fsl,pinmux-ids = <
> +						0x3001 /* MX28_PAD_AUART0_RX__DUART_CTS */
> +						0x3011 /* MX28_PAD_AUART0_TX__DUART_RTS */

The comments are wrong.  I fixed them as below and applied the patch.

						0x3001 /* MX28_PAD_AUART0_RX__I2C0_SCL */
						0x3011 /* MX28_PAD_AUART0_TX__I2C0_SDA */

Regards,
Shawn


> +					>;
> +					fsl,drive-strength = <1>;
> +					fsl,voltage = <1>;
> +					fsl,pull-up = <1>;
> +				};
> +
>  				saif0_pins_a: saif0@0 {
>  					reg = <0>;
>  					fsl,pinmux-ids = <
> -- 
> 1.7.9.5
> 

WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: dts: mxs: Add alternative I2C muxing options for imx28
Date: Thu, 23 Aug 2012 22:33:48 +0800	[thread overview]
Message-ID: <20120823143344.GJ24242@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1345711351-16367-3-git-send-email-maxime.ripard@free-electrons.com>

On Thu, Aug 23, 2012 at 10:42:29AM +0200, Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Brian Lilly <brian@crystalfontz.com>
> ---
>  arch/arm/boot/dts/imx28.dtsi |   11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 787efac..f6ffcd9 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -410,6 +410,17 @@
>  					fsl,pull-up = <1>;
>  				};
>  
> +				i2c0_pins_b: i2c0 at 1 {
> +					reg = <1>;
> +					fsl,pinmux-ids = <
> +						0x3001 /* MX28_PAD_AUART0_RX__DUART_CTS */
> +						0x3011 /* MX28_PAD_AUART0_TX__DUART_RTS */

The comments are wrong.  I fixed them as below and applied the patch.

						0x3001 /* MX28_PAD_AUART0_RX__I2C0_SCL */
						0x3011 /* MX28_PAD_AUART0_TX__I2C0_SDA */

Regards,
Shawn


> +					>;
> +					fsl,drive-strength = <1>;
> +					fsl,voltage = <1>;
> +					fsl,pull-up = <1>;
> +				};
> +
>  				saif0_pins_a: saif0 at 0 {
>  					reg = <0>;
>  					fsl,pinmux-ids = <
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2012-08-23 14:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23  8:42 [PATCHv3 0/4] Maxime Ripard
2012-08-23  8:42 ` Maxime Ripard
2012-08-23  8:42 ` [PATCH 1/4] video: Add support for the Solomon SSD1307 OLED Controller Maxime Ripard
2012-08-23  8:42   ` Maxime Ripard
2012-08-23  8:42 ` [PATCH 2/4] ARM: dts: mxs: Add alternative I2C muxing options for imx28 Maxime Ripard
2012-08-23  8:42   ` Maxime Ripard
2012-08-23 14:33   ` Shawn Guo [this message]
2012-08-23 14:33     ` Shawn Guo
2012-08-23  8:42 ` [PATCH 3/4] ARM: dts: mxs: Add pwm4 " Maxime Ripard
2012-08-23  8:42   ` Maxime Ripard
2012-08-23 14:34   ` Shawn Guo
2012-08-23 14:34     ` Shawn Guo
2012-08-23  8:42 ` [PATCH 4/4] ARM: dts: mxs: add oled support for the cfa-10036 Maxime Ripard
2012-08-23  8:42   ` Maxime Ripard
2012-08-23 14:45   ` Shawn Guo
2012-08-23 14:45     ` Shawn Guo
2012-08-29 13:40     ` Maxime Ripard
2012-08-29 13:40       ` Maxime Ripard
  -- strict thread matches above, loose matches on Subject: below --
2012-07-31 10:29 [PATCHv2 0/4] Add support for the OLED in the CFA10036 Maxime Ripard
2012-07-31 10:29 ` [PATCH 2/4] ARM: dts: mxs: Add alternative I2C muxing options for imx28 Maxime Ripard
2012-07-31 10:29   ` Maxime Ripard
2012-07-31 12:02   ` Fabio Estevam
2012-07-31 12:02     ` Fabio Estevam
2012-08-01  9:46     ` Maxime Ripard
2012-08-01  9:46       ` Maxime Ripard
2012-07-17 15:59 [PATCH 0/4] Add support for the OLED in the CFA10036 Maxime Ripard
2012-07-17 15:59 ` [PATCH 2/4] ARM: dts: mxs: Add alternative I2C muxing options for imx28 Maxime Ripard
2012-07-17 15:59   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120823143344.GJ24242@S2101-09.ap.freescale.net \
    --to=shawn.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.