All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Takao Indoh <indou.takao@jp.fujitsu.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, bhelgaas@google.com, hbabu@us.ibm.com,
	ishii.hironobu@jp.fujitsu.com, martin.wilck@ts.fujitsu.com
Subject: Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu
Date: Tue, 11 Sep 2012 10:43:23 -0400	[thread overview]
Message-ID: <20120911144323.GF12039@redhat.com> (raw)
In-Reply-To: <504F1343.7030607@jp.fujitsu.com>

On Tue, Sep 11, 2012 at 07:32:35PM +0900, Takao Indoh wrote:

[..]
> I'll post new patch which clears bus master bit and resets devices in
> second kernel.
> 
> As to the boot parameter to enable this function, you suggested using
> reset_devices. I found that on a certain platform resetting devices
> caused PCIe error due to a hardware bug. Therefore I think we need
> new parameter apart from reset_devices to disable this function on
> such a machine.

Can you explain a bit more how the error happens. I still don't think
that because of a bug in a platform somewhere we should be introducing
a separate command line parameter and not reuse the exisiting one. Also
you have not explained what's the bug and how a new parameter will 
avoid the bug.

Thanks
Vivek

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Takao Indoh <indou.takao@jp.fujitsu.com>
Cc: martin.wilck@ts.fujitsu.com, linux-pci@vger.kernel.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	hbabu@us.ibm.com, ishii.hironobu@jp.fujitsu.com,
	bhelgaas@google.com
Subject: Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu
Date: Tue, 11 Sep 2012 10:43:23 -0400	[thread overview]
Message-ID: <20120911144323.GF12039@redhat.com> (raw)
In-Reply-To: <504F1343.7030607@jp.fujitsu.com>

On Tue, Sep 11, 2012 at 07:32:35PM +0900, Takao Indoh wrote:

[..]
> I'll post new patch which clears bus master bit and resets devices in
> second kernel.
> 
> As to the boot parameter to enable this function, you suggested using
> reset_devices. I found that on a certain platform resetting devices
> caused PCIe error due to a hardware bug. Therefore I think we need
> new parameter apart from reset_devices to disable this function on
> such a machine.

Can you explain a bit more how the error happens. I still don't think
that because of a bug in a platform somewhere we should be introducing
a separate command line parameter and not reuse the exisiting one. Also
you have not explained what's the bug and how a new parameter will 
avoid the bug.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2012-09-11 14:45 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 11:24 [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu Takao Indoh
2012-08-03 11:24 ` Takao Indoh
2012-08-03 11:46 ` Vivek Goyal
2012-08-03 11:46   ` Vivek Goyal
2012-08-06  4:30   ` Takao Indoh
2012-08-06  4:30     ` Takao Indoh
2012-08-06 20:39     ` Vivek Goyal
2012-08-06 20:39       ` Vivek Goyal
2012-08-07  9:02       ` Takao Indoh
2012-08-07  9:02         ` Takao Indoh
2012-09-05 11:09       ` Takao Indoh
2012-09-05 11:09         ` Takao Indoh
2012-09-10  2:34         ` Kaneshige, Kenji
2012-09-10  2:34           ` Kaneshige, Kenji
2012-09-10  6:35           ` Takao Indoh
2012-09-10  6:35             ` Takao Indoh
2012-09-11 11:52             ` Kaneshige, Kenji
2012-09-11 11:52               ` Kaneshige, Kenji
2012-09-10 14:36         ` Vivek Goyal
2012-09-10 14:36           ` Vivek Goyal
2012-09-11 10:32           ` Takao Indoh
2012-09-11 10:32             ` Takao Indoh
2012-09-11 14:43             ` Vivek Goyal [this message]
2012-09-11 14:43               ` Vivek Goyal
2012-09-12  9:00               ` Takao Indoh
2012-09-12  9:00                 ` Takao Indoh
2012-09-14 15:48                 ` Vivek Goyal
2012-09-14 15:48                   ` Vivek Goyal
2012-09-24 11:22                   ` Takao Indoh
2012-09-24 11:22                     ` Takao Indoh
2012-09-14 20:03             ` Konrad Rzeszutek Wilk
2012-09-14 20:03               ` Konrad Rzeszutek Wilk
2012-09-19  1:52               ` Takao Indoh
2012-09-19  1:52                 ` Takao Indoh
2012-09-21 17:57               ` Don Dutile
2012-09-21 17:57                 ` Don Dutile
2012-09-24 11:12                 ` Takao Indoh
2012-09-24 11:12                   ` Takao Indoh
2012-08-06  4:09 ` Don Dutile
2012-08-06  4:09   ` Don Dutile
2012-08-06  4:45   ` Takao Indoh
2012-08-06  4:45     ` Takao Indoh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120911144323.GF12039@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=hbabu@us.ibm.com \
    --cc=indou.takao@jp.fujitsu.com \
    --cc=ishii.hironobu@jp.fujitsu.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=martin.wilck@ts.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.