From: Takao Indoh <indou.takao@jp.fujitsu.com> To: vgoyal@redhat.com Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, bhelgaas@google.com, hbabu@us.ibm.com, ishii.hironobu@jp.fujitsu.com, martin.wilck@ts.fujitsu.com Subject: Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu Date: Mon, 24 Sep 2012 20:22:02 +0900 [thread overview] Message-ID: <5060425A.8030303@jp.fujitsu.com> (raw) In-Reply-To: <20120914154817.GE6221@redhat.com> (2012/09/15 0:48), Vivek Goyal wrote: > On Wed, Sep 12, 2012 at 06:00:55PM +0900, Takao Indoh wrote: >> (2012/09/11 23:43), Vivek Goyal wrote: >>> On Tue, Sep 11, 2012 at 07:32:35PM +0900, Takao Indoh wrote: >>> >>> [..] >>>> I'll post new patch which clears bus master bit and resets devices in >>>> second kernel. >>>> >>>> As to the boot parameter to enable this function, you suggested using >>>> reset_devices. I found that on a certain platform resetting devices >>>> caused PCIe error due to a hardware bug. Therefore I think we need >>>> new parameter apart from reset_devices to disable this function on >>>> such a machine. >>> >>> Can you explain a bit more how the error happens. I still don't think >>> that because of a bug in a platform somewhere we should be introducing >>> a separate command line parameter and not reuse the exisiting one. Also >>> you have not explained what's the bug and how a new parameter will >>> avoid the bug. >> >> The bug I mentioned is that ACS Violation occurs at PCIe switch when >> reading PCI configuration after device reset. I got information that >> this violation is caused by PCIe switch bug. The machine becomes fatal >> status by this error. >> >> The reason why I try to introduce new parameter is that I want to avoid >> regression by this patch. Let's say this patch was included in kernel >> and its reset function was enabled by reset_devices as you said. AFAIK >> reset_devices is always needed for kdump, so it means that devices are >> always reset at kdump boot time. It causes a regression that system >> always becomes abnormal status when we run kdump on the machine which has >> a bug I mentioned. >> >> To avoid this regression, I want to separate reset_devices from this >> reset function. Or how about this? >> - if user specify reset_devices, devices are reset by this patch, as you >> said. >> - To avoid a regression I said, add new parameter like "pci=noreset". >> If this parameter is specified, the reset function I add is disabled >> and we can avoid regression. > > Can we identify that particular switch in code and not reset it in code. > Introducing new paramenters to avoid bugs really feels odd. Maybe we can do it using PCI quirk or DMI quirk as Konrad and Don said. But I'm still thinking whether I can add boot parameter or something to disable reset function so that we can use it as workaround untill we add quirk when we find such a buggy hardware. > Also, what was the conclusion to avoid double reset. I am assuming that > we don't want to do bus level reset as well as driver level reset based > on reset_devices. I don't have a good idea to do it yet. Maybe we need to write bus:slot:func information to somewhere when we reset device. Thanks, Takao Indoh
WARNING: multiple messages have this Message-ID (diff)
From: Takao Indoh <indou.takao@jp.fujitsu.com> To: vgoyal@redhat.com Cc: martin.wilck@ts.fujitsu.com, linux-pci@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, hbabu@us.ibm.com, ishii.hironobu@jp.fujitsu.com, bhelgaas@google.com Subject: Re: [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu Date: Mon, 24 Sep 2012 20:22:02 +0900 [thread overview] Message-ID: <5060425A.8030303@jp.fujitsu.com> (raw) In-Reply-To: <20120914154817.GE6221@redhat.com> (2012/09/15 0:48), Vivek Goyal wrote: > On Wed, Sep 12, 2012 at 06:00:55PM +0900, Takao Indoh wrote: >> (2012/09/11 23:43), Vivek Goyal wrote: >>> On Tue, Sep 11, 2012 at 07:32:35PM +0900, Takao Indoh wrote: >>> >>> [..] >>>> I'll post new patch which clears bus master bit and resets devices in >>>> second kernel. >>>> >>>> As to the boot parameter to enable this function, you suggested using >>>> reset_devices. I found that on a certain platform resetting devices >>>> caused PCIe error due to a hardware bug. Therefore I think we need >>>> new parameter apart from reset_devices to disable this function on >>>> such a machine. >>> >>> Can you explain a bit more how the error happens. I still don't think >>> that because of a bug in a platform somewhere we should be introducing >>> a separate command line parameter and not reuse the exisiting one. Also >>> you have not explained what's the bug and how a new parameter will >>> avoid the bug. >> >> The bug I mentioned is that ACS Violation occurs at PCIe switch when >> reading PCI configuration after device reset. I got information that >> this violation is caused by PCIe switch bug. The machine becomes fatal >> status by this error. >> >> The reason why I try to introduce new parameter is that I want to avoid >> regression by this patch. Let's say this patch was included in kernel >> and its reset function was enabled by reset_devices as you said. AFAIK >> reset_devices is always needed for kdump, so it means that devices are >> always reset at kdump boot time. It causes a regression that system >> always becomes abnormal status when we run kdump on the machine which has >> a bug I mentioned. >> >> To avoid this regression, I want to separate reset_devices from this >> reset function. Or how about this? >> - if user specify reset_devices, devices are reset by this patch, as you >> said. >> - To avoid a regression I said, add new parameter like "pci=noreset". >> If this parameter is specified, the reset function I add is disabled >> and we can avoid regression. > > Can we identify that particular switch in code and not reset it in code. > Introducing new paramenters to avoid bugs really feels odd. Maybe we can do it using PCI quirk or DMI quirk as Konrad and Don said. But I'm still thinking whether I can add boot parameter or something to disable reset function so that we can use it as workaround untill we add quirk when we find such a buggy hardware. > Also, what was the conclusion to avoid double reset. I am assuming that > we don't want to do bus level reset as well as driver level reset based > on reset_devices. I don't have a good idea to do it yet. Maybe we need to write bus:slot:func information to somewhere when we reset device. Thanks, Takao Indoh _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2012-09-24 11:26 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-03 11:24 [RFC][PATCH] Reset PCIe devices to address DMA problem on kdump with iommu Takao Indoh 2012-08-03 11:24 ` Takao Indoh 2012-08-03 11:46 ` Vivek Goyal 2012-08-03 11:46 ` Vivek Goyal 2012-08-06 4:30 ` Takao Indoh 2012-08-06 4:30 ` Takao Indoh 2012-08-06 20:39 ` Vivek Goyal 2012-08-06 20:39 ` Vivek Goyal 2012-08-07 9:02 ` Takao Indoh 2012-08-07 9:02 ` Takao Indoh 2012-09-05 11:09 ` Takao Indoh 2012-09-05 11:09 ` Takao Indoh 2012-09-10 2:34 ` Kaneshige, Kenji 2012-09-10 2:34 ` Kaneshige, Kenji 2012-09-10 6:35 ` Takao Indoh 2012-09-10 6:35 ` Takao Indoh 2012-09-11 11:52 ` Kaneshige, Kenji 2012-09-11 11:52 ` Kaneshige, Kenji 2012-09-10 14:36 ` Vivek Goyal 2012-09-10 14:36 ` Vivek Goyal 2012-09-11 10:32 ` Takao Indoh 2012-09-11 10:32 ` Takao Indoh 2012-09-11 14:43 ` Vivek Goyal 2012-09-11 14:43 ` Vivek Goyal 2012-09-12 9:00 ` Takao Indoh 2012-09-12 9:00 ` Takao Indoh 2012-09-14 15:48 ` Vivek Goyal 2012-09-14 15:48 ` Vivek Goyal 2012-09-24 11:22 ` Takao Indoh [this message] 2012-09-24 11:22 ` Takao Indoh 2012-09-14 20:03 ` Konrad Rzeszutek Wilk 2012-09-14 20:03 ` Konrad Rzeszutek Wilk 2012-09-19 1:52 ` Takao Indoh 2012-09-19 1:52 ` Takao Indoh 2012-09-21 17:57 ` Don Dutile 2012-09-21 17:57 ` Don Dutile 2012-09-24 11:12 ` Takao Indoh 2012-09-24 11:12 ` Takao Indoh 2012-08-06 4:09 ` Don Dutile 2012-08-06 4:09 ` Don Dutile 2012-08-06 4:45 ` Takao Indoh 2012-08-06 4:45 ` Takao Indoh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5060425A.8030303@jp.fujitsu.com \ --to=indou.takao@jp.fujitsu.com \ --cc=bhelgaas@google.com \ --cc=hbabu@us.ibm.com \ --cc=ishii.hironobu@jp.fujitsu.com \ --cc=kexec@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=martin.wilck@ts.fujitsu.com \ --cc=vgoyal@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.