From: Tony Lindgren <tony@atomide.com>
To: Jon Hunter <jon-hunter@ti.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 07/16] ARM: OMAP: Make plat/sram.h local to plat-omap
Date: Mon, 8 Oct 2012 09:31:36 -0700 [thread overview]
Message-ID: <20121008163136.GE3874@atomide.com> (raw)
In-Reply-To: <506EE79B.8040507@ti.com>
* Jon Hunter <jon-hunter@ti.com> [121005 07:00]:
> Hi Tony,
>
> On 10/04/2012 05:04 PM, Tony Lindgren wrote:
> > We can move this from plat to be local to plat-omap
> > for common ARM zImage support.
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> > arch/arm/mach-omap1/clock.c | 3 -
> > arch/arm/mach-omap1/clock_data.c | 3 -
> > arch/arm/mach-omap1/devices.c | 2
> > arch/arm/mach-omap1/pm.c | 3 -
> > arch/arm/mach-omap2/clkt2xxx_dpllcore.c | 3 -
> > arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 3 -
> > arch/arm/mach-omap2/clkt34xx_dpll3m2.c | 3 -
> > arch/arm/mach-omap2/io.c | 3 -
> > arch/arm/mach-omap2/omap4-common.c | 4 -
> > arch/arm/mach-omap2/pm24xx.c | 3 -
> > arch/arm/mach-omap2/pm34xx.c | 3 -
> > arch/arm/mach-omap2/sdrc.c | 2
> > arch/arm/mach-omap2/sdrc2xxx.c | 2
> > arch/arm/mach-omap2/sleep34xx.S | 2
> > arch/arm/plat-omap/common.h | 2
> > arch/arm/plat-omap/include/plat/sram.h | 105 -------------------------
> > arch/arm/plat-omap/sram.c | 1
> > arch/arm/plat-omap/sram.h | 109 +++++++++++++++++++++++++-
> > 18 files changed, 130 insertions(+), 126 deletions(-)
> > delete mode 100644 arch/arm/plat-omap/include/plat/sram.h
> >
> > diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c
> > index 638f407..b15d4ee 100644
> > --- a/arch/arm/mach-omap1/clock.c
> > +++ b/arch/arm/mach-omap1/clock.c
> > @@ -24,11 +24,12 @@
> > #include <plat/cpu.h>
> > #include <plat/usb.h>
> > #include <plat/clock.h>
> > -#include <plat/sram.h>
> > #include <plat/clkdev_omap.h>
> >
> > #include <mach/hardware.h>
> >
> > +#include "../plat-omap/sram.h"
>
> Any reason why you did not put this in
> arch/arm/plat-omap/include/plat-omap/ like we were discussing for dma
> and dmtimers headers? Then it can be just "#include <plat-omap/sram.h>".
> Just curious ...
Because plat-omap/sram.h is still available for (mis)use by drivers
and there's no need to expose it.
Eventually our plat-omap/sram.c will be converted to be just a
device driver using the common sram driver. Then it will need
a local sram.h and include/platform_data/sram-omap.h for the
legacy non-dt boot.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/16] ARM: OMAP: Make plat/sram.h local to plat-omap
Date: Mon, 8 Oct 2012 09:31:36 -0700 [thread overview]
Message-ID: <20121008163136.GE3874@atomide.com> (raw)
In-Reply-To: <506EE79B.8040507@ti.com>
* Jon Hunter <jon-hunter@ti.com> [121005 07:00]:
> Hi Tony,
>
> On 10/04/2012 05:04 PM, Tony Lindgren wrote:
> > We can move this from plat to be local to plat-omap
> > for common ARM zImage support.
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> > arch/arm/mach-omap1/clock.c | 3 -
> > arch/arm/mach-omap1/clock_data.c | 3 -
> > arch/arm/mach-omap1/devices.c | 2
> > arch/arm/mach-omap1/pm.c | 3 -
> > arch/arm/mach-omap2/clkt2xxx_dpllcore.c | 3 -
> > arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 3 -
> > arch/arm/mach-omap2/clkt34xx_dpll3m2.c | 3 -
> > arch/arm/mach-omap2/io.c | 3 -
> > arch/arm/mach-omap2/omap4-common.c | 4 -
> > arch/arm/mach-omap2/pm24xx.c | 3 -
> > arch/arm/mach-omap2/pm34xx.c | 3 -
> > arch/arm/mach-omap2/sdrc.c | 2
> > arch/arm/mach-omap2/sdrc2xxx.c | 2
> > arch/arm/mach-omap2/sleep34xx.S | 2
> > arch/arm/plat-omap/common.h | 2
> > arch/arm/plat-omap/include/plat/sram.h | 105 -------------------------
> > arch/arm/plat-omap/sram.c | 1
> > arch/arm/plat-omap/sram.h | 109 +++++++++++++++++++++++++-
> > 18 files changed, 130 insertions(+), 126 deletions(-)
> > delete mode 100644 arch/arm/plat-omap/include/plat/sram.h
> >
> > diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c
> > index 638f407..b15d4ee 100644
> > --- a/arch/arm/mach-omap1/clock.c
> > +++ b/arch/arm/mach-omap1/clock.c
> > @@ -24,11 +24,12 @@
> > #include <plat/cpu.h>
> > #include <plat/usb.h>
> > #include <plat/clock.h>
> > -#include <plat/sram.h>
> > #include <plat/clkdev_omap.h>
> >
> > #include <mach/hardware.h>
> >
> > +#include "../plat-omap/sram.h"
>
> Any reason why you did not put this in
> arch/arm/plat-omap/include/plat-omap/ like we were discussing for dma
> and dmtimers headers? Then it can be just "#include <plat-omap/sram.h>".
> Just curious ...
Because plat-omap/sram.h is still available for (mis)use by drivers
and there's no need to expose it.
Eventually our plat-omap/sram.c will be converted to be just a
device driver using the common sram driver. Then it will need
a local sram.h and include/platform_data/sram-omap.h for the
legacy non-dt boot.
Regards,
Tony
next prev parent reply other threads:[~2012-10-08 16:31 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 22:04 [PATCH 00/16] More omap plat header cleanup for v3.8 merge window Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-04 22:04 ` [PATCH 01/16] ARM: OMAP2+: Make board-zoom.h local Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-04 22:04 ` [PATCH 02/16] ARM: OMAP: Split plat-omap/i2c.c into mach-omap1 and mach-omap2 Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-05 8:53 ` Shubhrajyoti
2012-10-05 8:53 ` Shubhrajyoti
2012-10-04 22:04 ` [PATCH 03/16] ARM: OMAP: Make plat/common.h local to " Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-04 22:04 ` [PATCH 04/16] ARM: OMAP: Make plat/fpga.h local to arch/arm/plat-omap Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-04 22:04 ` [PATCH 05/16] ARM: OMAP1: Move plat/tc.h to mach/tc.h for omap1 Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-04 22:04 ` [PATCH 06/16] ARM: OMAP: Move plat/led.h to include/linux/platform_data Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-04 22:04 ` [PATCH 07/16] ARM: OMAP: Make plat/sram.h local to plat-omap Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-05 13:58 ` Jon Hunter
2012-10-05 13:58 ` Jon Hunter
2012-10-08 16:31 ` Tony Lindgren [this message]
2012-10-08 16:31 ` Tony Lindgren
2012-10-04 22:04 ` [PATCH 08/16] ARM: OMAP2: Move plat/menelaus.h to linux/mfd/menelaus.h Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-16 0:11 ` Tony Lindgren
2012-10-16 0:11 ` Tony Lindgren
2012-10-25 11:11 ` Samuel Ortiz
2012-10-25 11:11 ` Samuel Ortiz
2012-10-25 19:03 ` Tony Lindgren
2012-10-25 19:03 ` Tony Lindgren
2012-10-04 22:04 ` [PATCH 09/16] ARM: OMAP: Split plat/mmc.h into local headers and platform_data Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-05 6:38 ` Venkatraman S
2012-10-05 6:38 ` Venkatraman S
2012-10-05 18:09 ` Tony Lindgren
2012-10-05 18:09 ` Tony Lindgren
2012-10-05 18:08 ` [PATCH 09.5/16] mmc: omap: Remove cpu_is_omap usage from the driver Tony Lindgren
2012-10-05 18:08 ` Tony Lindgren
2012-10-05 18:23 ` Chris Ball
2012-10-05 18:23 ` Chris Ball
2012-10-05 19:47 ` Tony Lindgren
2012-10-05 19:47 ` Tony Lindgren
2012-10-16 21:02 ` Tony Lindgren
2012-10-16 21:02 ` Tony Lindgren
2012-10-04 22:04 ` [PATCH 10/16] ARM: OMAP: Make omap_device local to mach-omap2 Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-26 1:27 ` Paul Walmsley
2012-10-26 1:27 ` Paul Walmsley
2012-10-26 16:39 ` Tony Lindgren
2012-10-26 16:39 ` Tony Lindgren
2012-10-26 17:02 ` Paul Walmsley
2012-10-26 17:02 ` Paul Walmsley
2012-10-26 17:10 ` Tony Lindgren
2012-10-26 17:10 ` Tony Lindgren
2012-10-26 20:18 ` Paul Walmsley
2012-10-26 20:18 ` Paul Walmsley
2012-10-26 20:37 ` Tony Lindgren
2012-10-26 20:37 ` Tony Lindgren
2012-10-26 20:45 ` Paul Walmsley
2012-10-26 20:45 ` Paul Walmsley
2012-10-04 22:04 ` [PATCH 11/16] ARM: OMAP: Make plat/omap_hwmod.h " Tony Lindgren
2012-10-04 22:04 ` Tony Lindgren
2012-10-04 22:05 ` [PATCH 12/16] ARM: OMAP: Merge plat/multi.h into plat/cpu.h Tony Lindgren
2012-10-04 22:05 ` Tony Lindgren
2012-10-04 22:05 ` [PATCH 13/16] ARM: OMAP: Split uncompress.h to mach-omap1 and mach-omap2 Tony Lindgren
2012-10-04 22:05 ` Tony Lindgren
2012-10-04 22:05 ` [PATCH 14/16] ARM: OMAP: Split plat/serial.h for omap1 and omap2+ Tony Lindgren
2012-10-04 22:05 ` Tony Lindgren
2012-10-04 22:05 ` [PATCH 15/16] ARM: OMAP: Move plat/omap-serial.h to linux/platform_data/serial-omap.h Tony Lindgren
2012-10-04 22:05 ` Tony Lindgren
2012-10-04 22:05 ` [PATCH 16/16] ARM: OMAP: Make plat/omap-pm.h local to mach-omap2 Tony Lindgren
2012-10-04 22:05 ` Tony Lindgren
2012-10-04 22:26 ` Laurent Pinchart
2012-10-04 22:26 ` Laurent Pinchart
2012-10-08 8:52 ` [PATCH 00/16] More omap plat header cleanup for v3.8 merge window Santosh Shilimkar
2012-10-08 8:52 ` Santosh Shilimkar
2012-10-08 9:24 ` Santosh Shilimkar
2012-10-08 9:24 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008163136.GE3874@atomide.com \
--to=tony@atomide.com \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.