Re: [PATCH 3/3] ARM: OMAP: Remove plat-omap/common.c

From: Tony Lindgren <tony@atomide.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: OMAP: Remove plat-omap/common.c
Date: Fri, 2 Nov 2012 08:49:02 -0700	[thread overview]
Message-ID: <20121102154901.GU15766@atomide.com> (raw)
In-Reply-To: <50938A69.9040908@ti.com>

* Santosh Shilimkar <santosh.shilimkar@ti.com> [121102 01:56]:
> On Friday 02 November 2012 02:19 PM, Tomi Valkeinen wrote:
> >On 2012-11-02 08:38, Santosh Shilimkar wrote:
> >>
> >>Lets not move this in DMA code since the above is really related
> >>to frame buffer. It reserves more DMA area for dma_alloc_coherent()
> >>etc than default 2 MB. Infact, we should no longer need this with
> >>CMA and memblock in place.
> >>
> >>Tomi,
> >>Can we not get rid of the above memory reservation ?
> >
> >Yes, I think so. This one is only used for the old omapfb, i.e. omap1,
> >and I have no means to test it out, though. But below is a patch to
> >remove it. I also attached the patch, as it looks like thunderbird wants
> >to reformat the pasted patch... I'll remove the
> >CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE from the omapfb driver's Kconfig file
> >in my tree later.
> >
> Great !!
> Thanks for the patches Tomi.
> 
> For both the patches, feel free add.
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

Great thanks, will swap in Tomi's patch.

Regards,

Tony 