From: Santosh Shilimkar <santosh.shilimkar@ti.com> To: Tony Lindgren <tony@atomide.com>, Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 3/3] ARM: OMAP: Remove plat-omap/common.c Date: Fri, 2 Nov 2012 12:07:43 +0530 [thread overview] Message-ID: <50936A37.3070403@ti.com> (raw) In-Reply-To: <20121101224828.2103.82950.stgit@muffinssi.local> Tony, On Friday 02 November 2012 04:18 AM, Tony Lindgren wrote: > This file has only omap_init_consistent_dma_size() > left that can be moved to plat-omap/dma.c. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > arch/arm/plat-omap/Makefile | 2 +- > arch/arm/plat-omap/common.c | 26 -------------------------- > arch/arm/plat-omap/dma.c | 8 ++++++++ > 3 files changed, 9 insertions(+), 27 deletions(-) > delete mode 100644 arch/arm/plat-omap/common.c > [..] > diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c > index c288b76..00a3a53 100644 > --- a/arch/arm/plat-omap/dma.c > +++ b/arch/arm/plat-omap/dma.c > @@ -2146,6 +2146,14 @@ static struct platform_driver omap_system_dma_driver = { > }, > }; > > +/* This must be called from init_early() */ > +void __init omap_init_consistent_dma_size(void) > +{ > +#ifdef CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE > + init_consistent_dma_size(CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE << 20); > +#endif > +} > + Lets not move this in DMA code since the above is really related to frame buffer. It reserves more DMA area for dma_alloc_coherent() etc than default 2 MB. Infact, we should no longer need this with CMA and memblock in place. Tomi, Can we not get rid of the above memory reservation ? Regards santosh
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] ARM: OMAP: Remove plat-omap/common.c Date: Fri, 2 Nov 2012 12:07:43 +0530 [thread overview] Message-ID: <50936A37.3070403@ti.com> (raw) In-Reply-To: <20121101224828.2103.82950.stgit@muffinssi.local> Tony, On Friday 02 November 2012 04:18 AM, Tony Lindgren wrote: > This file has only omap_init_consistent_dma_size() > left that can be moved to plat-omap/dma.c. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > arch/arm/plat-omap/Makefile | 2 +- > arch/arm/plat-omap/common.c | 26 -------------------------- > arch/arm/plat-omap/dma.c | 8 ++++++++ > 3 files changed, 9 insertions(+), 27 deletions(-) > delete mode 100644 arch/arm/plat-omap/common.c > [..] > diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c > index c288b76..00a3a53 100644 > --- a/arch/arm/plat-omap/dma.c > +++ b/arch/arm/plat-omap/dma.c > @@ -2146,6 +2146,14 @@ static struct platform_driver omap_system_dma_driver = { > }, > }; > > +/* This must be called from init_early() */ > +void __init omap_init_consistent_dma_size(void) > +{ > +#ifdef CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE > + init_consistent_dma_size(CONFIG_FB_OMAP_CONSISTENT_DMA_SIZE << 20); > +#endif > +} > + Lets not move this in DMA code since the above is really related to frame buffer. It reserves more DMA area for dma_alloc_coherent() etc than default 2 MB. Infact, we should no longer need this with CMA and memblock in place. Tomi, Can we not get rid of the above memory reservation ? Regards santosh
next prev parent reply other threads:[~2012-11-02 6:38 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-11-01 22:48 [PATCH 0/3] more omap clean-up for ARCH_MULTIPLATFORM Tony Lindgren 2012-11-01 22:48 ` Tony Lindgren 2012-11-01 22:48 ` [PATCH 1/3] ARM: OMAP: Remove unnecessary mach and plat includes Tony Lindgren 2012-11-01 22:48 ` Tony Lindgren 2012-11-01 22:48 ` [PATCH 2/3] ARM: OMAP: Remove NEED_MACH_GPIO_H Tony Lindgren 2012-11-01 22:48 ` Tony Lindgren 2012-11-02 14:25 ` Mark Brown 2012-11-02 14:25 ` Mark Brown 2012-11-01 22:48 ` [PATCH 3/3] ARM: OMAP: Remove plat-omap/common.c Tony Lindgren 2012-11-01 22:48 ` Tony Lindgren 2012-11-01 23:14 ` Tony Lindgren 2012-11-01 23:14 ` Tony Lindgren 2012-11-02 6:37 ` Santosh Shilimkar [this message] 2012-11-02 6:37 ` Santosh Shilimkar 2012-11-02 6:38 ` Santosh Shilimkar 2012-11-02 6:38 ` Santosh Shilimkar 2012-11-02 8:49 ` Tomi Valkeinen 2012-11-02 8:49 ` Tomi Valkeinen 2012-11-02 8:55 ` Santosh Shilimkar 2012-11-02 8:55 ` Santosh Shilimkar 2012-11-02 15:49 ` Tony Lindgren 2012-11-02 15:49 ` Tony Lindgren 2012-11-02 18:54 ` Tony Lindgren 2012-11-02 18:54 ` Tony Lindgren 2012-11-05 8:04 ` Tomi Valkeinen 2012-11-05 8:04 ` Tomi Valkeinen 2012-11-05 15:36 ` Tony Lindgren 2012-11-05 15:36 ` Tony Lindgren 2012-11-05 15:48 ` Tomi Valkeinen 2012-11-05 15:48 ` Tomi Valkeinen 2012-11-05 16:12 ` Tony Lindgren 2012-11-05 16:12 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=50936A37.3070403@ti.com \ --to=santosh.shilimkar@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=tomi.valkeinen@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.