From: Takao Indoh <indou.takao@jp.fujitsu.com> To: linux-pci@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: tokunaga.keiich@jp.fujitsu.com, kexec@lists.infradead.org, hbabu@us.ibm.com, andi@firstfloor.org, ddutile@redhat.com, Takao Indoh <indou.takao@jp.fujitsu.com>, ishii.hironobu@jp.fujitsu.com, hpa@zytor.com, bhelgaas@google.com, tglx@linutronix.de, yinghai@kernel.org, mingo@redhat.com, vgoyal@redhat.com, khalid@gonehiking.org Subject: [PATCH v7 5/5] x86, pci: Enable PCI INTx when MSI is disabled Date: Tue, 27 Nov 2012 09:43:21 +0900 (JST) [thread overview] Message-ID: <20121127004233.3604.33429.sendpatchset@tindoh.g01.fujitsu.local> (raw) In-Reply-To: <20121127004144.3604.61708.sendpatchset@tindoh.g01.fujitsu.local> This patch enables INTx if MSI is disabled in pcibios_enable_device(). In normal case interrupt disable bit in command register is 0b on boot time, but in case of kdump, this bit may be 1b. It causes problems of some drivers. At leaset I confirmed mptsas driver does not work in such a case. This patch fix this problem. Signed-off-by: Takao Indoh <indou.takao@jp.fujitsu.com> --- arch/x86/pci/common.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index 720e973..2bb7ecc 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86/pci/common.c @@ -615,8 +615,10 @@ int pcibios_enable_device(struct pci_dev *dev, int mask) if ((err = pci_enable_resources(dev, mask)) < 0) return err; - if (!pci_dev_msi_enabled(dev)) + if (!pci_dev_msi_enabled(dev)) { + pci_intx(dev, true); return pcibios_enable_irq(dev); + } return 0; } -- 1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Takao Indoh <indou.takao@jp.fujitsu.com> To: linux-pci@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Takao Indoh <indou.takao@jp.fujitsu.com>, tokunaga.keiich@jp.fujitsu.com, kexec@lists.infradead.org, hbabu@us.ibm.com, andi@firstfloor.org, ddutile@redhat.com, ishii.hironobu@jp.fujitsu.com, hpa@zytor.com, bhelgaas@google.com, tglx@linutronix.de, yinghai@kernel.org, mingo@redhat.com, vgoyal@redhat.com, khalid@gonehiking.org Subject: [PATCH v7 5/5] x86, pci: Enable PCI INTx when MSI is disabled Date: Tue, 27 Nov 2012 09:43:21 +0900 (JST) [thread overview] Message-ID: <20121127004233.3604.33429.sendpatchset@tindoh.g01.fujitsu.local> (raw) In-Reply-To: <20121127004144.3604.61708.sendpatchset@tindoh.g01.fujitsu.local> This patch enables INTx if MSI is disabled in pcibios_enable_device(). In normal case interrupt disable bit in command register is 0b on boot time, but in case of kdump, this bit may be 1b. It causes problems of some drivers. At leaset I confirmed mptsas driver does not work in such a case. This patch fix this problem. Signed-off-by: Takao Indoh <indou.takao@jp.fujitsu.com> --- arch/x86/pci/common.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index 720e973..2bb7ecc 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86/pci/common.c @@ -615,8 +615,10 @@ int pcibios_enable_device(struct pci_dev *dev, int mask) if ((err = pci_enable_resources(dev, mask)) < 0) return err; - if (!pci_dev_msi_enabled(dev)) + if (!pci_dev_msi_enabled(dev)) { + pci_intx(dev, true); return pcibios_enable_irq(dev); + } return 0; } -- 1.7.1 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2012-11-27 0:43 UTC|newest] Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-11-27 0:42 [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu Takao Indoh 2012-11-27 0:42 ` Takao Indoh 2012-11-27 0:42 ` [PATCH v7 1/5] x86, pci: add dummy pci device for early stage Takao Indoh 2012-11-27 0:42 ` Takao Indoh 2012-11-27 0:42 ` [PATCH v7 2/5] PCI: Define the maximum number of PCI function Takao Indoh 2012-11-27 0:42 ` Takao Indoh 2012-11-27 0:42 ` [PATCH v7 3/5] Make reset_devices available at early stage Takao Indoh 2012-11-27 0:42 ` Takao Indoh 2012-11-27 0:43 ` [PATCH v7 4/5] x86, pci: Reset PCIe devices at boot time Takao Indoh 2012-11-27 0:43 ` Takao Indoh 2012-11-27 0:43 ` Takao Indoh [this message] 2012-11-27 0:43 ` [PATCH v7 5/5] x86, pci: Enable PCI INTx when MSI is disabled Takao Indoh 2012-11-30 15:49 ` [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu MUNEDA Takahiro 2012-11-30 15:49 ` MUNEDA Takahiro 2012-12-21 16:19 ` Yinghai Lu 2012-12-21 16:19 ` Yinghai Lu 2013-01-07 19:09 ` Thomas Renninger 2013-01-07 19:09 ` Thomas Renninger 2013-01-07 20:16 ` Yinghai Lu 2013-01-07 20:16 ` Yinghai Lu 2013-01-08 0:42 ` Thomas Renninger 2013-01-08 0:42 ` Thomas Renninger 2013-01-08 3:04 ` Yinghai Lu 2013-01-08 3:04 ` Yinghai Lu 2013-01-08 16:47 ` [PATCH] Only reset e820 once, even with multiple memmap=exactmap params Thomas Renninger 2013-01-08 16:47 ` Thomas Renninger 2013-01-08 17:19 ` Yinghai Lu 2013-01-08 17:19 ` Yinghai Lu 2013-01-10 3:21 ` Thomas Renninger 2013-01-10 3:21 ` Thomas Renninger 2013-01-10 14:26 ` Vivek Goyal 2013-01-10 14:26 ` Vivek Goyal 2013-01-10 16:53 ` Yinghai Lu 2013-01-10 16:53 ` Yinghai Lu 2013-01-10 17:01 ` Vivek Goyal 2013-01-10 17:01 ` Vivek Goyal 2013-01-10 17:11 ` Yinghai Lu 2013-01-10 17:11 ` Yinghai Lu 2013-01-10 23:34 ` Yinghai Lu 2013-01-11 12:33 ` [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case Thomas Renninger 2013-01-11 12:33 ` Thomas Renninger 2013-01-11 16:16 ` Yinghai Lu 2013-01-11 16:16 ` Yinghai Lu 2013-01-11 18:24 ` Thomas Renninger 2013-01-11 18:24 ` Thomas Renninger 2013-01-11 19:59 ` Yinghai Lu 2013-01-11 19:59 ` Yinghai Lu 2013-01-11 20:06 ` H. Peter Anvin 2013-01-11 20:06 ` H. Peter Anvin 2013-01-11 21:09 ` Yinghai Lu 2013-01-11 21:09 ` Yinghai Lu 2013-01-11 22:16 ` H. Peter Anvin 2013-01-11 22:16 ` H. Peter Anvin 2013-01-12 11:31 ` Thomas Renninger 2013-01-12 11:31 ` Thomas Renninger 2013-01-12 17:07 ` Yinghai Lu 2013-01-12 17:07 ` Yinghai Lu 2013-01-14 2:08 ` Thomas Renninger 2013-01-14 2:08 ` Thomas Renninger 2013-01-14 2:43 ` Yinghai Lu 2013-01-14 2:43 ` Yinghai Lu 2013-01-14 15:05 ` Thomas Renninger 2013-01-14 15:05 ` Thomas Renninger 2013-01-14 19:04 ` Yinghai Lu 2013-01-14 19:04 ` Yinghai Lu 2013-01-15 0:54 ` Thomas Renninger 2013-01-15 0:54 ` Thomas Renninger 2013-01-15 4:45 ` Yinghai Lu 2013-01-15 4:45 ` Yinghai Lu 2013-01-22 15:21 ` Thomas Renninger 2013-01-22 15:21 ` Thomas Renninger 2013-01-08 16:50 ` [PATCH v7 0/5] Reset PCIe devices to address DMA problem on kdump with iommu Thomas Renninger 2013-01-08 16:50 ` Thomas Renninger 2013-01-08 17:27 ` Yinghai Lu 2013-01-08 17:27 ` Yinghai Lu 2013-01-09 2:32 ` Thomas Renninger 2013-01-09 2:32 ` Thomas Renninger 2013-01-09 4:39 ` Takao Indoh 2013-01-09 4:39 ` Takao Indoh 2013-01-21 1:11 ` Takao Indoh 2013-01-21 1:11 ` Takao Indoh 2013-01-23 0:47 ` Thomas Renninger 2013-01-23 0:47 ` Thomas Renninger 2013-01-24 0:23 ` Takao Indoh 2013-01-24 0:23 ` Takao Indoh 2013-01-29 1:14 ` Thomas Renninger 2013-01-29 1:14 ` Thomas Renninger 2013-01-30 5:01 ` Takao Indoh 2013-01-30 5:01 ` Takao Indoh 2013-03-04 0:56 ` Takao Indoh 2013-03-04 0:56 ` Takao Indoh 2013-03-04 22:00 ` Don Dutile 2013-03-04 22:00 ` Don Dutile 2013-03-05 0:56 ` Takao Indoh 2013-03-05 0:56 ` Takao Indoh 2012-12-21 9:59 ` oliver yang 2012-12-21 10:37 ` Takao Indoh 2012-12-21 10:37 ` Takao Indoh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20121127004233.3604.33429.sendpatchset@tindoh.g01.fujitsu.local \ --to=indou.takao@jp.fujitsu.com \ --cc=andi@firstfloor.org \ --cc=bhelgaas@google.com \ --cc=ddutile@redhat.com \ --cc=hbabu@us.ibm.com \ --cc=hpa@zytor.com \ --cc=ishii.hironobu@jp.fujitsu.com \ --cc=kexec@lists.infradead.org \ --cc=khalid@gonehiking.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=tglx@linutronix.de \ --cc=tokunaga.keiich@jp.fujitsu.com \ --cc=vgoyal@redhat.com \ --cc=x86@kernel.org \ --cc=yinghai@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.