From: Kim Phillips <kim.phillips@freescale.com> To: Russell King <linux@arm.linux.org.uk>, Andrew Morton <akpm@linux-foundation.org> Cc: Daniel Santos <daniel.santos@pobox.com>, Borislav Petkov <bp@alien8.de>, David Rientjes <rientjes@google.com>, Rusty Russell <rusty@rustcorp.com.au>, David Woodhouse <David.Woodhouse@intel.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: [RFC] arm: use built-in byte swap function Date: Mon, 28 Jan 2013 19:30:33 -0600 [thread overview] Message-ID: <20130128193033.8a0b0a871150c99247f05a95@freescale.com> (raw) Enable the compiler intrinsic for byte swapping on arch ARM. This allows the compiler to detect and be able to optimize out byte swappings, e.g. in big endian to big endian moves. AFAICT, arm gcc got __builtin_bswap{32,64} support in 4.6, and for the 16-bit version in 4.8. Signed-off-by: Kim Phillips <kim.phillips@freescale.com> --- akin to: http://comments.gmane.org/gmane.linux.kernel.cross-arch/16016 based on linux-next. Depends on commit "compiler-gcc{3,4}.h: Use GCC_VERSION macro" by Daniel Santos <daniel.santos@pobox.com>, currently in the akpm branch. RFC because of unfamiliarity with arch ARM, and that at91sam9rl, at91rm9200, and lpd270 (so far, at least) builds fail with: include/uapi/linux/swab.h:60: undefined reference to `__bswapsi2' I'm using eldk-5.2.1/armv7a's arm-linux-gnueabi-gcc (GCC) 4.6.4 20120303 (prerelease) arch/arm/Kconfig | 1 + include/linux/compiler-gcc4.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index eda8711..437d11a 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -3,6 +3,7 @@ config ARM default y select ARCH_BINFMT_ELF_RANDOMIZE_PIE select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE + select ARCH_USE_BUILTIN_BSWAP select ARCH_HAVE_CUSTOM_GPIO_H select ARCH_WANT_IPC_PARSE_VERSION select BUILDTIME_EXTABLE_SORT if MMU diff --git a/include/linux/compiler-gcc4.h b/include/linux/compiler-gcc4.h index 68b162d..da5f728 100644 --- a/include/linux/compiler-gcc4.h +++ b/include/linux/compiler-gcc4.h @@ -67,7 +67,8 @@ #ifdef CONFIG_ARCH_USE_BUILTIN_BSWAP -#if GCC_VERSION >= 40400 +#if (!defined(__arm__) && GCC_VERSION >= 40400) || \ + (defined(__arm__) && GCC_VERSION >= 40600) #define __HAVE_BUILTIN_BSWAP32__ #define __HAVE_BUILTIN_BSWAP64__ #endif -- 1.7.9.7
WARNING: multiple messages have this Message-ID (diff)
From: kim.phillips@freescale.com (Kim Phillips) To: linux-arm-kernel@lists.infradead.org Subject: [RFC] arm: use built-in byte swap function Date: Mon, 28 Jan 2013 19:30:33 -0600 [thread overview] Message-ID: <20130128193033.8a0b0a871150c99247f05a95@freescale.com> (raw) Enable the compiler intrinsic for byte swapping on arch ARM. This allows the compiler to detect and be able to optimize out byte swappings, e.g. in big endian to big endian moves. AFAICT, arm gcc got __builtin_bswap{32,64} support in 4.6, and for the 16-bit version in 4.8. Signed-off-by: Kim Phillips <kim.phillips@freescale.com> --- akin to: http://comments.gmane.org/gmane.linux.kernel.cross-arch/16016 based on linux-next. Depends on commit "compiler-gcc{3,4}.h: Use GCC_VERSION macro" by Daniel Santos <daniel.santos@pobox.com>, currently in the akpm branch. RFC because of unfamiliarity with arch ARM, and that at91sam9rl, at91rm9200, and lpd270 (so far, at least) builds fail with: include/uapi/linux/swab.h:60: undefined reference to `__bswapsi2' I'm using eldk-5.2.1/armv7a's arm-linux-gnueabi-gcc (GCC) 4.6.4 20120303 (prerelease) arch/arm/Kconfig | 1 + include/linux/compiler-gcc4.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index eda8711..437d11a 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -3,6 +3,7 @@ config ARM default y select ARCH_BINFMT_ELF_RANDOMIZE_PIE select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE + select ARCH_USE_BUILTIN_BSWAP select ARCH_HAVE_CUSTOM_GPIO_H select ARCH_WANT_IPC_PARSE_VERSION select BUILDTIME_EXTABLE_SORT if MMU diff --git a/include/linux/compiler-gcc4.h b/include/linux/compiler-gcc4.h index 68b162d..da5f728 100644 --- a/include/linux/compiler-gcc4.h +++ b/include/linux/compiler-gcc4.h @@ -67,7 +67,8 @@ #ifdef CONFIG_ARCH_USE_BUILTIN_BSWAP -#if GCC_VERSION >= 40400 +#if (!defined(__arm__) && GCC_VERSION >= 40400) || \ + (defined(__arm__) && GCC_VERSION >= 40600) #define __HAVE_BUILTIN_BSWAP32__ #define __HAVE_BUILTIN_BSWAP64__ #endif -- 1.7.9.7
next reply other threads:[~2013-01-29 1:33 UTC|newest] Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-29 1:30 Kim Phillips [this message] 2013-01-29 1:30 ` [RFC] arm: use built-in byte swap function Kim Phillips 2013-01-29 8:35 ` Borislav Petkov 2013-01-29 8:35 ` Borislav Petkov 2013-01-29 16:46 ` Woodhouse, David 2013-01-29 16:46 ` Woodhouse, David 2013-01-29 17:42 ` Borislav Petkov 2013-01-29 17:42 ` Borislav Petkov 2013-01-29 17:55 ` Woodhouse, David 2013-01-29 17:55 ` Woodhouse, David 2013-01-29 18:10 ` Borislav Petkov 2013-01-29 18:10 ` Borislav Petkov 2013-01-30 10:22 ` Woodhouse, David 2013-01-30 10:22 ` Woodhouse, David 2013-01-31 2:09 ` Kim Phillips 2013-01-31 2:09 ` Kim Phillips 2013-01-31 6:44 ` Borislav Petkov 2013-01-31 6:44 ` Borislav Petkov 2013-01-31 9:28 ` Russell King - ARM Linux 2013-01-31 9:28 ` Russell King - ARM Linux 2013-01-31 20:59 ` Kim Phillips 2013-01-31 20:59 ` Kim Phillips 2013-01-31 21:33 ` Borislav Petkov 2013-01-31 21:33 ` Borislav Petkov 2013-01-31 22:11 ` Woodhouse, David 2013-01-31 22:11 ` Woodhouse, David 2013-02-01 0:37 ` [PATCH v4] " Kim Phillips 2013-02-01 0:37 ` Kim Phillips 2013-02-01 10:46 ` Russell King - ARM Linux 2013-02-01 10:46 ` Russell King - ARM Linux 2013-02-01 1:17 ` [RFC] " Russell King - ARM Linux 2013-02-01 1:17 ` Russell King - ARM Linux 2013-02-01 7:33 ` Woodhouse, David 2013-02-01 7:33 ` Woodhouse, David 2013-02-06 3:04 ` Kim Phillips 2013-02-06 3:04 ` Kim Phillips 2013-02-06 9:02 ` Woodhouse, David 2013-02-06 9:02 ` Woodhouse, David 2013-02-07 1:19 ` Kim Phillips 2013-02-07 1:19 ` Kim Phillips 2013-02-07 10:19 ` Will Newton 2013-02-07 10:19 ` Will Newton 2013-02-07 10:43 ` Catalin Marinas 2013-02-07 10:43 ` Catalin Marinas 2013-02-07 18:13 ` Russell King - ARM Linux 2013-02-07 18:13 ` Russell King - ARM Linux 2013-02-08 17:25 ` Woodhouse, David 2013-02-08 17:25 ` Woodhouse, David 2013-02-08 20:04 ` Nicolas Pitre 2013-02-08 20:04 ` Nicolas Pitre 2013-02-08 22:40 ` Woodhouse, David 2013-02-08 22:40 ` Woodhouse, David 2013-02-08 22:47 ` Nicolas Pitre 2013-02-08 22:47 ` Nicolas Pitre 2013-02-09 1:12 ` Kim Phillips 2013-02-09 1:12 ` Kim Phillips 2013-02-09 3:16 ` Nicolas Pitre 2013-02-09 3:16 ` Nicolas Pitre 2013-02-20 2:31 ` Kim Phillips 2013-02-20 2:31 ` Kim Phillips 2013-02-20 2:38 ` Stephen Boyd 2013-02-20 2:38 ` Stephen Boyd 2013-02-20 3:17 ` Nicolas Pitre 2013-02-20 3:17 ` Nicolas Pitre 2013-02-20 10:38 ` Woodhouse, David 2013-02-20 10:38 ` Woodhouse, David 2013-02-20 13:36 ` Nicolas Pitre 2013-02-20 13:36 ` Nicolas Pitre 2013-02-20 13:44 ` Woodhouse, David 2013-02-20 13:44 ` Woodhouse, David 2013-02-20 14:06 ` Nicolas Pitre 2013-02-20 14:06 ` Nicolas Pitre 2013-02-20 14:53 ` Woodhouse, David 2013-02-20 14:53 ` Woodhouse, David 2013-02-20 15:43 ` Nicolas Pitre 2013-02-20 15:43 ` Nicolas Pitre 2013-02-21 3:49 ` Kim Phillips 2013-02-21 3:49 ` Kim Phillips 2013-02-21 4:29 ` Nicolas Pitre 2013-02-21 4:29 ` Nicolas Pitre 2013-02-21 6:52 ` Kim Phillips 2013-02-21 6:52 ` Kim Phillips 2013-02-21 16:40 ` Nicolas Pitre 2013-02-21 16:40 ` Nicolas Pitre 2013-02-22 2:33 ` Kim Phillips 2013-02-22 2:33 ` Kim Phillips 2013-02-22 3:40 ` Nicolas Pitre 2013-02-22 3:40 ` Nicolas Pitre 2013-02-23 1:40 ` [PATCH v6] " Kim Phillips 2013-02-23 1:40 ` Kim Phillips 2013-02-23 2:40 ` Nicolas Pitre 2013-02-23 2:40 ` Nicolas Pitre 2013-02-23 23:20 ` Woodhouse, David 2013-02-23 23:20 ` Woodhouse, David 2013-05-23 16:46 ` [PATCH v7] " Kim Phillips 2013-05-23 16:46 ` Kim Phillips 2013-05-23 20:09 ` Nicolas Pitre 2013-05-23 20:09 ` Nicolas Pitre 2013-05-23 23:13 ` Russell King - ARM Linux 2013-05-23 23:13 ` Russell King - ARM Linux 2013-06-06 22:12 ` Russell King - ARM Linux 2013-06-06 22:12 ` Russell King - ARM Linux 2013-06-06 22:23 ` Borislav Petkov 2013-06-06 22:23 ` Borislav Petkov 2013-06-07 0:03 ` Stephen Rothwell 2013-06-07 0:03 ` Stephen Rothwell 2013-05-26 5:38 ` Dirk Behme 2013-05-26 9:30 ` Woodhouse, David 2013-10-27 2:41 ` Nicolas Pitre 2013-10-27 2:41 ` Nicolas Pitre 2013-11-05 21:45 ` Kim Phillips 2013-11-05 21:45 ` Kim Phillips 2013-02-21 16:37 ` [RFC] " Woodhouse, David 2013-02-21 16:37 ` Woodhouse, David 2013-02-21 17:27 ` Nicolas Pitre 2013-02-21 17:27 ` Nicolas Pitre 2013-03-13 13:35 ` Woodhouse, David 2013-03-13 13:35 ` Woodhouse, David 2013-01-29 14:13 ` Russell King - ARM Linux 2013-01-29 14:13 ` Russell King - ARM Linux 2013-01-29 14:43 ` Woodhouse, David 2013-01-29 14:43 ` Woodhouse, David 2013-01-29 14:53 ` Rob Herring 2013-01-29 14:53 ` Rob Herring 2013-01-29 15:10 ` Woodhouse, David 2013-01-29 15:10 ` Woodhouse, David 2013-01-31 11:44 Woodhouse, David
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130128193033.8a0b0a871150c99247f05a95@freescale.com \ --to=kim.phillips@freescale.com \ --cc=David.Woodhouse@intel.com \ --cc=akpm@linux-foundation.org \ --cc=bp@alien8.de \ --cc=daniel.santos@pobox.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=rientjes@google.com \ --cc=rusty@rustcorp.com.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.