From: Florian Fainelli <florian@openwrt.org>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: davem@davemloft.net,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Andrew Lunn <andrew@lunn.ch>,
Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
linux-doc@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
netdev@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-arm-kernel@lists.infradead.org,
Rob Landley <rob@landley.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linuxppc-dev@lists.ozlabs.org,
Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH 5/5] mv643xx_eth: convert to use the Marvell Orion MDIO driver
Date: Tue, 29 Jan 2013 21:41:03 +0100 [thread overview]
Message-ID: <201301292141.03931.florian@openwrt.org> (raw)
In-Reply-To: <20130129181306.GF25646@obsidianresearch.com>
Le mardi 29 janvier 2013 19:13:06, Jason Gunthorpe a écrit :
> On Tue, Jan 29, 2013 at 04:24:08PM +0100, Florian Fainelli wrote:
> > This patch converts the Marvell MV643XX ethernet driver to use the
> > Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms
> > registering the Marvell MV643XX ethernet driver are also updated to
> > register a Marvell Orion MDIO driver. This driver voluntarily overlaps
> > with the Marvell Ethernet shared registers because it will use a subset
> > of this shared register (shared_base + 0x4 - shared_base + 0x84). The
> > Ethernet driver is also updated to look up for a PHY device using the
> > Orion MDIO bus driver.
>
> Can you finish off this job by making the mv643xx_eth driver accept
> the standard phy-handle OF property instead of using a phy address?
I can certainly do that, at the same time we need to continue supporting the
"old" platform device style registration without breaking them (PowerPC in
particular, and the hopefully yet to be converted orion5x). So the phy_scan()
as I modified it will probably still be there.
>
> Ie the end result should be something like:
>
> smi0: mdio@72000 {
> device_type = "mdio";
> compatible = "marvell,orion-mdio";
> reg = <0x72004 0x4>;
>
> #address-cells = <1>;
> #size-cells = <0>;
> PHY1: ethernet-phy@1 {
> reg = <1>;
> device_type = "ethernet-phy";
> phy-id = <0x01410e90>;
> };
> };
>
> egiga0 {
> device_type = "network";
> compatible = "marvell,mv643xx-eth";
> reg = <0x72000 0x4000>;
> port_number = <0>;
> phy-handle = <&PHY1>;
> interrupts = <11>;
> local-mac-address = [000000000002]; /* Filled by
> boot loader */ };
>
> Regards,
> Jason
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian@openwrt.org>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Andrew Lunn <andrew@lunn.ch>,
Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Paul Mackerras <paulus@samba.org>,
Lennert Buytenhek <buytenh@wantstofly.org>,
Rob Landley <rob@landley.net>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] mv643xx_eth: convert to use the Marvell Orion MDIO driver
Date: Tue, 29 Jan 2013 21:41:03 +0100 [thread overview]
Message-ID: <201301292141.03931.florian@openwrt.org> (raw)
In-Reply-To: <20130129181306.GF25646@obsidianresearch.com>
Le mardi 29 janvier 2013 19:13:06, Jason Gunthorpe a =E9crit :
> On Tue, Jan 29, 2013 at 04:24:08PM +0100, Florian Fainelli wrote:
> > This patch converts the Marvell MV643XX ethernet driver to use the
> > Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms
> > registering the Marvell MV643XX ethernet driver are also updated to
> > register a Marvell Orion MDIO driver. This driver voluntarily overlaps
> > with the Marvell Ethernet shared registers because it will use a subset
> > of this shared register (shared_base + 0x4 - shared_base + 0x84). The
> > Ethernet driver is also updated to look up for a PHY device using the
> > Orion MDIO bus driver.
>=20
> Can you finish off this job by making the mv643xx_eth driver accept
> the standard phy-handle OF property instead of using a phy address?
I can certainly do that, at the same time we need to continue supporting th=
e=20
"old" platform device style registration without breaking them (PowerPC in=
=20
particular, and the hopefully yet to be converted orion5x). So the phy_scan=
()=20
as I modified it will probably still be there.
>=20
> Ie the end result should be something like:
>=20
> smi0: mdio@72000 {
> device_type =3D "mdio";
> compatible =3D "marvell,orion-mdio";
> reg =3D <0x72004 0x4>;
>=20
> #address-cells =3D <1>;
> #size-cells =3D <0>;
> PHY1: ethernet-phy@1 {
> reg =3D <1>;
> device_type =3D "ethernet-phy";
> phy-id =3D <0x01410e90>;
> };
> };
>=20
> egiga0 {
> device_type =3D "network";
> compatible =3D "marvell,mv643xx-eth";
> reg =3D <0x72000 0x4000>;
> port_number =3D <0>;
> phy-handle =3D <&PHY1>;
> interrupts =3D <11>;
> local-mac-address =3D [000000000002]; /* Filled =
by
> boot loader */ };
>=20
> Regards,
> Jason
=2D-=20
=46lorian
WARNING: multiple messages have this Message-ID (diff)
From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] mv643xx_eth: convert to use the Marvell Orion MDIO driver
Date: Tue, 29 Jan 2013 21:41:03 +0100 [thread overview]
Message-ID: <201301292141.03931.florian@openwrt.org> (raw)
In-Reply-To: <20130129181306.GF25646@obsidianresearch.com>
Le mardi 29 janvier 2013 19:13:06, Jason Gunthorpe a ?crit :
> On Tue, Jan 29, 2013 at 04:24:08PM +0100, Florian Fainelli wrote:
> > This patch converts the Marvell MV643XX ethernet driver to use the
> > Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms
> > registering the Marvell MV643XX ethernet driver are also updated to
> > register a Marvell Orion MDIO driver. This driver voluntarily overlaps
> > with the Marvell Ethernet shared registers because it will use a subset
> > of this shared register (shared_base + 0x4 - shared_base + 0x84). The
> > Ethernet driver is also updated to look up for a PHY device using the
> > Orion MDIO bus driver.
>
> Can you finish off this job by making the mv643xx_eth driver accept
> the standard phy-handle OF property instead of using a phy address?
I can certainly do that, at the same time we need to continue supporting the
"old" platform device style registration without breaking them (PowerPC in
particular, and the hopefully yet to be converted orion5x). So the phy_scan()
as I modified it will probably still be there.
>
> Ie the end result should be something like:
>
> smi0: mdio at 72000 {
> device_type = "mdio";
> compatible = "marvell,orion-mdio";
> reg = <0x72004 0x4>;
>
> #address-cells = <1>;
> #size-cells = <0>;
> PHY1: ethernet-phy at 1 {
> reg = <1>;
> device_type = "ethernet-phy";
> phy-id = <0x01410e90>;
> };
> };
>
> egiga0 {
> device_type = "network";
> compatible = "marvell,mv643xx-eth";
> reg = <0x72000 0x4000>;
> port_number = <0>;
> phy-handle = <&PHY1>;
> interrupts = <11>;
> local-mac-address = [000000000002]; /* Filled by
> boot loader */ };
>
> Regards,
> Jason
--
Florian
next prev parent reply other threads:[~2013-01-29 20:41 UTC|newest]
Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 15:24 [PATCH 0/5] mv643xx_eth: use mvmdio MDIO bus driver Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` [PATCH 1/5] net: mvmdio: unmap base register address at driver removal Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:32 ` Thomas Petazzoni
2013-01-29 15:32 ` Thomas Petazzoni
2013-01-29 15:32 ` Thomas Petazzoni
2013-01-29 15:35 ` Florian Fainelli
2013-01-29 15:35 ` Florian Fainelli
2013-01-29 15:35 ` Florian Fainelli
2013-01-29 15:24 ` [PATCH 2/5] net: mvmdio: rename base register cookie from smireg to regs Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:34 ` Thomas Petazzoni
2013-01-29 15:34 ` Thomas Petazzoni
2013-01-29 15:34 ` Thomas Petazzoni
2013-01-29 15:24 ` [PATCH 3/5] net: mvmdio: enhance driver to support SMI error/done interrupts Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:39 ` Thomas Petazzoni
2013-01-29 15:39 ` Thomas Petazzoni
2013-01-29 15:39 ` Thomas Petazzoni
2013-01-29 15:24 ` [PATCH 4/5] net: mvmdio: allow Device Tree and platform device to coexist Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:48 ` Thomas Petazzoni
2013-01-29 15:48 ` Thomas Petazzoni
2013-01-29 15:48 ` Thomas Petazzoni
2013-01-29 17:59 ` Jason Gunthorpe
2013-01-29 17:59 ` Jason Gunthorpe
2013-01-29 17:59 ` Jason Gunthorpe
2013-01-29 20:41 ` Florian Fainelli
2013-01-29 20:41 ` Florian Fainelli
2013-01-29 20:41 ` Florian Fainelli
2013-01-29 15:24 ` [PATCH 5/5] mv643xx_eth: convert to use the Marvell Orion MDIO driver Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 16:01 ` Thomas Petazzoni
2013-01-29 16:01 ` Thomas Petazzoni
2013-01-29 16:01 ` Thomas Petazzoni
2013-01-29 16:27 ` Florian Fainelli
2013-01-29 16:27 ` Florian Fainelli
2013-01-29 16:27 ` Florian Fainelli
2013-01-29 16:46 ` Thomas Petazzoni
2013-01-29 16:46 ` Thomas Petazzoni
2013-01-29 16:46 ` Thomas Petazzoni
2013-01-29 18:13 ` Jason Gunthorpe
2013-01-29 18:13 ` Jason Gunthorpe
2013-01-29 18:13 ` Jason Gunthorpe
2013-01-29 20:41 ` Florian Fainelli [this message]
2013-01-29 20:41 ` Florian Fainelli
2013-01-29 20:41 ` Florian Fainelli
2013-03-14 17:25 ` [PATCH 0/5] mv643xx_eth: use mvmdio MDIO bus driver Jason Cooper
2013-03-14 17:25 ` Jason Cooper
2013-03-14 17:25 ` Jason Cooper
2013-03-14 17:25 ` Jason Cooper
2013-03-14 18:09 ` Florian Fainelli
2013-03-14 18:09 ` Florian Fainelli
2013-03-14 18:09 ` Florian Fainelli
2013-03-14 18:16 ` Jason Cooper
2013-03-14 18:16 ` Jason Cooper
2013-03-14 18:16 ` Jason Cooper
2013-03-14 18:16 ` Jason Cooper
2013-03-14 18:08 ` [PATCH 0/4] " Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` [PATCH] mv643xx_eth: convert to use the Marvell Orion MDIO driver Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 19:02 ` Jason Cooper
2013-03-14 19:02 ` Jason Cooper
2013-03-14 19:02 ` Jason Cooper
2013-03-14 19:02 ` Jason Cooper
2013-03-14 19:32 ` Florian Fainelli
2013-03-14 19:32 ` Florian Fainelli
2013-03-14 19:32 ` Florian Fainelli
2013-03-14 20:36 ` Jason Cooper
2013-03-14 20:36 ` Jason Cooper
2013-03-14 20:36 ` Jason Cooper
2013-03-14 18:08 ` [PATCH 2/4 v2] net: mvmdio: rename base register cookie from smireg to regs Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` [PATCH 3/4 v2] net: mvmdio: enhance driver to support SMI error/done interrupts Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-15 18:05 ` Russell King - ARM Linux
2013-03-15 18:05 ` Russell King - ARM Linux
2013-03-15 18:05 ` Russell King - ARM Linux
2013-03-14 18:08 ` [PATCH 4/4 v2] mv643xx_eth: convert to use the Marvell Orion MDIO driver Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-15 11:07 ` Florian Fainelli
2013-03-15 11:07 ` Florian Fainelli
2013-03-15 11:07 ` Florian Fainelli
2013-03-15 11:42 ` Thomas Petazzoni
2013-03-15 11:42 ` Thomas Petazzoni
2013-03-15 11:42 ` Thomas Petazzoni
2013-03-14 18:11 ` [PATCH 1/4 v2] net: mvmdio: allow platform device style registration Florian Fainelli
2013-03-14 18:11 ` Florian Fainelli
2013-03-14 18:11 ` Florian Fainelli
2013-03-15 12:53 ` [PATCH 0/4] mv643xx_eth: use mvmdio MDIO bus driver David Miller
2013-03-15 12:53 ` David Miller
2013-03-15 12:53 ` David Miller
2013-03-15 12:51 ` Florian Fainelli
2013-03-15 12:51 ` Florian Fainelli
2013-03-15 12:51 ` Florian Fainelli
2013-03-15 12:55 ` David Miller
2013-03-15 12:55 ` David Miller
2013-03-15 12:55 ` David Miller
2013-03-15 12:55 ` David Miller
2013-03-15 12:53 ` Florian Fainelli
2013-03-15 12:53 ` Florian Fainelli
2013-03-15 12:53 ` Florian Fainelli
2013-03-15 13:05 ` David Miller
2013-03-15 13:05 ` David Miller
2013-03-15 13:05 ` David Miller
2013-03-15 13:05 ` David Miller
2013-03-15 13:03 ` Florian Fainelli
2013-03-15 13:03 ` Florian Fainelli
2013-03-15 13:03 ` Florian Fainelli
2013-03-15 13:03 ` Florian Fainelli
2013-03-22 13:39 ` [PATCH 0/4 v3] " Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` [PATCH 1/4 v3] net: mvmdio: allow platform device style registration Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` [PATCH 2/4 v3] net: mvmdio: rename base register cookie from smireg to regs Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` [PATCH 3/4 v3] net: mvmdio: enhance driver to support SMI error/done interrupts Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` [PATCH 4/4 v3] mv643xx_eth: convert to use the Marvell Orion MDIO driver Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:53 ` [PATCH 0/4 v3] mv643xx_eth: use mvmdio MDIO bus driver Thomas Petazzoni
2013-03-22 13:53 ` Thomas Petazzoni
2013-03-22 13:53 ` Thomas Petazzoni
2013-03-22 14:14 ` Jason Cooper
2013-03-22 14:14 ` Jason Cooper
2013-03-22 14:14 ` Jason Cooper
2013-03-22 14:24 ` Florian Fainelli
2013-03-22 14:24 ` Florian Fainelli
2013-03-22 14:24 ` Florian Fainelli
2013-03-22 14:29 ` Jason Cooper
2013-03-22 14:29 ` Jason Cooper
2013-03-22 14:29 ` Jason Cooper
2013-03-22 14:31 ` Florian Fainelli
2013-03-22 14:31 ` Florian Fainelli
2013-03-22 14:31 ` Florian Fainelli
2013-03-22 14:26 ` David Miller
2013-03-22 14:26 ` David Miller
2013-03-22 14:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301292141.03931.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=andrew@lunn.ch \
--cc=benh@kernel.crashing.org \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.