From: Florian Fainelli <florian@openwrt.org>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: davem@davemloft.net, Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Russell King <linux@arm.linux.org.uk>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Lennert Buytenhek <buytenh@wantstofly.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/5] net: mvmdio: unmap base register address at driver removal
Date: Tue, 29 Jan 2013 16:35:50 +0100 [thread overview]
Message-ID: <5107EC56.2000703@openwrt.org> (raw)
In-Reply-To: <20130129163242.1df2caf5@skate>
On 01/29/2013 04:32 PM, Thomas Petazzoni wrote:
> Dear Florian Fainelli,
>
> On Tue, 29 Jan 2013 16:24:04 +0100, Florian Fainelli wrote:
>> Fix the driver remove callback to unmap the base register address and
>> not leak this mapping after the driver has been removed.
>>
>> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> What about using devm_request_and_ioremap() instead, in order to get
> automatic unmap on error and in the ->remove() path?
Right now, you are using of_iomap() which eases the task of fetching the
resource and getting an ioremap cookie, which I why I kept that.
>
> But maybe it won't work because this memory range is claimed both by
> the MDIO driver and the Ethernet driver itself. In that case, you could
> use devm_ioremap().
Then we would loose the facility of of_iomap(), but fair enough, it can
be inserted as a patch in this serie.
Thanks
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian@openwrt.org>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
netdev@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-arm-kernel@lists.infradead.org,
Rob Landley <rob@landley.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net,
Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH 1/5] net: mvmdio: unmap base register address at driver removal
Date: Tue, 29 Jan 2013 16:35:50 +0100 [thread overview]
Message-ID: <5107EC56.2000703@openwrt.org> (raw)
In-Reply-To: <20130129163242.1df2caf5@skate>
On 01/29/2013 04:32 PM, Thomas Petazzoni wrote:
> Dear Florian Fainelli,
>
> On Tue, 29 Jan 2013 16:24:04 +0100, Florian Fainelli wrote:
>> Fix the driver remove callback to unmap the base register address and
>> not leak this mapping after the driver has been removed.
>>
>> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> What about using devm_request_and_ioremap() instead, in order to get
> automatic unmap on error and in the ->remove() path?
Right now, you are using of_iomap() which eases the task of fetching the
resource and getting an ioremap cookie, which I why I kept that.
>
> But maybe it won't work because this memory range is claimed both by
> the MDIO driver and the Ethernet driver itself. In that case, you could
> use devm_ioremap().
Then we would loose the facility of of_iomap(), but fair enough, it can
be inserted as a patch in this serie.
Thanks
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] net: mvmdio: unmap base register address at driver removal
Date: Tue, 29 Jan 2013 16:35:50 +0100 [thread overview]
Message-ID: <5107EC56.2000703@openwrt.org> (raw)
In-Reply-To: <20130129163242.1df2caf5@skate>
On 01/29/2013 04:32 PM, Thomas Petazzoni wrote:
> Dear Florian Fainelli,
>
> On Tue, 29 Jan 2013 16:24:04 +0100, Florian Fainelli wrote:
>> Fix the driver remove callback to unmap the base register address and
>> not leak this mapping after the driver has been removed.
>>
>> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> What about using devm_request_and_ioremap() instead, in order to get
> automatic unmap on error and in the ->remove() path?
Right now, you are using of_iomap() which eases the task of fetching the
resource and getting an ioremap cookie, which I why I kept that.
>
> But maybe it won't work because this memory range is claimed both by
> the MDIO driver and the Ethernet driver itself. In that case, you could
> use devm_ioremap().
Then we would loose the facility of of_iomap(), but fair enough, it can
be inserted as a patch in this serie.
Thanks
--
Florian
next prev parent reply other threads:[~2013-01-29 15:38 UTC|newest]
Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 15:24 [PATCH 0/5] mv643xx_eth: use mvmdio MDIO bus driver Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` [PATCH 1/5] net: mvmdio: unmap base register address at driver removal Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:32 ` Thomas Petazzoni
2013-01-29 15:32 ` Thomas Petazzoni
2013-01-29 15:32 ` Thomas Petazzoni
2013-01-29 15:35 ` Florian Fainelli [this message]
2013-01-29 15:35 ` Florian Fainelli
2013-01-29 15:35 ` Florian Fainelli
2013-01-29 15:24 ` [PATCH 2/5] net: mvmdio: rename base register cookie from smireg to regs Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:34 ` Thomas Petazzoni
2013-01-29 15:34 ` Thomas Petazzoni
2013-01-29 15:34 ` Thomas Petazzoni
2013-01-29 15:24 ` [PATCH 3/5] net: mvmdio: enhance driver to support SMI error/done interrupts Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:39 ` Thomas Petazzoni
2013-01-29 15:39 ` Thomas Petazzoni
2013-01-29 15:39 ` Thomas Petazzoni
2013-01-29 15:24 ` [PATCH 4/5] net: mvmdio: allow Device Tree and platform device to coexist Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:48 ` Thomas Petazzoni
2013-01-29 15:48 ` Thomas Petazzoni
2013-01-29 15:48 ` Thomas Petazzoni
2013-01-29 17:59 ` Jason Gunthorpe
2013-01-29 17:59 ` Jason Gunthorpe
2013-01-29 17:59 ` Jason Gunthorpe
2013-01-29 20:41 ` Florian Fainelli
2013-01-29 20:41 ` Florian Fainelli
2013-01-29 20:41 ` Florian Fainelli
2013-01-29 15:24 ` [PATCH 5/5] mv643xx_eth: convert to use the Marvell Orion MDIO driver Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 15:24 ` Florian Fainelli
2013-01-29 16:01 ` Thomas Petazzoni
2013-01-29 16:01 ` Thomas Petazzoni
2013-01-29 16:01 ` Thomas Petazzoni
2013-01-29 16:27 ` Florian Fainelli
2013-01-29 16:27 ` Florian Fainelli
2013-01-29 16:27 ` Florian Fainelli
2013-01-29 16:46 ` Thomas Petazzoni
2013-01-29 16:46 ` Thomas Petazzoni
2013-01-29 16:46 ` Thomas Petazzoni
2013-01-29 18:13 ` Jason Gunthorpe
2013-01-29 18:13 ` Jason Gunthorpe
2013-01-29 18:13 ` Jason Gunthorpe
2013-01-29 20:41 ` Florian Fainelli
2013-01-29 20:41 ` Florian Fainelli
2013-01-29 20:41 ` Florian Fainelli
2013-03-14 17:25 ` [PATCH 0/5] mv643xx_eth: use mvmdio MDIO bus driver Jason Cooper
2013-03-14 17:25 ` Jason Cooper
2013-03-14 17:25 ` Jason Cooper
2013-03-14 17:25 ` Jason Cooper
2013-03-14 18:09 ` Florian Fainelli
2013-03-14 18:09 ` Florian Fainelli
2013-03-14 18:09 ` Florian Fainelli
2013-03-14 18:16 ` Jason Cooper
2013-03-14 18:16 ` Jason Cooper
2013-03-14 18:16 ` Jason Cooper
2013-03-14 18:16 ` Jason Cooper
2013-03-14 18:08 ` [PATCH 0/4] " Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` [PATCH] mv643xx_eth: convert to use the Marvell Orion MDIO driver Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 19:02 ` Jason Cooper
2013-03-14 19:02 ` Jason Cooper
2013-03-14 19:02 ` Jason Cooper
2013-03-14 19:02 ` Jason Cooper
2013-03-14 19:32 ` Florian Fainelli
2013-03-14 19:32 ` Florian Fainelli
2013-03-14 19:32 ` Florian Fainelli
2013-03-14 20:36 ` Jason Cooper
2013-03-14 20:36 ` Jason Cooper
2013-03-14 20:36 ` Jason Cooper
2013-03-14 18:08 ` [PATCH 2/4 v2] net: mvmdio: rename base register cookie from smireg to regs Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` [PATCH 3/4 v2] net: mvmdio: enhance driver to support SMI error/done interrupts Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-15 18:05 ` Russell King - ARM Linux
2013-03-15 18:05 ` Russell King - ARM Linux
2013-03-15 18:05 ` Russell King - ARM Linux
2013-03-14 18:08 ` [PATCH 4/4 v2] mv643xx_eth: convert to use the Marvell Orion MDIO driver Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-14 18:08 ` Florian Fainelli
2013-03-15 11:07 ` Florian Fainelli
2013-03-15 11:07 ` Florian Fainelli
2013-03-15 11:07 ` Florian Fainelli
2013-03-15 11:42 ` Thomas Petazzoni
2013-03-15 11:42 ` Thomas Petazzoni
2013-03-15 11:42 ` Thomas Petazzoni
2013-03-14 18:11 ` [PATCH 1/4 v2] net: mvmdio: allow platform device style registration Florian Fainelli
2013-03-14 18:11 ` Florian Fainelli
2013-03-14 18:11 ` Florian Fainelli
2013-03-15 12:53 ` [PATCH 0/4] mv643xx_eth: use mvmdio MDIO bus driver David Miller
2013-03-15 12:53 ` David Miller
2013-03-15 12:53 ` David Miller
2013-03-15 12:51 ` Florian Fainelli
2013-03-15 12:51 ` Florian Fainelli
2013-03-15 12:51 ` Florian Fainelli
2013-03-15 12:55 ` David Miller
2013-03-15 12:55 ` David Miller
2013-03-15 12:55 ` David Miller
2013-03-15 12:55 ` David Miller
2013-03-15 12:53 ` Florian Fainelli
2013-03-15 12:53 ` Florian Fainelli
2013-03-15 12:53 ` Florian Fainelli
2013-03-15 13:05 ` David Miller
2013-03-15 13:05 ` David Miller
2013-03-15 13:05 ` David Miller
2013-03-15 13:05 ` David Miller
2013-03-15 13:03 ` Florian Fainelli
2013-03-15 13:03 ` Florian Fainelli
2013-03-15 13:03 ` Florian Fainelli
2013-03-15 13:03 ` Florian Fainelli
2013-03-22 13:39 ` [PATCH 0/4 v3] " Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` [PATCH 1/4 v3] net: mvmdio: allow platform device style registration Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` [PATCH 2/4 v3] net: mvmdio: rename base register cookie from smireg to regs Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` [PATCH 3/4 v3] net: mvmdio: enhance driver to support SMI error/done interrupts Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` [PATCH 4/4 v3] mv643xx_eth: convert to use the Marvell Orion MDIO driver Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:39 ` Florian Fainelli
2013-03-22 13:53 ` [PATCH 0/4 v3] mv643xx_eth: use mvmdio MDIO bus driver Thomas Petazzoni
2013-03-22 13:53 ` Thomas Petazzoni
2013-03-22 13:53 ` Thomas Petazzoni
2013-03-22 14:14 ` Jason Cooper
2013-03-22 14:14 ` Jason Cooper
2013-03-22 14:14 ` Jason Cooper
2013-03-22 14:24 ` Florian Fainelli
2013-03-22 14:24 ` Florian Fainelli
2013-03-22 14:24 ` Florian Fainelli
2013-03-22 14:29 ` Jason Cooper
2013-03-22 14:29 ` Jason Cooper
2013-03-22 14:29 ` Jason Cooper
2013-03-22 14:31 ` Florian Fainelli
2013-03-22 14:31 ` Florian Fainelli
2013-03-22 14:31 ` Florian Fainelli
2013-03-22 14:26 ` David Miller
2013-03-22 14:26 ` David Miller
2013-03-22 14:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5107EC56.2000703@openwrt.org \
--to=florian@openwrt.org \
--cc=andrew@lunn.ch \
--cc=benh@kernel.crashing.org \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.