From: "Heiko Stübner" <heiko@sntech.de> To: Tomasz Figa <t.figa@samsung.com> Cc: linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, kyungmin.park@samsung.com, linux@simtec.co.uk, broonie@opensource.wolfsonmicro.com, kwangwoo.lee@gmail.com, jacmet@sunsite.dk, augulis.darius@gmail.com, mcuelenaere@gmail.com, linux@arm.linux.org.uk, sylvester.nawrocki@gmail.com, buserror@gmail.com, christer@weinigel.se, jekhor@gmail.com, ghcstop@gmail.com, mark.rutland@arm.com, tomasz.figa@gmail.com, robherring2@gmail.com, m.szyprowski@samsung.com, arnd@arndb.de, john.stultz@linaro.org, tglx@linutronix.de Subject: Re: [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support Date: Sat, 13 Apr 2013 00:22:48 +0200 [thread overview] Message-ID: <201304130022.49987.heiko@sntech.de> (raw) In-Reply-To: <1365794250-14436-1-git-send-email-t.figa@samsung.com> Hi Tomasz, Am Freitag, 12. April 2013, 21:17:16 schrieb Tomasz Figa: > This series is an attempt to make the samsung-time clocksource driver ready > for multiplatform kernels. It moves the driver to drivers/clocksource, > cleans it up from uses of static platform-specific definitions, simplifies > timer interrupt handling and adds Device Tree support. > > The samsung_pwm clocksource driver is made the master driver, which > exposes a single function to the PWM driver to get required data. Only > samsung-time driver is reworked to use the master driver at this time, > since the PWM driver can be already considered broken at the moment and > needs separate series of several patches to fix and clean it up, which > I am already working on. > > Tested on Universal C210 board with Device Tree. Not tested without > Device Tree, since it has been already broken before this series. > Compile tested for other related SoCs. On a s3c2416 based board with both non-dt and preliminary-dt support Tested-by: Heiko Stuebner <heiko@sntech.de> One nitpick: Without dt support, you get this: CC drivers/clocksource/samsung_pwm.o drivers/clocksource/samsung_pwm.c:620: warning: ‘samsung_pwm_clocksource_init_of’ defined but not used So, something like the following might be necessary -------------- 8< ------------------- diff --git a/drivers/clocksource/samsung_pwm.c b/drivers/clocksource/samsung_pwm.c index a12ee08..2bf8303 100644 --- a/drivers/clocksource/samsung_pwm.c +++ b/drivers/clocksource/samsung_pwm.c @@ -617,6 +617,7 @@ static void __init __samsung_pwm_clocksource_init( samsung_clocksource_init(); } +#ifdef CONFIG_CLKSRC_OF static void __init samsung_pwm_clocksource_init_of(struct device_node *np) { __samsung_pwm_clocksource_init(NULL, np); @@ -629,6 +630,7 @@ CLOCKSOURCE_OF_DECLARE(s5p6440_pwm, "samsung,s5p6440-pwm", samsung_pwm_clocksource_init_of); CLOCKSOURCE_OF_DECLARE(s5pc100_pwm, "samsung,s5pc100-pwm", samsung_pwm_clocksource_init_of); +#endif void __init samsung_pwm_clocksource_init(struct platform_device *pdev) { -------------- 8< ------------------- Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support Date: Sat, 13 Apr 2013 00:22:48 +0200 [thread overview] Message-ID: <201304130022.49987.heiko@sntech.de> (raw) In-Reply-To: <1365794250-14436-1-git-send-email-t.figa@samsung.com> Hi Tomasz, Am Freitag, 12. April 2013, 21:17:16 schrieb Tomasz Figa: > This series is an attempt to make the samsung-time clocksource driver ready > for multiplatform kernels. It moves the driver to drivers/clocksource, > cleans it up from uses of static platform-specific definitions, simplifies > timer interrupt handling and adds Device Tree support. > > The samsung_pwm clocksource driver is made the master driver, which > exposes a single function to the PWM driver to get required data. Only > samsung-time driver is reworked to use the master driver at this time, > since the PWM driver can be already considered broken at the moment and > needs separate series of several patches to fix and clean it up, which > I am already working on. > > Tested on Universal C210 board with Device Tree. Not tested without > Device Tree, since it has been already broken before this series. > Compile tested for other related SoCs. On a s3c2416 based board with both non-dt and preliminary-dt support Tested-by: Heiko Stuebner <heiko@sntech.de> One nitpick: Without dt support, you get this: CC drivers/clocksource/samsung_pwm.o drivers/clocksource/samsung_pwm.c:620: warning: ?samsung_pwm_clocksource_init_of? defined but not used So, something like the following might be necessary -------------- 8< ------------------- diff --git a/drivers/clocksource/samsung_pwm.c b/drivers/clocksource/samsung_pwm.c index a12ee08..2bf8303 100644 --- a/drivers/clocksource/samsung_pwm.c +++ b/drivers/clocksource/samsung_pwm.c @@ -617,6 +617,7 @@ static void __init __samsung_pwm_clocksource_init( samsung_clocksource_init(); } +#ifdef CONFIG_CLKSRC_OF static void __init samsung_pwm_clocksource_init_of(struct device_node *np) { __samsung_pwm_clocksource_init(NULL, np); @@ -629,6 +630,7 @@ CLOCKSOURCE_OF_DECLARE(s5p6440_pwm, "samsung,s5p6440-pwm", samsung_pwm_clocksource_init_of); CLOCKSOURCE_OF_DECLARE(s5pc100_pwm, "samsung,s5pc100-pwm", samsung_pwm_clocksource_init_of); +#endif void __init samsung_pwm_clocksource_init(struct platform_device *pdev) { -------------- 8< ------------------- Heiko
next prev parent reply other threads:[~2013-04-12 22:22 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-04-12 19:17 [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 01/14] ARM: SAMSUNG: Move samsung-time to drivers/clocksource Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa [not found] ` <1365794250-14436-2-git-send-email-t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2013-04-12 20:44 ` Arnd Bergmann 2013-04-12 20:44 ` Arnd Bergmann 2013-04-12 20:52 ` Tomasz Figa 2013-04-12 20:52 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 02/14] clocksource: samsung-pwm: Clean up platform header Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 03/14] clocksource: samsung-pwm: Add infrastructure to share PWM hardware Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 20:42 ` Arnd Bergmann 2013-04-12 20:42 ` Arnd Bergmann 2013-04-12 20:47 ` Tomasz Figa 2013-04-12 20:47 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 04/14] ARM: SAMSUNG: Unify base address definitions of timer block Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 05/14] ARM: SAMSUNG: Add new PWM platform device Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 06/14] ARM: SAMSUNG: Set PWM platform data Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 07/14] clocksource: samsung-pwm: Use platform data to setup the clocksource Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 08/14] clocksource: samsung-pwm: Synchronize register accesses Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 09/14] clocksource: samsung-pwm: Move IRQ mask/ack handling to the driver Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 10/14] ARM: SAMSUNG: Remove unused PWM timer IRQ chip code Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 11/14] clocksource: samsung-pwm: Configure dividers directly Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 12/14] clocksource: samsung-pwm: Do not use static mapping of registers Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 13/14] clocksource: samsung-pwm: Drop unnecessary includes Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 19:17 ` [PATCH v5 14/14] clocksource: samsung-pwm: Prepare for clocksource_of_init Tomasz Figa 2013-04-12 19:17 ` Tomasz Figa 2013-04-12 20:51 ` [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support Arnd Bergmann 2013-04-12 20:51 ` Arnd Bergmann 2013-04-22 17:37 ` Kukjin Kim 2013-04-22 17:37 ` Kukjin Kim 2013-04-22 19:21 ` Tomasz Figa 2013-04-22 19:21 ` Tomasz Figa 2013-04-12 22:22 ` Heiko Stübner [this message] 2013-04-12 22:22 ` Heiko Stübner 2013-04-12 22:26 ` Arnd Bergmann 2013-04-12 22:26 ` Arnd Bergmann 2013-04-12 22:39 ` Heiko Stübner 2013-04-12 22:39 ` Heiko Stübner 2013-04-12 22:42 ` Tomasz Figa 2013-04-12 22:42 ` Tomasz Figa 2013-04-13 12:28 ` Tomasz Figa 2013-04-13 12:28 ` Tomasz Figa 2013-04-16 16:22 ` Mark Brown 2013-04-16 16:22 ` Mark Brown 2013-04-16 20:51 ` Sylwester Nawrocki 2013-04-16 20:51 ` Sylwester Nawrocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201304130022.49987.heiko@sntech.de \ --to=heiko@sntech.de \ --cc=arnd@arndb.de \ --cc=augulis.darius@gmail.com \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=buserror@gmail.com \ --cc=christer@weinigel.se \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=ghcstop@gmail.com \ --cc=jacmet@sunsite.dk \ --cc=jekhor@gmail.com \ --cc=john.stultz@linaro.org \ --cc=kgene.kim@samsung.com \ --cc=kwangwoo.lee@gmail.com \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=linux@simtec.co.uk \ --cc=m.szyprowski@samsung.com \ --cc=mark.rutland@arm.com \ --cc=mcuelenaere@gmail.com \ --cc=robherring2@gmail.com \ --cc=sylvester.nawrocki@gmail.com \ --cc=t.figa@samsung.com \ --cc=tglx@linutronix.de \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.