From: "Heiko Stübner" <heiko@sntech.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: mark.rutland@arm.com, Tomasz Figa <t.figa@samsung.com>,
tomasz.figa@gmail.com, buserror@gmail.com, jacmet@sunsite.dk,
augulis.darius@gmail.com, christer@weinigel.se,
sylvester.nawrocki@gmail.com, m.szyprowski@samsung.com,
kgene.kim@samsung.com, linux@arm.linux.org.uk,
kwangwoo.lee@gmail.com, mcuelenaere@gmail.com,
devicetree-discuss@lists.ozlabs.org,
linux-samsung-soc@vger.kernel.org, john.stultz@linaro.org,
ghcstop@gmail.com, linux@simtec.co.uk,
linux-arm-kernel@lists.infradead.org,
broonie@opensource.wolfsonmicro.com, jekhor@gmail.com,
kyungmin.park@samsung.com, tglx@linutronix.de
Subject: Re: [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support
Date: Sat, 13 Apr 2013 00:39:24 +0200 [thread overview]
Message-ID: <201304130039.24872.heiko@sntech.de> (raw)
In-Reply-To: <7765249.PbghLduf67@wuerfel>
Am Samstag, 13. April 2013, 00:26:43 schrieb Arnd Bergmann:
> On Saturday 13 April 2013 00:22:48 Heiko Stübner wrote:
> > Without dt support, you get this:
> > CC drivers/clocksource/samsung_pwm.o
> >
> > drivers/clocksource/samsung_pwm.c:620: warning:
> > ‘samsung_pwm_clocksource_init_of’ defined but not used
> >
> > So, something like the following might be necessary
>
> That patch should not be required any more with the definition
>
> #ifdef CONFIG_CLKSRC_OF
> extern void clocksource_of_init(void);
>
> #define CLOCKSOURCE_OF_DECLARE(name, compat, fn) \
> static const struct of_device_id __clksrc_of_table_##name \
> __used __section(__clksrc_of_table) \
> = { .compatible = compat, \
> .data = (fn == (clocksource_of_init_fn)NULL) ? fn : fn
> } #else
> static inline void clocksource_of_init(void) {}
> #define CLOCKSOURCE_OF_DECLARE(name, compat, fn) \
> static const struct of_device_id __clksrc_of_table_##name \
> __attribute__((unused)) \
> = { .compatible = compat, \
> .data = (fn == (clocksource_of_init_fn)NULL) ? fn : fn
> } #endif
>
> which turns the ‘samsung_pwm_clocksource_init_of’ function into an unused
> symbol that gets silently dropped by gcc, at least in theory. Are you
> using the latest clksrc/cleanup branch as a base?
Nope, I just put the stuff on top of all the other changes. So it seems
everything is fine and working ... very nice :-)
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support
Date: Sat, 13 Apr 2013 00:39:24 +0200 [thread overview]
Message-ID: <201304130039.24872.heiko@sntech.de> (raw)
In-Reply-To: <7765249.PbghLduf67@wuerfel>
Am Samstag, 13. April 2013, 00:26:43 schrieb Arnd Bergmann:
> On Saturday 13 April 2013 00:22:48 Heiko St?bner wrote:
> > Without dt support, you get this:
> > CC drivers/clocksource/samsung_pwm.o
> >
> > drivers/clocksource/samsung_pwm.c:620: warning:
> > ?samsung_pwm_clocksource_init_of? defined but not used
> >
> > So, something like the following might be necessary
>
> That patch should not be required any more with the definition
>
> #ifdef CONFIG_CLKSRC_OF
> extern void clocksource_of_init(void);
>
> #define CLOCKSOURCE_OF_DECLARE(name, compat, fn) \
> static const struct of_device_id __clksrc_of_table_##name \
> __used __section(__clksrc_of_table) \
> = { .compatible = compat, \
> .data = (fn == (clocksource_of_init_fn)NULL) ? fn : fn
> } #else
> static inline void clocksource_of_init(void) {}
> #define CLOCKSOURCE_OF_DECLARE(name, compat, fn) \
> static const struct of_device_id __clksrc_of_table_##name \
> __attribute__((unused)) \
> = { .compatible = compat, \
> .data = (fn == (clocksource_of_init_fn)NULL) ? fn : fn
> } #endif
>
> which turns the ?samsung_pwm_clocksource_init_of? function into an unused
> symbol that gets silently dropped by gcc, at least in theory. Are you
> using the latest clksrc/cleanup branch as a base?
Nope, I just put the stuff on top of all the other changes. So it seems
everything is fine and working ... very nice :-)
Heiko
next prev parent reply other threads:[~2013-04-12 22:39 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 19:17 [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 01/14] ARM: SAMSUNG: Move samsung-time to drivers/clocksource Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
[not found] ` <1365794250-14436-2-git-send-email-t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-04-12 20:44 ` Arnd Bergmann
2013-04-12 20:44 ` Arnd Bergmann
2013-04-12 20:52 ` Tomasz Figa
2013-04-12 20:52 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 02/14] clocksource: samsung-pwm: Clean up platform header Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 03/14] clocksource: samsung-pwm: Add infrastructure to share PWM hardware Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 20:42 ` Arnd Bergmann
2013-04-12 20:42 ` Arnd Bergmann
2013-04-12 20:47 ` Tomasz Figa
2013-04-12 20:47 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 04/14] ARM: SAMSUNG: Unify base address definitions of timer block Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 05/14] ARM: SAMSUNG: Add new PWM platform device Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 06/14] ARM: SAMSUNG: Set PWM platform data Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 07/14] clocksource: samsung-pwm: Use platform data to setup the clocksource Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 08/14] clocksource: samsung-pwm: Synchronize register accesses Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 09/14] clocksource: samsung-pwm: Move IRQ mask/ack handling to the driver Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 10/14] ARM: SAMSUNG: Remove unused PWM timer IRQ chip code Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 11/14] clocksource: samsung-pwm: Configure dividers directly Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 12/14] clocksource: samsung-pwm: Do not use static mapping of registers Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 13/14] clocksource: samsung-pwm: Drop unnecessary includes Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 19:17 ` [PATCH v5 14/14] clocksource: samsung-pwm: Prepare for clocksource_of_init Tomasz Figa
2013-04-12 19:17 ` Tomasz Figa
2013-04-12 20:51 ` [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support Arnd Bergmann
2013-04-12 20:51 ` Arnd Bergmann
2013-04-22 17:37 ` Kukjin Kim
2013-04-22 17:37 ` Kukjin Kim
2013-04-22 19:21 ` Tomasz Figa
2013-04-22 19:21 ` Tomasz Figa
2013-04-12 22:22 ` Heiko Stübner
2013-04-12 22:22 ` Heiko Stübner
2013-04-12 22:26 ` Arnd Bergmann
2013-04-12 22:26 ` Arnd Bergmann
2013-04-12 22:39 ` Heiko Stübner [this message]
2013-04-12 22:39 ` Heiko Stübner
2013-04-12 22:42 ` Tomasz Figa
2013-04-12 22:42 ` Tomasz Figa
2013-04-13 12:28 ` Tomasz Figa
2013-04-13 12:28 ` Tomasz Figa
2013-04-16 16:22 ` Mark Brown
2013-04-16 16:22 ` Mark Brown
2013-04-16 20:51 ` Sylwester Nawrocki
2013-04-16 20:51 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304130039.24872.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=arnd@arndb.de \
--cc=augulis.darius@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=buserror@gmail.com \
--cc=christer@weinigel.se \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=ghcstop@gmail.com \
--cc=jacmet@sunsite.dk \
--cc=jekhor@gmail.com \
--cc=john.stultz@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=kwangwoo.lee@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@simtec.co.uk \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mcuelenaere@gmail.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=t.figa@samsung.com \
--cc=tglx@linutronix.de \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.