All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
	linux-arm-kernel@lists.infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH 0/4] mtd: gpmi: support two nand chips at most
Date: Sat, 10 Aug 2013 23:09:21 -0700	[thread overview]
Message-ID: <20130811060921.GB16906@norris.computersforpeace.net> (raw)
In-Reply-To: <1371197185-27491-1-git-send-email-b32955@freescale.com>

On Fri, Jun 14, 2013 at 04:06:21PM +0800, Huang Shijie wrote:
> Current gpmi-nand driver only supports one chips. But we may meet
> some embarrassing situation, such as Micron MT29F32G08QAA.
> This nand chip has two DIEs internally. Each die has its own chip select pin,
> so this chip acts as two nand chips.
> 
> If we only scan one chip, we may find that we only get 2G for this chip,
> but in actually, this chip's size is 4G.
> 
> So scan two chips by default.
> 
> In order to support two nand chips, we have to do the following:
>    1.) We only have one dma channel now, so decouple the chip select
>       from the DMA channel, We can use the dma 0 to access all the nand chips.
> 
>    2.) fix the wrong method of checking the ready/busy status.
>       In the imx6, all the ready/busy pins are binding together, we
>       should check ready/busy status of chip 0 for the all the chips. 
> 
> Tested this patch set with MT29F32G08QAA.
> 
> 
> Huang Shijie (4):
>   mtd: gpmi: decouple the chip select from the DMA channel
>   mtd: gpmi: use DMA channel 0 for all the nand chips
>   mtd: gpmi: scan two nand chips
>   mtd: gpmi: imx6: fix the wrong method for checking ready/busy
> 
>  drivers/mtd/nand/gpmi-nand/gpmi-lib.c  |   14 ++++++++++++++
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    7 +++----
>  drivers/mtd/nand/gpmi-nand/gpmi-regs.h |    3 +++
>  3 files changed, 20 insertions(+), 4 deletions(-)

What's the status on this patch set? It doesn't look like it got merged.
Do you have any testing for this? It looks sane enough to me.

Brian

WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] mtd: gpmi: support two nand chips at most
Date: Sat, 10 Aug 2013 23:09:21 -0700	[thread overview]
Message-ID: <20130811060921.GB16906@norris.computersforpeace.net> (raw)
In-Reply-To: <1371197185-27491-1-git-send-email-b32955@freescale.com>

On Fri, Jun 14, 2013 at 04:06:21PM +0800, Huang Shijie wrote:
> Current gpmi-nand driver only supports one chips. But we may meet
> some embarrassing situation, such as Micron MT29F32G08QAA.
> This nand chip has two DIEs internally. Each die has its own chip select pin,
> so this chip acts as two nand chips.
> 
> If we only scan one chip, we may find that we only get 2G for this chip,
> but in actually, this chip's size is 4G.
> 
> So scan two chips by default.
> 
> In order to support two nand chips, we have to do the following:
>    1.) We only have one dma channel now, so decouple the chip select
>       from the DMA channel, We can use the dma 0 to access all the nand chips.
> 
>    2.) fix the wrong method of checking the ready/busy status.
>       In the imx6, all the ready/busy pins are binding together, we
>       should check ready/busy status of chip 0 for the all the chips. 
> 
> Tested this patch set with MT29F32G08QAA.
> 
> 
> Huang Shijie (4):
>   mtd: gpmi: decouple the chip select from the DMA channel
>   mtd: gpmi: use DMA channel 0 for all the nand chips
>   mtd: gpmi: scan two nand chips
>   mtd: gpmi: imx6: fix the wrong method for checking ready/busy
> 
>  drivers/mtd/nand/gpmi-nand/gpmi-lib.c  |   14 ++++++++++++++
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    7 +++----
>  drivers/mtd/nand/gpmi-nand/gpmi-regs.h |    3 +++
>  3 files changed, 20 insertions(+), 4 deletions(-)

What's the status on this patch set? It doesn't look like it got merged.
Do you have any testing for this? It looks sane enough to me.

Brian

  parent reply	other threads:[~2013-08-11  6:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  8:06 [PATCH 0/4] mtd: gpmi: support two nand chips at most Huang Shijie
2013-06-14  8:06 ` Huang Shijie
2013-06-14  8:06 ` [PATCH 1/4] mtd: gpmi: decouple the chip select from the DMA channel Huang Shijie
2013-06-14  8:06   ` Huang Shijie
2013-06-14  8:06 ` [PATCH 2/4] mtd: gpmi: use DMA channel 0 for all the nand chips Huang Shijie
2013-06-14  8:06   ` Huang Shijie
2013-06-14  8:06 ` [PATCH 3/4] mtd: gpmi: scan two " Huang Shijie
2013-06-14  8:06   ` Huang Shijie
2013-06-14  8:06 ` [PATCH 4/4] mtd: gpmi: imx6: fix the wrong method for checking ready/busy Huang Shijie
2013-06-14  8:06   ` Huang Shijie
2013-08-11  6:09 ` Brian Norris [this message]
2013-08-11  6:09   ` [PATCH 0/4] mtd: gpmi: support two nand chips at most Brian Norris
2013-08-11 19:52   ` Huang Shijie
2013-08-11 19:52     ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130811060921.GB16906@norris.computersforpeace.net \
    --to=computersforpeace@gmail.com \
    --cc=b32955@freescale.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.