From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: r8a7779: Remove unused clock constants
Date: Thu, 07 Nov 2013 08:52:57 +0000 [thread overview]
Message-ID: <20131107085253.GE17384@verge.net.au> (raw)
In-Reply-To: <1395939.NimcadHhnk@avalon>
On Wed, Nov 06, 2013 at 01:59:20PM +0100, Laurent Pinchart wrote:
> Hi Simon,
>
> Thank you for the patch.
>
> On Wednesday 06 November 2013 15:48:43 Simon Horman wrote:
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > arch/arm/mach-shmobile/clock-r8a7779.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/arch/arm/mach-shmobile/clock-r8a7779.c
> > b/arch/arm/mach-shmobile/clock-r8a7779.c index b7ce0e7..3083c70 100644
> > --- a/arch/arm/mach-shmobile/clock-r8a7779.c
> > +++ b/arch/arm/mach-shmobile/clock-r8a7779.c
> > @@ -47,17 +47,9 @@
> >
> > #define MD(nr) BIT(nr)
> >
> > -#define FRQMR IOMEM(0xffc80014)
> > #define MSTPCR0 IOMEM(0xffc80030)
> > #define MSTPCR1 IOMEM(0xffc80034)
> > #define MSTPCR3 IOMEM(0xffc8003c)
> > -#define MSTPSR1 IOMEM(0xffc80044)
> > -#define MSTPSR4 IOMEM(0xffc80048)
> > -#define MSTPSR6 IOMEM(0xffc8004c)
> > -#define MSTPCR4 IOMEM(0xffc80050)
> > -#define MSTPCR5 IOMEM(0xffc80054)
> > -#define MSTPCR6 IOMEM(0xffc80058)
> > -#define MSTPCR7 IOMEM(0xffc80040)
>
> It has been pointed out to me that the CPG requires waiting for clocks to be
> enabled on all R-Mobile and R-Car SoCs. I've send a patch series to implement
> this for r8a7790 ("[PATCH 0/2] ARM: shmobile: r8a7790: Wait for status on all
> MSTP clocks"). Should we expand that to the other SoCs as well ? In that case
> the constants would be needed.
That is a good question.
I am unsure if waiting is only required for Gen2 R-Car SoCs or
Gen1 as well. If it is requried for Gen1 then it would
make sense to extend the coverage of your series to H1 (r8a7779).
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: r8a7779: Remove unused clock constants
Date: Thu, 7 Nov 2013 17:52:57 +0900 [thread overview]
Message-ID: <20131107085253.GE17384@verge.net.au> (raw)
In-Reply-To: <1395939.NimcadHhnk@avalon>
On Wed, Nov 06, 2013 at 01:59:20PM +0100, Laurent Pinchart wrote:
> Hi Simon,
>
> Thank you for the patch.
>
> On Wednesday 06 November 2013 15:48:43 Simon Horman wrote:
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > arch/arm/mach-shmobile/clock-r8a7779.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/arch/arm/mach-shmobile/clock-r8a7779.c
> > b/arch/arm/mach-shmobile/clock-r8a7779.c index b7ce0e7..3083c70 100644
> > --- a/arch/arm/mach-shmobile/clock-r8a7779.c
> > +++ b/arch/arm/mach-shmobile/clock-r8a7779.c
> > @@ -47,17 +47,9 @@
> >
> > #define MD(nr) BIT(nr)
> >
> > -#define FRQMR IOMEM(0xffc80014)
> > #define MSTPCR0 IOMEM(0xffc80030)
> > #define MSTPCR1 IOMEM(0xffc80034)
> > #define MSTPCR3 IOMEM(0xffc8003c)
> > -#define MSTPSR1 IOMEM(0xffc80044)
> > -#define MSTPSR4 IOMEM(0xffc80048)
> > -#define MSTPSR6 IOMEM(0xffc8004c)
> > -#define MSTPCR4 IOMEM(0xffc80050)
> > -#define MSTPCR5 IOMEM(0xffc80054)
> > -#define MSTPCR6 IOMEM(0xffc80058)
> > -#define MSTPCR7 IOMEM(0xffc80040)
>
> It has been pointed out to me that the CPG requires waiting for clocks to be
> enabled on all R-Mobile and R-Car SoCs. I've send a patch series to implement
> this for r8a7790 ("[PATCH 0/2] ARM: shmobile: r8a7790: Wait for status on all
> MSTP clocks"). Should we expand that to the other SoCs as well ? In that case
> the constants would be needed.
That is a good question.
I am unsure if waiting is only required for Gen2 R-Car SoCs or
Gen1 as well. If it is requried for Gen1 then it would
make sense to extend the coverage of your series to H1 (r8a7779).
next prev parent reply other threads:[~2013-11-07 8:52 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 1:28 [GIT PULL v2] Renesas ARM-based SoC: Marzen and r8a7779 for 3.7 Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 01/11] r8a7779: add SDHI clock support Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 02/11] marzen: add SDHI0 support Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 03/11] ARM: mach-shmobile: marzen: defconfig update Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 04/11] ARM: shmobile: r8a7779: PFC rename PENCx -> USB_PENCx Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 05/11] ARM: shmobile: r8a7779: add USB common phy initializer Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-09-03 21:38 ` Arnd Bergmann
2012-09-03 21:38 ` Arnd Bergmann
2012-09-04 0:21 ` Kuninori Morimoto
2012-09-04 0:21 ` Kuninori Morimoto
2012-09-04 0:34 ` Simon Horman
2012-09-04 0:34 ` Simon Horman
2012-09-04 4:50 ` [PATCH] ARM: shmobile: r8a7779: remove USB " Kuninori Morimoto
2012-09-04 4:50 ` Kuninori Morimoto
2012-09-05 1:20 ` Simon Horman
2012-09-05 1:20 ` Simon Horman
2012-09-05 1:23 ` Simon Horman
2012-09-05 1:23 ` Simon Horman
2012-09-05 2:00 ` Kuninori Morimoto
2012-09-05 2:00 ` Kuninori Morimoto
2012-09-05 8:13 ` Simon Horman
2012-09-05 8:13 ` Simon Horman
2012-09-12 5:16 ` Simon Horman
2012-09-12 5:16 ` Simon Horman
2012-09-12 5:31 ` Kuninori Morimoto
2012-09-12 5:31 ` Kuninori Morimoto
2012-09-12 6:30 ` Felipe Balbi
2012-09-12 6:30 ` Felipe Balbi
2012-09-12 7:16 ` Kuninori Morimoto
2012-09-12 7:16 ` Kuninori Morimoto
2012-09-12 7:19 ` Simon Horman
2012-09-12 7:19 ` Simon Horman
2013-11-06 6:48 ` [PATCH] ARM: shmobile: r8a7779: Remove unused clock constants Simon Horman
2013-11-06 6:48 ` Simon Horman
2013-11-06 12:59 ` Laurent Pinchart
2013-11-06 12:59 ` Laurent Pinchart
2013-11-07 8:52 ` Simon Horman [this message]
2013-11-07 8:52 ` Simon Horman
2014-01-08 4:34 ` Simon Horman
2014-01-08 4:34 ` Simon Horman
2014-01-08 7:52 ` Laurent Pinchart
2014-01-08 7:52 ` Laurent Pinchart
2014-01-09 5:10 ` Simon Horman
2014-01-09 5:10 ` Simon Horman
2012-08-31 1:28 ` [PATCH 06/11] ARM: shmobile: r8a7779: add USB EHCI clock support Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 07/11] ARM: shmobile: r8a7779: add USB OHCI " Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 08/11] ARM: shmobile: marzen: add USB EHCI driver support Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 09/11] ARM: shmobile: marzen: fixup regulator id for smsc911x Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 10/11] ARM: shmobile: marzen: enable thermal sensor Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 11/11] ARM: shmobile: marzen: add USB OHCI driver support Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 6:24 ` [GIT PULL v2] Renesas ARM-based SoC: Marzen and r8a7779 for 3.7 Simon Horman
2012-08-31 6:24 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107085253.GE17384@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.