From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 05/11] ARM: shmobile: r8a7779: add USB common phy initializer
Date: Tue, 04 Sep 2012 00:21:22 +0000 [thread overview]
Message-ID: <87k3wafxj4.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <201209032138.41485.arnd@arndb.de>
Hi Arnd, Simon
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > This patch adds common USB phy ports initializer for r8a7779.
> >
> > The note is that each USB IP have own MSTP clock bit,
> > and common USB phy port doesn't have MSTP clock,
> > but this USB phy needs USB clock.
> > Each USB driver / platform should keep USB MSTP clock somehow.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Signed-off-by: Simon Horman <horms@verge.net.au>
> > ---
> > arch/arm/mach-shmobile/include/mach/common.h | 1 +
> > arch/arm/mach-shmobile/setup-r8a7779.c | 93 ++++++++++++++++++++++++++++
> > 2 files changed, 94 insertions(+)
>
> Shouldn't the USB PHY driver go to drivers/usb/phy/ or
> drivers/usb/host/ehci-sh.c?
>
> We are trying hard to move driver code out of the platform and into driver
> directories these days, and having it wired up as part of the platform
> the way you do also means it is always powered on.
I see.
I can move this code to under driver.
Can I send additional patch for it ?
- move usb phy code to driver (to Simon, USB ML)
Or should I send multi patches ?
- remove this patch (to Simon)
- add usb phy driver patch (to USB ML)
- use usb phy driver patch (to Simon)
> I see neither big-endian support on shmobile, nor any XHCI (USB-3.0) driver, just
> the old EHCI (USB-2.0) and OHCI (USB-1.1) drivers. Are you submitting the XHCI
> support and big-endian platform code separately?
Sorry for very confusing naming.
I fix it
Best regards
---
Kuninori Morimoto
WARNING: multiple messages have this Message-ID (diff)
From: kuninori.morimoto.gx@renesas.com (Kuninori Morimoto)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/11] ARM: shmobile: r8a7779: add USB common phy initializer
Date: Mon, 03 Sep 2012 17:21:22 -0700 (PDT) [thread overview]
Message-ID: <87k3wafxj4.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <201209032138.41485.arnd@arndb.de>
Hi Arnd, Simon
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > This patch adds common USB phy ports initializer for r8a7779.
> >
> > The note is that each USB IP have own MSTP clock bit,
> > and common USB phy port doesn't have MSTP clock,
> > but this USB phy needs USB clock.
> > Each USB driver / platform should keep USB MSTP clock somehow.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Signed-off-by: Simon Horman <horms@verge.net.au>
> > ---
> > arch/arm/mach-shmobile/include/mach/common.h | 1 +
> > arch/arm/mach-shmobile/setup-r8a7779.c | 93 ++++++++++++++++++++++++++++
> > 2 files changed, 94 insertions(+)
>
> Shouldn't the USB PHY driver go to drivers/usb/phy/ or
> drivers/usb/host/ehci-sh.c?
>
> We are trying hard to move driver code out of the platform and into driver
> directories these days, and having it wired up as part of the platform
> the way you do also means it is always powered on.
I see.
I can move this code to under driver.
Can I send additional patch for it ?
- move usb phy code to driver (to Simon, USB ML)
Or should I send multi patches ?
- remove this patch (to Simon)
- add usb phy driver patch (to USB ML)
- use usb phy driver patch (to Simon)
> I see neither big-endian support on shmobile, nor any XHCI (USB-3.0) driver, just
> the old EHCI (USB-2.0) and OHCI (USB-1.1) drivers. Are you submitting the XHCI
> support and big-endian platform code separately?
Sorry for very confusing naming.
I fix it
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2012-09-04 0:21 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 1:28 [GIT PULL v2] Renesas ARM-based SoC: Marzen and r8a7779 for 3.7 Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 01/11] r8a7779: add SDHI clock support Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 02/11] marzen: add SDHI0 support Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 03/11] ARM: mach-shmobile: marzen: defconfig update Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 04/11] ARM: shmobile: r8a7779: PFC rename PENCx -> USB_PENCx Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 05/11] ARM: shmobile: r8a7779: add USB common phy initializer Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-09-03 21:38 ` Arnd Bergmann
2012-09-03 21:38 ` Arnd Bergmann
2012-09-04 0:21 ` Kuninori Morimoto [this message]
2012-09-04 0:21 ` Kuninori Morimoto
2012-09-04 0:34 ` Simon Horman
2012-09-04 0:34 ` Simon Horman
2012-09-04 4:50 ` [PATCH] ARM: shmobile: r8a7779: remove USB " Kuninori Morimoto
2012-09-04 4:50 ` Kuninori Morimoto
2012-09-05 1:20 ` Simon Horman
2012-09-05 1:20 ` Simon Horman
2012-09-05 1:23 ` Simon Horman
2012-09-05 1:23 ` Simon Horman
2012-09-05 2:00 ` Kuninori Morimoto
2012-09-05 2:00 ` Kuninori Morimoto
2012-09-05 8:13 ` Simon Horman
2012-09-05 8:13 ` Simon Horman
2012-09-12 5:16 ` Simon Horman
2012-09-12 5:16 ` Simon Horman
2012-09-12 5:31 ` Kuninori Morimoto
2012-09-12 5:31 ` Kuninori Morimoto
2012-09-12 6:30 ` Felipe Balbi
2012-09-12 6:30 ` Felipe Balbi
2012-09-12 7:16 ` Kuninori Morimoto
2012-09-12 7:16 ` Kuninori Morimoto
2012-09-12 7:19 ` Simon Horman
2012-09-12 7:19 ` Simon Horman
2013-11-06 6:48 ` [PATCH] ARM: shmobile: r8a7779: Remove unused clock constants Simon Horman
2013-11-06 6:48 ` Simon Horman
2013-11-06 12:59 ` Laurent Pinchart
2013-11-06 12:59 ` Laurent Pinchart
2013-11-07 8:52 ` Simon Horman
2013-11-07 8:52 ` Simon Horman
2014-01-08 4:34 ` Simon Horman
2014-01-08 4:34 ` Simon Horman
2014-01-08 7:52 ` Laurent Pinchart
2014-01-08 7:52 ` Laurent Pinchart
2014-01-09 5:10 ` Simon Horman
2014-01-09 5:10 ` Simon Horman
2012-08-31 1:28 ` [PATCH 06/11] ARM: shmobile: r8a7779: add USB EHCI clock support Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 07/11] ARM: shmobile: r8a7779: add USB OHCI " Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 08/11] ARM: shmobile: marzen: add USB EHCI driver support Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 09/11] ARM: shmobile: marzen: fixup regulator id for smsc911x Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 10/11] ARM: shmobile: marzen: enable thermal sensor Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 1:28 ` [PATCH 11/11] ARM: shmobile: marzen: add USB OHCI driver support Simon Horman
2012-08-31 1:28 ` Simon Horman
2012-08-31 6:24 ` [GIT PULL v2] Renesas ARM-based SoC: Marzen and r8a7779 for 3.7 Simon Horman
2012-08-31 6:24 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3wafxj4.wl%kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.