From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Alexandre Courbot <gnurou@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
devicetree <devicetree@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH RFC 4/6] net: rfkill: gpio: add device tree support
Date: Mon, 20 Jan 2014 10:10:07 +0200 [thread overview]
Message-ID: <20140120081007.GA19123@xps8300> (raw)
In-Reply-To: <CACRpkdZOD4zeA8T5kbJ4c5NsnuzHCg1mw8rRMYNT9c4R-Qnc6A@mail.gmail.com>
Hi,
On Sat, Jan 18, 2014 at 12:11:56AM +0100, Linus Walleij wrote:
> On Fri, Jan 17, 2014 at 6:43 PM, Chen-Yu Tsai <wens@csie.org> wrote:
> > On Sat, Jan 18, 2014 at 12:47 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> >>> +- NAME_shutdown-gpios : GPIO phandle to shutdown control
> >>> + (phandle must be the second)
> >>> +- NAME_reset-gpios : GPIO phandle to reset control
> >>> +
> >>> +NAME must match the rfkill-name property. NAME_shutdown-gpios or
> >>> +NAME_reset-gpios, or both, must be defined.
> >>> +
> >>
> >> I don't understand this part. Why do you include the name in the
> >> gpios property, rather than just hardcoding the property strings
> >> to "shutdown-gpios" and "reset-gpios"?
> >
> > This quirk is a result of how gpiod_get_index implements device tree
> > lookup.
>
> Why can't it just have a single property "gpios", where the first
> element is the reset GPIO and the second is the shutdown GPIO?
>
> rfkill-gpio does this:
>
> gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_name, 0);
> gpio = devm_gpiod_get_index(&pdev->dev, rfkill->shutdown_name, 1);
>
> The passed con ID name parameter is only there for the device
> tree case it seems. (ACPI ignores it.) So what about you just
> don't pass it at all and patch it to do like this instead:
>
> gpio = devm_gpiod_get_index(&pdev->dev, NULL, 0);
> gpio = devm_gpiod_get_index(&pdev->dev, NULL, 1);
>
> Heikki, are you OK with this change?
Yes, definitely. That is much cleaner.
Thanks,
--
heikki
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH RFC 4/6] net: rfkill: gpio: add device tree support
Date: Mon, 20 Jan 2014 10:10:07 +0200 [thread overview]
Message-ID: <20140120081007.GA19123@xps8300> (raw)
In-Reply-To: <CACRpkdZOD4zeA8T5kbJ4c5NsnuzHCg1mw8rRMYNT9c4R-Qnc6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi,
On Sat, Jan 18, 2014 at 12:11:56AM +0100, Linus Walleij wrote:
> On Fri, Jan 17, 2014 at 6:43 PM, Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> wrote:
> > On Sat, Jan 18, 2014 at 12:47 AM, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
>
> >>> +- NAME_shutdown-gpios : GPIO phandle to shutdown control
> >>> + (phandle must be the second)
> >>> +- NAME_reset-gpios : GPIO phandle to reset control
> >>> +
> >>> +NAME must match the rfkill-name property. NAME_shutdown-gpios or
> >>> +NAME_reset-gpios, or both, must be defined.
> >>> +
> >>
> >> I don't understand this part. Why do you include the name in the
> >> gpios property, rather than just hardcoding the property strings
> >> to "shutdown-gpios" and "reset-gpios"?
> >
> > This quirk is a result of how gpiod_get_index implements device tree
> > lookup.
>
> Why can't it just have a single property "gpios", where the first
> element is the reset GPIO and the second is the shutdown GPIO?
>
> rfkill-gpio does this:
>
> gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_name, 0);
> gpio = devm_gpiod_get_index(&pdev->dev, rfkill->shutdown_name, 1);
>
> The passed con ID name parameter is only there for the device
> tree case it seems. (ACPI ignores it.) So what about you just
> don't pass it at all and patch it to do like this instead:
>
> gpio = devm_gpiod_get_index(&pdev->dev, NULL, 0);
> gpio = devm_gpiod_get_index(&pdev->dev, NULL, 1);
>
> Heikki, are you OK with this change?
Yes, definitely. That is much cleaner.
Thanks,
--
heikki
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: heikki.krogerus@linux.intel.com (Heikki Krogerus)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 4/6] net: rfkill: gpio: add device tree support
Date: Mon, 20 Jan 2014 10:10:07 +0200 [thread overview]
Message-ID: <20140120081007.GA19123@xps8300> (raw)
In-Reply-To: <CACRpkdZOD4zeA8T5kbJ4c5NsnuzHCg1mw8rRMYNT9c4R-Qnc6A@mail.gmail.com>
Hi,
On Sat, Jan 18, 2014 at 12:11:56AM +0100, Linus Walleij wrote:
> On Fri, Jan 17, 2014 at 6:43 PM, Chen-Yu Tsai <wens@csie.org> wrote:
> > On Sat, Jan 18, 2014 at 12:47 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> >>> +- NAME_shutdown-gpios : GPIO phandle to shutdown control
> >>> + (phandle must be the second)
> >>> +- NAME_reset-gpios : GPIO phandle to reset control
> >>> +
> >>> +NAME must match the rfkill-name property. NAME_shutdown-gpios or
> >>> +NAME_reset-gpios, or both, must be defined.
> >>> +
> >>
> >> I don't understand this part. Why do you include the name in the
> >> gpios property, rather than just hardcoding the property strings
> >> to "shutdown-gpios" and "reset-gpios"?
> >
> > This quirk is a result of how gpiod_get_index implements device tree
> > lookup.
>
> Why can't it just have a single property "gpios", where the first
> element is the reset GPIO and the second is the shutdown GPIO?
>
> rfkill-gpio does this:
>
> gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_name, 0);
> gpio = devm_gpiod_get_index(&pdev->dev, rfkill->shutdown_name, 1);
>
> The passed con ID name parameter is only there for the device
> tree case it seems. (ACPI ignores it.) So what about you just
> don't pass it at all and patch it to do like this instead:
>
> gpio = devm_gpiod_get_index(&pdev->dev, NULL, 0);
> gpio = devm_gpiod_get_index(&pdev->dev, NULL, 1);
>
> Heikki, are you OK with this change?
Yes, definitely. That is much cleaner.
Thanks,
--
heikki
next prev parent reply other threads:[~2014-01-20 8:10 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 6:47 [PATCH RFC 0/6] net: rfkill: gpio: Add device tree support Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` [PATCH RFC 1/6] net: rfkill: gpio: fix gpio name buffer size off by 1 Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 9:46 ` David Laight
2014-01-17 9:46 ` David Laight
2014-01-17 9:46 ` David Laight
2014-01-17 9:59 ` Chen-Yu Tsai
2014-01-17 9:59 ` Chen-Yu Tsai
2014-01-17 9:59 ` Chen-Yu Tsai
2014-01-17 9:59 ` Chen-Yu Tsai
2014-01-17 6:47 ` [PATCH RFC 2/6] net: rfkill: gpio: use clk_prepare_enable/clk_disable_unprepare Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` [PATCH RFC 3/6] net: rfkill: gpio: fix reversed clock enable state Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` [PATCH RFC 4/6] net: rfkill: gpio: add device tree support Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 16:47 ` Arnd Bergmann
2014-01-17 16:47 ` Arnd Bergmann
2014-01-17 16:47 ` Arnd Bergmann
2014-01-17 17:43 ` Chen-Yu Tsai
2014-01-17 17:43 ` Chen-Yu Tsai
2014-01-17 17:43 ` Chen-Yu Tsai
2014-01-17 20:13 ` Arnd Bergmann
2014-01-17 20:13 ` Arnd Bergmann
2014-01-17 20:13 ` Arnd Bergmann
2014-01-17 23:11 ` Linus Walleij
2014-01-17 23:11 ` Linus Walleij
2014-01-17 23:11 ` Linus Walleij
2014-01-18 4:41 ` Chen-Yu Tsai
2014-01-18 4:41 ` Chen-Yu Tsai
2014-01-18 4:41 ` Chen-Yu Tsai
2014-01-20 8:10 ` Heikki Krogerus [this message]
2014-01-20 8:10 ` Heikki Krogerus
2014-01-20 8:10 ` Heikki Krogerus
2014-01-21 3:11 ` Alexandre Courbot
2014-01-21 3:11 ` Alexandre Courbot
2014-01-21 9:35 ` Linus Walleij
2014-01-21 9:35 ` Linus Walleij
2014-01-21 9:35 ` Linus Walleij
2014-01-21 12:35 ` Arnd Bergmann
2014-01-21 12:35 ` Arnd Bergmann
2014-01-21 12:35 ` Arnd Bergmann
2014-01-21 14:53 ` Alexandre Courbot
2014-01-21 14:53 ` Alexandre Courbot
2014-01-21 14:53 ` Alexandre Courbot
2014-01-21 14:53 ` Alexandre Courbot
2014-01-21 15:25 ` Mika Westerberg
2014-01-21 15:25 ` Mika Westerberg
2014-01-21 15:25 ` Mika Westerberg
2014-01-21 18:50 ` Arnd Bergmann
2014-01-21 18:50 ` Arnd Bergmann
2014-01-21 18:50 ` Arnd Bergmann
2014-01-21 18:50 ` Arnd Bergmann
2014-01-22 12:38 ` Mark Brown
2014-01-22 12:38 ` Mark Brown
2014-01-22 12:38 ` Mark Brown
2014-01-22 12:38 ` Mark Brown
2014-01-22 9:54 ` Linus Walleij
2014-01-22 9:54 ` Linus Walleij
2014-01-22 9:54 ` Linus Walleij
2014-01-22 9:54 ` Linus Walleij
2014-01-22 9:58 ` Linus Walleij
2014-01-22 9:58 ` Linus Walleij
2014-01-22 9:58 ` Linus Walleij
2014-01-22 9:58 ` Linus Walleij
2014-01-22 11:00 ` Mika Westerberg
2014-01-22 11:00 ` Mika Westerberg
2014-01-22 11:00 ` Mika Westerberg
2014-01-22 11:00 ` Mika Westerberg
2014-01-27 14:24 ` Maxime Ripard
2014-01-27 14:24 ` Maxime Ripard
2014-01-27 14:24 ` Maxime Ripard
2014-01-29 4:01 ` [linux-sunxi] " Chen-Yu Tsai
2014-01-29 4:01 ` Chen-Yu Tsai
2014-01-29 4:01 ` Chen-Yu Tsai
2014-01-17 6:47 ` [PATCH RFC 5/6] net: rfkill: gpio: add clock-frequency device tree property Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` [PATCH RFC 6/6] ARM: sun7i: cubietruck: enable bluetooth module Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 20:26 ` [PATCH RFC 0/6] net: rfkill: gpio: Add device tree support Johannes Berg
2014-01-17 20:26 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120081007.GA19123@xps8300 \
--to=heikki.krogerus@linux.intel.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.