From: Arnd Bergmann <arnd@arndb.de>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linus Walleij <linus.walleij@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
netdev <netdev@vger.kernel.org>,
"linux-wireless" <linux-wireless@vger.kernel.org>,
"linux-sunxi" <linux-sunxi@googlegroups.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
"Chen-Yu Tsai" <wens@csie.org>,
Johannes Berg <johannes@sipsolutions.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH RFC 4/6] net: rfkill: gpio: add device tree support
Date: Tue, 21 Jan 2014 19:50:06 +0100 [thread overview]
Message-ID: <201401211950.07011.arnd@arndb.de> (raw)
In-Reply-To: <CAAVeFuKFfAvSPYLmvWV5jjT-peZFJ8sJ2bbh4F=JAYoWLhjZpA@mail.gmail.com>
On Tuesday 21 January 2014, Alexandre Courbot wrote:
> >> As discussed earlier in this thread I'm not sure the con_id is
> >> suitable for labelling GPIOs. It'd be better to have a proper name
> >> specified in DT/ACPI instead.
> >
> > +1
>
> I wonder why you guys prefer to have the name defined in the GPIO
> mapping. Having the driver decide the label makes it easier to look up
> which GPIO does what in debugfs, whereas nothing prevents people to
> name GPIOs whatever inadequate name they want in the device DT node.
> What am I overlooking here?
I should have another look at the debugfs representation, but isn't
there a global namespace that gets used for all gpios? Neither the
con_id nor the name that the driver picks would be globally unique
and stable across kernel versions, so they don't make a good user
interface.
I think what we want here is a system-wide unique identifier for
each gpio line that may get represented in debugfs, and use a new
DT mechanism to communicate that.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Heikki Krogerus
<heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH RFC 4/6] net: rfkill: gpio: add device tree support
Date: Tue, 21 Jan 2014 19:50:06 +0100 [thread overview]
Message-ID: <201401211950.07011.arnd@arndb.de> (raw)
In-Reply-To: <CAAVeFuKFfAvSPYLmvWV5jjT-peZFJ8sJ2bbh4F=JAYoWLhjZpA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tuesday 21 January 2014, Alexandre Courbot wrote:
> >> As discussed earlier in this thread I'm not sure the con_id is
> >> suitable for labelling GPIOs. It'd be better to have a proper name
> >> specified in DT/ACPI instead.
> >
> > +1
>
> I wonder why you guys prefer to have the name defined in the GPIO
> mapping. Having the driver decide the label makes it easier to look up
> which GPIO does what in debugfs, whereas nothing prevents people to
> name GPIOs whatever inadequate name they want in the device DT node.
> What am I overlooking here?
I should have another look at the debugfs representation, but isn't
there a global namespace that gets used for all gpios? Neither the
con_id nor the name that the driver picks would be globally unique
and stable across kernel versions, so they don't make a good user
interface.
I think what we want here is a system-wide unique identifier for
each gpio line that may get represented in debugfs, and use a new
DT mechanism to communicate that.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 4/6] net: rfkill: gpio: add device tree support
Date: Tue, 21 Jan 2014 19:50:06 +0100 [thread overview]
Message-ID: <201401211950.07011.arnd@arndb.de> (raw)
In-Reply-To: <CAAVeFuKFfAvSPYLmvWV5jjT-peZFJ8sJ2bbh4F=JAYoWLhjZpA@mail.gmail.com>
On Tuesday 21 January 2014, Alexandre Courbot wrote:
> >> As discussed earlier in this thread I'm not sure the con_id is
> >> suitable for labelling GPIOs. It'd be better to have a proper name
> >> specified in DT/ACPI instead.
> >
> > +1
>
> I wonder why you guys prefer to have the name defined in the GPIO
> mapping. Having the driver decide the label makes it easier to look up
> which GPIO does what in debugfs, whereas nothing prevents people to
> name GPIOs whatever inadequate name they want in the device DT node.
> What am I overlooking here?
I should have another look at the debugfs representation, but isn't
there a global namespace that gets used for all gpios? Neither the
con_id nor the name that the driver picks would be globally unique
and stable across kernel versions, so they don't make a good user
interface.
I think what we want here is a system-wide unique identifier for
each gpio line that may get represented in debugfs, and use a new
DT mechanism to communicate that.
Arnd
next prev parent reply other threads:[~2014-01-21 18:50 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 6:47 [PATCH RFC 0/6] net: rfkill: gpio: Add device tree support Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` [PATCH RFC 1/6] net: rfkill: gpio: fix gpio name buffer size off by 1 Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 9:46 ` David Laight
2014-01-17 9:46 ` David Laight
2014-01-17 9:46 ` David Laight
2014-01-17 9:59 ` Chen-Yu Tsai
2014-01-17 9:59 ` Chen-Yu Tsai
2014-01-17 9:59 ` Chen-Yu Tsai
2014-01-17 9:59 ` Chen-Yu Tsai
2014-01-17 6:47 ` [PATCH RFC 2/6] net: rfkill: gpio: use clk_prepare_enable/clk_disable_unprepare Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` [PATCH RFC 3/6] net: rfkill: gpio: fix reversed clock enable state Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` [PATCH RFC 4/6] net: rfkill: gpio: add device tree support Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 16:47 ` Arnd Bergmann
2014-01-17 16:47 ` Arnd Bergmann
2014-01-17 16:47 ` Arnd Bergmann
2014-01-17 17:43 ` Chen-Yu Tsai
2014-01-17 17:43 ` Chen-Yu Tsai
2014-01-17 17:43 ` Chen-Yu Tsai
2014-01-17 20:13 ` Arnd Bergmann
2014-01-17 20:13 ` Arnd Bergmann
2014-01-17 20:13 ` Arnd Bergmann
2014-01-17 23:11 ` Linus Walleij
2014-01-17 23:11 ` Linus Walleij
2014-01-17 23:11 ` Linus Walleij
2014-01-18 4:41 ` Chen-Yu Tsai
2014-01-18 4:41 ` Chen-Yu Tsai
2014-01-18 4:41 ` Chen-Yu Tsai
2014-01-20 8:10 ` Heikki Krogerus
2014-01-20 8:10 ` Heikki Krogerus
2014-01-20 8:10 ` Heikki Krogerus
2014-01-21 3:11 ` Alexandre Courbot
2014-01-21 3:11 ` Alexandre Courbot
2014-01-21 9:35 ` Linus Walleij
2014-01-21 9:35 ` Linus Walleij
2014-01-21 9:35 ` Linus Walleij
2014-01-21 12:35 ` Arnd Bergmann
2014-01-21 12:35 ` Arnd Bergmann
2014-01-21 12:35 ` Arnd Bergmann
2014-01-21 14:53 ` Alexandre Courbot
2014-01-21 14:53 ` Alexandre Courbot
2014-01-21 14:53 ` Alexandre Courbot
2014-01-21 14:53 ` Alexandre Courbot
2014-01-21 15:25 ` Mika Westerberg
2014-01-21 15:25 ` Mika Westerberg
2014-01-21 15:25 ` Mika Westerberg
2014-01-21 18:50 ` Arnd Bergmann [this message]
2014-01-21 18:50 ` Arnd Bergmann
2014-01-21 18:50 ` Arnd Bergmann
2014-01-21 18:50 ` Arnd Bergmann
2014-01-22 12:38 ` Mark Brown
2014-01-22 12:38 ` Mark Brown
2014-01-22 12:38 ` Mark Brown
2014-01-22 12:38 ` Mark Brown
2014-01-22 9:54 ` Linus Walleij
2014-01-22 9:54 ` Linus Walleij
2014-01-22 9:54 ` Linus Walleij
2014-01-22 9:54 ` Linus Walleij
2014-01-22 9:58 ` Linus Walleij
2014-01-22 9:58 ` Linus Walleij
2014-01-22 9:58 ` Linus Walleij
2014-01-22 9:58 ` Linus Walleij
2014-01-22 11:00 ` Mika Westerberg
2014-01-22 11:00 ` Mika Westerberg
2014-01-22 11:00 ` Mika Westerberg
2014-01-22 11:00 ` Mika Westerberg
2014-01-27 14:24 ` Maxime Ripard
2014-01-27 14:24 ` Maxime Ripard
2014-01-27 14:24 ` Maxime Ripard
2014-01-29 4:01 ` [linux-sunxi] " Chen-Yu Tsai
2014-01-29 4:01 ` Chen-Yu Tsai
2014-01-29 4:01 ` Chen-Yu Tsai
2014-01-17 6:47 ` [PATCH RFC 5/6] net: rfkill: gpio: add clock-frequency device tree property Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` [PATCH RFC 6/6] ARM: sun7i: cubietruck: enable bluetooth module Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 6:47 ` Chen-Yu Tsai
2014-01-17 20:26 ` [PATCH RFC 0/6] net: rfkill: gpio: Add device tree support Johannes Berg
2014-01-17 20:26 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401211950.07011.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.