Re: [PATCH 14/15] drm/i915: Track frontbuffer invalidation/flushing

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 14/15] drm/i915: Track frontbuffer invalidation/flushing
Date: Tue, 17 Jun 2014 07:49:30 +0100	[thread overview]
Message-ID: <20140617064930.GD17744@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1402941095-27879-15-git-send-email-daniel.vetter@ffwll.ch>

On Mon, Jun 16, 2014 at 07:51:34PM +0200, Daniel Vetter wrote:
> @@ -3966,6 +3971,8 @@ i915_gem_object_set_to_cpu_domain(struct drm_i915_gem_object *obj, bool write)
>  		obj->base.write_domain = I915_GEM_DOMAIN_CPU;
>  	}
>  
/* We do not need to explicitly invalidate the fb when moving to the
 * CPU domain as it is not coherent with the display. Therefore the user
 * much flush updates to the scanout through the frontbuffer whilst in
 * the CPU domain by explicitly flushing it - either by manually moving
 * to the GTT domain, or by calling sw-finish.
 */
> +	intel_fb_invalidate(obj, NULL);
And so kill this.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre