From: Richard Cochran <richardcochran@gmail.com>
To: Johannes Pointner <johannes.pointner@gmail.com>
Cc: Sekhar Nori <nsekhar@ti.com>, Vignesh R <vigneshr@ti.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Samuel Ortiz <sameo@linux.intel.com>, Felipe Balbi <balbi@ti.com>,
Brad Griffis <bgriffis@ti.com>,
Sanjeev Sharma <sanjeev_sharma@mentor.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Jan Kardell <jan.kardell@telliq.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-iio <linux-iio@vger.kernel.org>,
linux-input@vger.kernel.org,
Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save
Date: Fri, 21 Nov 2014 22:40:05 +0100 [thread overview]
Message-ID: <20141121214005.GA4020@localhost.localdomain> (raw)
In-Reply-To: <CAJKbBDD=eYmU=LuViwLPNV=kYCziDQgKjL07bT7og4vsj0Ee7A@mail.gmail.com>
On Fri, Nov 21, 2014 at 07:17:18PM +0100, Johannes Pointner wrote:
> Before the patches were also jumps but I thought it is something
> Vignesh should know. Maybe there is some fix for that too?
> As Richard also noted, it would be nice if ti could let us know how to
> get the delay values right. By trial and error is IMHO not the best
> way.
That is not only an opinion, it is a matter of fact. TI really dropped
the ball on this one. I thought the patch series was a sign they
finally were going to properly address this issue. Wrong again.
The data sheet for the TI part used to have a reference to an app-note
for the touch controller.
spruh73f page 1154
The Pen IRQ can only occur if the correct Pen Ctrl bits are high
(AFE Pen Ctrl bits 6:5 in the TSC_ADC control register) and if
the correct ground transistor biasing is set in the StepConfig
[N] Register. Refer to the application notes for the correct
settings.
I searched high and low for this application note. Then, the data
sheet got revised.
Thanks,
Richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: Johannes Pointner <johannes.pointner@gmail.com>
Cc: Sekhar Nori <nsekhar@ti.com>, Vignesh R <vigneshr@ti.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Samuel Ortiz <sameo@linux.intel.com>, Felipe Balbi <balbi@ti.com>,
Brad Griffis <bgriffis@ti.com>,
Sanjeev Sharma <sanjeev_sharma@mentor.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Jan Kardell <jan.kardell@telliq.com>,
devicetree@vger
Subject: Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save
Date: Fri, 21 Nov 2014 22:40:05 +0100 [thread overview]
Message-ID: <20141121214005.GA4020@localhost.localdomain> (raw)
In-Reply-To: <CAJKbBDD=eYmU=LuViwLPNV=kYCziDQgKjL07bT7og4vsj0Ee7A@mail.gmail.com>
On Fri, Nov 21, 2014 at 07:17:18PM +0100, Johannes Pointner wrote:
> Before the patches were also jumps but I thought it is something
> Vignesh should know. Maybe there is some fix for that too?
> As Richard also noted, it would be nice if ti could let us know how to
> get the delay values right. By trial and error is IMHO not the best
> way.
That is not only an opinion, it is a matter of fact. TI really dropped
the ball on this one. I thought the patch series was a sign they
finally were going to properly address this issue. Wrong again.
The data sheet for the TI part used to have a reference to an app-note
for the touch controller.
spruh73f page 1154
The Pen IRQ can only occur if the correct Pen Ctrl bits are high
(AFE Pen Ctrl bits 6:5 in the TSC_ADC control register) and if
the correct ground transistor biasing is set in the StepConfig
[N] Register. Refer to the application notes for the correct
settings.
I searched high and low for this application note. Then, the data
sheet got revised.
Thanks,
Richard
WARNING: multiple messages have this Message-ID (diff)
From: richardcochran@gmail.com (Richard Cochran)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save
Date: Fri, 21 Nov 2014 22:40:05 +0100 [thread overview]
Message-ID: <20141121214005.GA4020@localhost.localdomain> (raw)
In-Reply-To: <CAJKbBDD=eYmU=LuViwLPNV=kYCziDQgKjL07bT7og4vsj0Ee7A@mail.gmail.com>
On Fri, Nov 21, 2014 at 07:17:18PM +0100, Johannes Pointner wrote:
> Before the patches were also jumps but I thought it is something
> Vignesh should know. Maybe there is some fix for that too?
> As Richard also noted, it would be nice if ti could let us know how to
> get the delay values right. By trial and error is IMHO not the best
> way.
That is not only an opinion, it is a matter of fact. TI really dropped
the ball on this one. I thought the patch series was a sign they
finally were going to properly address this issue. Wrong again.
The data sheet for the TI part used to have a reference to an app-note
for the touch controller.
spruh73f page 1154
The Pen IRQ can only occur if the correct Pen Ctrl bits are high
(AFE Pen Ctrl bits 6:5 in the TSC_ADC control register) and if
the correct ground transistor biasing is set in the StepConfig
[N] Register. Refer to the application notes for the correct
settings.
I searched high and low for this application note. Then, the data
sheet got revised.
Thanks,
Richard
next prev parent reply other threads:[~2014-11-21 21:40 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 5:07 [PATCH v4 0/6] Touchscreen performance related fixes Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` [PATCH v4 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` [PATCH v4 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-15 19:27 ` Richard Cochran
2014-11-15 19:27 ` Richard Cochran
2014-11-15 19:27 ` Richard Cochran
2014-11-17 4:27 ` Vignesh R
2014-11-17 4:27 ` Vignesh R
2014-11-17 4:27 ` Vignesh R
2014-11-17 8:23 ` Richard Cochran
2014-11-17 8:23 ` Richard Cochran
2014-11-17 8:23 ` Richard Cochran
2014-11-17 12:18 ` Vignesh R
2014-11-17 12:18 ` Vignesh R
2014-11-17 12:18 ` Vignesh R
2014-11-14 5:07 ` [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-18 14:30 ` Lee Jones
2014-11-18 14:30 ` Lee Jones
2014-11-18 14:30 ` Lee Jones
2014-11-18 17:12 ` Dmitry Torokhov
2014-11-18 17:12 ` Dmitry Torokhov
2014-11-18 17:12 ` Dmitry Torokhov
2014-11-20 13:56 ` Sekhar Nori
2014-11-20 13:56 ` Sekhar Nori
2014-11-20 13:56 ` Sekhar Nori
2014-11-20 14:23 ` Griffis, Brad
2014-11-20 14:23 ` Griffis, Brad
2014-11-20 14:23 ` Griffis, Brad
2014-11-20 14:23 ` Griffis, Brad
2014-11-20 14:34 ` Richard Cochran
2014-11-20 14:34 ` Richard Cochran
2014-11-20 14:34 ` Richard Cochran
2014-11-20 14:34 ` Richard Cochran
2014-11-20 14:40 ` Richard Cochran
2014-11-20 14:40 ` Richard Cochran
2014-11-20 14:40 ` Richard Cochran
2014-11-21 12:10 ` Sekhar Nori
2014-11-21 12:10 ` Sekhar Nori
2014-11-21 12:10 ` Sekhar Nori
2014-11-21 13:10 ` Richard Cochran
2014-11-21 13:10 ` Richard Cochran
2014-11-21 13:10 ` Richard Cochran
2014-11-21 15:11 ` Johannes Pointner
2014-11-21 15:11 ` Johannes Pointner
2014-11-21 15:11 ` Johannes Pointner
2014-11-21 15:37 ` Sekhar Nori
2014-11-21 15:37 ` Sekhar Nori
2014-11-21 15:37 ` Sekhar Nori
2014-11-21 18:17 ` Johannes Pointner
2014-11-21 18:17 ` Johannes Pointner
2014-11-21 18:17 ` Johannes Pointner
2014-11-21 21:40 ` Richard Cochran [this message]
2014-11-21 21:40 ` Richard Cochran
2014-11-21 21:40 ` Richard Cochran
2014-11-21 22:25 ` Griffis, Brad
2014-11-21 22:25 ` Griffis, Brad
2014-11-21 22:25 ` Griffis, Brad
2014-11-21 22:25 ` Griffis, Brad
2014-11-24 8:32 ` Johannes Pointner
2014-11-24 8:32 ` Johannes Pointner
2014-11-24 8:32 ` Johannes Pointner
2014-11-24 8:32 ` Johannes Pointner
2014-11-24 8:57 ` Sebastian Andrzej Siewior
2014-11-24 8:57 ` Sebastian Andrzej Siewior
2014-11-24 8:57 ` Sebastian Andrzej Siewior
2014-11-24 10:01 ` Richard Cochran
2014-11-24 10:01 ` Richard Cochran
2014-11-24 10:01 ` Richard Cochran
2014-11-14 5:07 ` [PATCH v4 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 18:03 ` Tony Lindgren
2014-11-14 18:03 ` Tony Lindgren
2014-11-14 18:03 ` Tony Lindgren
2014-11-14 5:07 ` [PATCH v4 5/6] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` [PATCH v4 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-14 5:07 ` Vignesh R
2014-11-24 11:51 ` [PATCH v4 0/6] Touchscreen performance related fixes Sebastian Andrzej Siewior
2014-11-24 11:51 ` Sebastian Andrzej Siewior
2014-11-24 11:51 ` Sebastian Andrzej Siewior
2014-11-24 12:16 ` Vignesh R
2014-11-24 12:16 ` Vignesh R
2014-11-24 12:16 ` Vignesh R
2014-11-24 12:35 ` Sebastian Andrzej Siewior
2014-11-24 12:35 ` Sebastian Andrzej Siewior
2014-11-24 12:35 ` Sebastian Andrzej Siewior
2014-11-27 4:29 ` Vignesh R
2014-11-27 4:29 ` Vignesh R
2014-11-27 4:29 ` Vignesh R
2014-12-01 9:53 ` Vignesh R
2014-12-01 9:53 ` Vignesh R
2014-12-01 9:53 ` Vignesh R
2014-12-01 9:59 ` Sebastian Andrzej Siewior
2014-12-01 9:59 ` Sebastian Andrzej Siewior
2014-12-01 9:59 ` Sebastian Andrzej Siewior
2014-12-01 10:29 ` Vignesh R
2014-12-01 10:29 ` Vignesh R
2014-12-01 10:29 ` Vignesh R
2014-12-11 20:34 ` Nicolae Rosia
2014-12-11 20:34 ` Nicolae Rosia
2014-12-11 20:34 ` Nicolae Rosia
2014-12-11 20:40 ` Sebastian Andrzej Siewior
2014-12-11 20:40 ` Sebastian Andrzej Siewior
2014-12-11 20:40 ` Sebastian Andrzej Siewior
2014-12-12 13:48 ` Vignesh R
2014-12-12 13:48 ` Vignesh R
2014-12-12 13:48 ` Vignesh R
2014-12-12 13:55 ` Catalin Crenguta
2014-12-12 13:55 ` Catalin Crenguta
2014-12-12 13:55 ` Catalin Crenguta
2014-12-12 14:16 ` Griffis, Brad
2014-12-12 14:16 ` Griffis, Brad
2014-12-12 14:16 ` Griffis, Brad
2014-12-12 14:16 ` Griffis, Brad
2014-12-15 7:55 ` Catalin Crenguta
2014-12-15 7:55 ` Catalin Crenguta
2014-12-15 7:55 ` Catalin Crenguta
2014-12-15 7:55 ` Catalin Crenguta
2014-12-15 12:45 ` Catalin Crenguta
2014-12-15 12:45 ` Catalin Crenguta
2014-12-15 12:45 ` Catalin Crenguta
2014-12-15 12:45 ` Catalin Crenguta
2014-12-16 8:31 ` Catalin Crenguta
2014-12-16 8:31 ` Catalin Crenguta
2014-12-16 8:31 ` Catalin Crenguta
2014-12-16 8:31 ` Catalin Crenguta
2014-12-16 15:30 ` Richard Cochran
2014-12-16 15:30 ` Richard Cochran
2014-12-16 15:30 ` Richard Cochran
2014-12-16 15:30 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121214005.GA4020@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=bgriffis@ti.com \
--cc=bigeasy@linutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jan.kardell@telliq.com \
--cc=jic23@kernel.org \
--cc=johannes.pointner@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sanjeev_sharma@mentor.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.