All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Crenguta <catalin.crenguta@gmail.com>
To: "Griffis, Brad" <bgriffis@ti.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Nicolae Rosia <nicolae.rosia@gmail.com>,
	"R, Vignesh" <vigneshr@ti.com>, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Benoit Cousson <bcousson@baylibre.com>,
	Tony Lindgren <tony@atomide.com>,
	Russell King <linux@arm.linux.org.uk>,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	"richardcochran@gmail.com" <richardcochran@gmail.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Samuel Ortiz <sameo@linux.intel.com>,
	"Balbi, Felipe" <balbi@ti.com>,
	Sanjeev Sharma <sanjeev_sharma@mentor.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Jan Kardell <jan.kardell@telliq.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH v4 0/6] Touchscreen performance related fixes
Date: Mon, 15 Dec 2014 14:45:03 +0200	[thread overview]
Message-ID: <CABH3fy9f9oaV=PKTP+-tS9ADd8bD1oqO--SH0fh9LemqwdL3zA@mail.gmail.com> (raw)
In-Reply-To: <912A29987EAE174BA6CF187D7CDFA9CE26FA135A@DLEE08.ent.ti.com>

On Fri, Dec 12, 2014 at 4:16 PM, Griffis, Brad <bgriffis@ti.com> wrote:
> How are you configuring ti,charge-delay in your dts?  I've seen this behavior on some custom boards where we were using a smaller charge delay (0x400) to begin with, and by upping it to 0xb000 we resolved the issue.  These patches however already specified ti,charge-delay = 0xb000 by default so this would surprise me that it's still seeing that issue.  Was the touchscreen working as expected before these new patches, or does it have issues both ways?

I have created a DTS for Beaglebone Black with 4 wire touchscreen and
display which works on 3.18 stable and tsc-devel, omap2plus_defconfig
with tsc and tilcdc support.
It seems that with lcdc disabled, I am not getting false reports but
when I'm activating the lcdc, I get a lot of false pen-downs/pen-ups.
Even with tilcdc enabled, after it prints "timeout waiting for
framedone" and the screen get blanked (white), the noise is gone.

Regards,
Catalin.

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Crenguta <catalin.crenguta-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Griffis, Brad" <bgriffis-l0cyMroinI0@public.gmane.org>
Cc: Sebastian Andrzej Siewior
	<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Nicolae Rosia
	<nicolae.rosia-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"R, Vignesh" <vigneshr-l0cyMroinI0@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Benoit Cousson <bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
	"richardcochran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<richardcochran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
	Peter Meerwald <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
	Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"Balbi, Felipe" <balbi-l0cyMroinI0@public.gmane.org>,
	Sanjeev Sharma
	<sanjeev_sharma-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>,
	Paul Gortmaker
	<paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH v4 0/6] Touchscreen performance related fixes
Date: Mon, 15 Dec 2014 14:45:03 +0200	[thread overview]
Message-ID: <CABH3fy9f9oaV=PKTP+-tS9ADd8bD1oqO--SH0fh9LemqwdL3zA@mail.gmail.com> (raw)
In-Reply-To: <912A29987EAE174BA6CF187D7CDFA9CE26FA135A-YmePFLaaepqIQmiDNMet8wC/G2K4zDHf@public.gmane.org>

On Fri, Dec 12, 2014 at 4:16 PM, Griffis, Brad <bgriffis-l0cyMroinI0@public.gmane.org> wrote:
> How are you configuring ti,charge-delay in your dts?  I've seen this behavior on some custom boards where we were using a smaller charge delay (0x400) to begin with, and by upping it to 0xb000 we resolved the issue.  These patches however already specified ti,charge-delay = 0xb000 by default so this would surprise me that it's still seeing that issue.  Was the touchscreen working as expected before these new patches, or does it have issues both ways?

I have created a DTS for Beaglebone Black with 4 wire touchscreen and
display which works on 3.18 stable and tsc-devel, omap2plus_defconfig
with tsc and tilcdc support.
It seems that with lcdc disabled, I am not getting false reports but
when I'm activating the lcdc, I get a lot of false pen-downs/pen-ups.
Even with tilcdc enabled, after it prints "timeout waiting for
framedone" and the screen get blanked (white), the noise is gone.

Regards,
Catalin.

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Crenguta <catalin.crenguta@gmail.com>
To: "Griffis, Brad" <bgriffis@ti.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Nicolae Rosia <nicolae.rosia@gmail.com>,
	"R, Vignesh" <vigneshr@ti.com>, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Benoit Cousson <bcousson@baylibre.com>,
	Tony Lindgren <tony@atomide.com>,
	Russell King <linux@arm.linux.org.uk>,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	"richardcochran@gmail.com" <richardcochran@gmail.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Samuel Ortiz <sameo@linux.intel.com>,
	"Balbi, Felipe" <balbi@ti.com>,
	Sanjeev Sharma <sanjeev_sharma@mentor.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Jan Kardell <jan.kardell@telliq.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH v4 0/6] Touchscreen performance related fixes
Date: Mon, 15 Dec 2014 14:45:03 +0200	[thread overview]
Message-ID: <CABH3fy9f9oaV=PKTP+-tS9ADd8bD1oqO--SH0fh9LemqwdL3zA@mail.gmail.com> (raw)
In-Reply-To: <912A29987EAE174BA6CF187D7CDFA9CE26FA135A@DLEE08.ent.ti.com>

On Fri, Dec 12, 2014 at 4:16 PM, Griffis, Brad <bgriffis@ti.com> wrote:
> How are you configuring ti,charge-delay in your dts?  I've seen this beha=
vior on some custom boards where we were using a smaller charge delay (0x40=
0) to begin with, and by upping it to 0xb000 we resolved the issue.  These =
patches however already specified ti,charge-delay =3D 0xb000 by default so =
this would surprise me that it's still seeing that issue.  Was the touchscr=
een working as expected before these new patches, or does it have issues bo=
th ways?

I have created a DTS for Beaglebone Black with 4 wire touchscreen and
display which works on 3.18 stable and tsc-devel, omap2plus_defconfig
with tsc and tilcdc support.
It seems that with lcdc disabled, I am not getting false reports but
when I'm activating the lcdc, I get a lot of false pen-downs/pen-ups.
Even with tilcdc enabled, after it prints "timeout waiting for
framedone" and the screen get blanked (white), the noise is gone.

Regards,
Catalin.

WARNING: multiple messages have this Message-ID (diff)
From: catalin.crenguta@gmail.com (Catalin Crenguta)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/6] Touchscreen performance related fixes
Date: Mon, 15 Dec 2014 14:45:03 +0200	[thread overview]
Message-ID: <CABH3fy9f9oaV=PKTP+-tS9ADd8bD1oqO--SH0fh9LemqwdL3zA@mail.gmail.com> (raw)
In-Reply-To: <912A29987EAE174BA6CF187D7CDFA9CE26FA135A@DLEE08.ent.ti.com>

On Fri, Dec 12, 2014 at 4:16 PM, Griffis, Brad <bgriffis@ti.com> wrote:
> How are you configuring ti,charge-delay in your dts?  I've seen this behavior on some custom boards where we were using a smaller charge delay (0x400) to begin with, and by upping it to 0xb000 we resolved the issue.  These patches however already specified ti,charge-delay = 0xb000 by default so this would surprise me that it's still seeing that issue.  Was the touchscreen working as expected before these new patches, or does it have issues both ways?

I have created a DTS for Beaglebone Black with 4 wire touchscreen and
display which works on 3.18 stable and tsc-devel, omap2plus_defconfig
with tsc and tilcdc support.
It seems that with lcdc disabled, I am not getting false reports but
when I'm activating the lcdc, I get a lot of false pen-downs/pen-ups.
Even with tilcdc enabled, after it prints "timeout waiting for
framedone" and the screen get blanked (white), the noise is gone.

Regards,
Catalin.

  parent reply	other threads:[~2014-12-15 12:45 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14  5:07 [PATCH v4 0/6] Touchscreen performance related fixes Vignesh R
2014-11-14  5:07 ` Vignesh R
2014-11-14  5:07 ` Vignesh R
2014-11-14  5:07 ` [PATCH v4 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps Vignesh R
2014-11-14  5:07   ` Vignesh R
2014-11-14  5:07   ` Vignesh R
2014-11-14  5:07 ` [PATCH v4 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R
2014-11-14  5:07   ` Vignesh R
2014-11-14  5:07   ` Vignesh R
2014-11-15 19:27   ` Richard Cochran
2014-11-15 19:27     ` Richard Cochran
2014-11-15 19:27     ` Richard Cochran
2014-11-17  4:27     ` Vignesh R
2014-11-17  4:27       ` Vignesh R
2014-11-17  4:27       ` Vignesh R
2014-11-17  8:23       ` Richard Cochran
2014-11-17  8:23         ` Richard Cochran
2014-11-17  8:23         ` Richard Cochran
2014-11-17 12:18         ` Vignesh R
2014-11-17 12:18           ` Vignesh R
2014-11-17 12:18           ` Vignesh R
2014-11-14  5:07 ` [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save Vignesh R
2014-11-14  5:07   ` Vignesh R
2014-11-14  5:07   ` Vignesh R
2014-11-18 14:30   ` Lee Jones
2014-11-18 14:30     ` Lee Jones
2014-11-18 14:30     ` Lee Jones
2014-11-18 17:12     ` Dmitry Torokhov
2014-11-18 17:12       ` Dmitry Torokhov
2014-11-18 17:12       ` Dmitry Torokhov
2014-11-20 13:56       ` Sekhar Nori
2014-11-20 13:56         ` Sekhar Nori
2014-11-20 13:56         ` Sekhar Nori
2014-11-20 14:23         ` Griffis, Brad
2014-11-20 14:23           ` Griffis, Brad
2014-11-20 14:23           ` Griffis, Brad
2014-11-20 14:23           ` Griffis, Brad
2014-11-20 14:34           ` Richard Cochran
2014-11-20 14:34             ` Richard Cochran
2014-11-20 14:34             ` Richard Cochran
2014-11-20 14:34             ` Richard Cochran
2014-11-20 14:40         ` Richard Cochran
2014-11-20 14:40           ` Richard Cochran
2014-11-20 14:40           ` Richard Cochran
2014-11-21 12:10           ` Sekhar Nori
2014-11-21 12:10             ` Sekhar Nori
2014-11-21 12:10             ` Sekhar Nori
2014-11-21 13:10             ` Richard Cochran
2014-11-21 13:10               ` Richard Cochran
2014-11-21 13:10               ` Richard Cochran
2014-11-21 15:11               ` Johannes Pointner
2014-11-21 15:11                 ` Johannes Pointner
2014-11-21 15:11                 ` Johannes Pointner
2014-11-21 15:37                 ` Sekhar Nori
2014-11-21 15:37                   ` Sekhar Nori
2014-11-21 15:37                   ` Sekhar Nori
2014-11-21 18:17                   ` Johannes Pointner
2014-11-21 18:17                     ` Johannes Pointner
2014-11-21 18:17                     ` Johannes Pointner
2014-11-21 21:40                     ` Richard Cochran
2014-11-21 21:40                       ` Richard Cochran
2014-11-21 21:40                       ` Richard Cochran
2014-11-21 22:25                       ` Griffis, Brad
2014-11-21 22:25                         ` Griffis, Brad
2014-11-21 22:25                         ` Griffis, Brad
2014-11-21 22:25                         ` Griffis, Brad
2014-11-24  8:32                         ` Johannes Pointner
2014-11-24  8:32                           ` Johannes Pointner
2014-11-24  8:32                           ` Johannes Pointner
2014-11-24  8:32                           ` Johannes Pointner
2014-11-24  8:57               ` Sebastian Andrzej Siewior
2014-11-24  8:57                 ` Sebastian Andrzej Siewior
2014-11-24  8:57                 ` Sebastian Andrzej Siewior
2014-11-24 10:01                 ` Richard Cochran
2014-11-24 10:01                   ` Richard Cochran
2014-11-24 10:01                   ` Richard Cochran
2014-11-14  5:07 ` [PATCH v4 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC Vignesh R
2014-11-14  5:07   ` Vignesh R
2014-11-14  5:07   ` Vignesh R
2014-11-14 18:03   ` Tony Lindgren
2014-11-14 18:03     ` Tony Lindgren
2014-11-14 18:03     ` Tony Lindgren
2014-11-14  5:07 ` [PATCH v4 5/6] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter Vignesh R
2014-11-14  5:07   ` Vignesh R
2014-11-14  5:07   ` Vignesh R
2014-11-14  5:07 ` [PATCH v4 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering Vignesh R
2014-11-14  5:07   ` Vignesh R
2014-11-14  5:07   ` Vignesh R
2014-11-24 11:51 ` [PATCH v4 0/6] Touchscreen performance related fixes Sebastian Andrzej Siewior
2014-11-24 11:51   ` Sebastian Andrzej Siewior
2014-11-24 11:51   ` Sebastian Andrzej Siewior
2014-11-24 12:16   ` Vignesh R
2014-11-24 12:16     ` Vignesh R
2014-11-24 12:16     ` Vignesh R
2014-11-24 12:35     ` Sebastian Andrzej Siewior
2014-11-24 12:35       ` Sebastian Andrzej Siewior
2014-11-24 12:35       ` Sebastian Andrzej Siewior
2014-11-27  4:29       ` Vignesh R
2014-11-27  4:29         ` Vignesh R
2014-11-27  4:29         ` Vignesh R
2014-12-01  9:53   ` Vignesh R
2014-12-01  9:53     ` Vignesh R
2014-12-01  9:53     ` Vignesh R
2014-12-01  9:59     ` Sebastian Andrzej Siewior
2014-12-01  9:59       ` Sebastian Andrzej Siewior
2014-12-01  9:59       ` Sebastian Andrzej Siewior
2014-12-01 10:29       ` Vignesh R
2014-12-01 10:29         ` Vignesh R
2014-12-01 10:29         ` Vignesh R
2014-12-11 20:34         ` Nicolae Rosia
2014-12-11 20:34           ` Nicolae Rosia
2014-12-11 20:34           ` Nicolae Rosia
2014-12-11 20:40           ` Sebastian Andrzej Siewior
2014-12-11 20:40             ` Sebastian Andrzej Siewior
2014-12-11 20:40             ` Sebastian Andrzej Siewior
2014-12-12 13:48             ` Vignesh R
2014-12-12 13:48               ` Vignesh R
2014-12-12 13:48               ` Vignesh R
2014-12-12 13:55             ` Catalin Crenguta
2014-12-12 13:55               ` Catalin Crenguta
2014-12-12 13:55               ` Catalin Crenguta
2014-12-12 14:16               ` Griffis, Brad
2014-12-12 14:16                 ` Griffis, Brad
2014-12-12 14:16                 ` Griffis, Brad
2014-12-12 14:16                 ` Griffis, Brad
2014-12-15  7:55                 ` Catalin Crenguta
2014-12-15  7:55                   ` Catalin Crenguta
2014-12-15  7:55                   ` Catalin Crenguta
2014-12-15  7:55                   ` Catalin Crenguta
2014-12-15 12:45                 ` Catalin Crenguta [this message]
2014-12-15 12:45                   ` Catalin Crenguta
2014-12-15 12:45                   ` Catalin Crenguta
2014-12-15 12:45                   ` Catalin Crenguta
2014-12-16  8:31                 ` Catalin Crenguta
2014-12-16  8:31                   ` Catalin Crenguta
2014-12-16  8:31                   ` Catalin Crenguta
2014-12-16  8:31                   ` Catalin Crenguta
2014-12-16 15:30                   ` Richard Cochran
2014-12-16 15:30                     ` Richard Cochran
2014-12-16 15:30                     ` Richard Cochran
2014-12-16 15:30                     ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABH3fy9f9oaV=PKTP+-tS9ADd8bD1oqO--SH0fh9LemqwdL3zA@mail.gmail.com' \
    --to=catalin.crenguta@gmail.com \
    --cc=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=bgriffis@ti.com \
    --cc=bigeasy@linutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jan.kardell@telliq.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=nicolae.rosia@gmail.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=pawel.moll@arm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=sanjeev_sharma@mentor.com \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.