From: Lukasz Majewski <l.majewski@majess.pl>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Lukasz Majewski <l.majewski@samsung.com>,
Eduardo Valentin <edubezval@gmail.com>,
Kamil Debski <k.debski@samsung.com>,
Jean Delvare <jdelvare@suse.de>, Kukjin Kim <kgene@kernel.org>,
lm-sensors@lm-sensors.org,
Linux PM list <linux-pm@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
devicetree@vger.kernel.org, Kukjin Kim <kgene.kim@samsung.com>,
linux-kernel@vger.kernel.org,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Abhilash Kesavan <kesavan.abhilash@gmail.com>,
Abhilash Kesavan <a.kesavan@samsung.com>
Subject: Re: [PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle
Date: Sun, 8 Feb 2015 21:52:43 +0100 [thread overview]
Message-ID: <20150208215243.22085c97@jawa> (raw)
In-Reply-To: <20150206182725.GA25410@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 2835 bytes --]
On Fri, 6 Feb 2015 10:27:25 -0800
Guenter Roeck <linux@roeck-us.net> wrote:
> On Fri, Feb 06, 2015 at 05:59:06PM +0100, Lukasz Majewski wrote:
> > It was necessary to decouple code handling writing to sysfs from
> > the one responsible for setting PWM of the fan.
> > Due to that, new __set_pwm() method was extracted, which is
> > responsible for only setting new PWM duty cycle.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > ---
> > Changes for v2:
> > - None
> > Changes for v3:
> > - The commit headline has been reedited.
> > ---
> > drivers/hwmon/pwm-fan.c | 35 ++++++++++++++++++++++-------------
> > 1 file changed, 22 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
> > index 1991d903..870e100 100644
> > --- a/drivers/hwmon/pwm-fan.c
> > +++ b/drivers/hwmon/pwm-fan.c
> > @@ -33,21 +33,15 @@ struct pwm_fan_ctx {
> > unsigned char pwm_value;
> > };
> >
> > -static ssize_t set_pwm(struct device *dev, struct device_attribute
> > *attr,
> > - const char *buf, size_t count)
> > +static int __set_pwm(struct pwm_fan_ctx *ctx, unsigned long pwm)
> > {
> > - struct pwm_fan_ctx *ctx = dev_get_drvdata(dev);
> > - unsigned long pwm, duty;
> > - ssize_t ret;
> > -
> > - if (kstrtoul(buf, 10, &pwm) || pwm > MAX_PWM)
> > - return -EINVAL;
> > -
> > - mutex_lock(&ctx->lock);
> > + unsigned long duty;
> > + int ret;
> >
> > if (ctx->pwm_value == pwm)
> > - goto exit_set_pwm_no_change;
> > + return 0;
> >
> Why did you move this check outside the lock ? With this change there
> is no guarantee that pwm_value wasn't changed while waiting for the
> lock.
Grrr. You are obviously right here. I will fix this. Thanks for spotting
Best regards,
Lukasz Majewski
>
> Guenter
>
> > + mutex_lock(&ctx->lock);
> > if (pwm == 0) {
> > pwm_disable(ctx->pwm);
> > goto exit_set_pwm;
> > @@ -66,13 +60,28 @@ static ssize_t set_pwm(struct device *dev,
> > struct device_attribute *attr,
> > exit_set_pwm:
> > ctx->pwm_value = pwm;
> > -exit_set_pwm_no_change:
> > - ret = count;
> > exit_set_pwm_err:
> > mutex_unlock(&ctx->lock);
> > return ret;
> > }
> >
> > +static ssize_t set_pwm(struct device *dev, struct device_attribute
> > *attr,
> > + const char *buf, size_t count)
> > +{
> > + struct pwm_fan_ctx *ctx = dev_get_drvdata(dev);
> > + unsigned long pwm;
> > + int ret;
> > +
> > + if (kstrtoul(buf, 10, &pwm) || pwm > MAX_PWM)
> > + return -EINVAL;
> > +
> > + ret = __set_pwm(ctx, pwm);
> > + if (ret)
> > + return ret;
> > +
> > + return count;
> > +}
> > +
> > static ssize_t show_pwm(struct device *dev,
> > struct device_attribute *attr, char *buf)
> > {
> > --
> > 2.0.0.rc2
> >
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Majewski <l.majewski@majess.pl>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Lukasz Majewski <l.majewski@samsung.com>,
Eduardo Valentin <edubezval@gmail.com>,
Kamil Debski <k.debski@samsung.com>,
Jean Delvare <jdelvare@suse.de>, Kukjin Kim <kgene@kernel.org>,
lm-sensors@lm-sensors.org,
Linux PM list <linux-pm@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
devicetree@vger.kernel.org, Kukjin Kim <kgene.kim@samsung.com>,
linux-kernel@vger.kernel.org,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Abhilash Kesavan <kesavan.abhilash@gmail.com>,
Abhilash Kesavan <a.kesavan@samsung.com>
Subject: Re: [lm-sensors] [PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty
Date: Sun, 08 Feb 2015 20:52:43 +0000 [thread overview]
Message-ID: <20150208215243.22085c97@jawa> (raw)
In-Reply-To: <20150206182725.GA25410@roeck-us.net>
[-- Attachment #1.1: Type: text/plain, Size: 2835 bytes --]
On Fri, 6 Feb 2015 10:27:25 -0800
Guenter Roeck <linux@roeck-us.net> wrote:
> On Fri, Feb 06, 2015 at 05:59:06PM +0100, Lukasz Majewski wrote:
> > It was necessary to decouple code handling writing to sysfs from
> > the one responsible for setting PWM of the fan.
> > Due to that, new __set_pwm() method was extracted, which is
> > responsible for only setting new PWM duty cycle.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > ---
> > Changes for v2:
> > - None
> > Changes for v3:
> > - The commit headline has been reedited.
> > ---
> > drivers/hwmon/pwm-fan.c | 35 ++++++++++++++++++++++-------------
> > 1 file changed, 22 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
> > index 1991d903..870e100 100644
> > --- a/drivers/hwmon/pwm-fan.c
> > +++ b/drivers/hwmon/pwm-fan.c
> > @@ -33,21 +33,15 @@ struct pwm_fan_ctx {
> > unsigned char pwm_value;
> > };
> >
> > -static ssize_t set_pwm(struct device *dev, struct device_attribute
> > *attr,
> > - const char *buf, size_t count)
> > +static int __set_pwm(struct pwm_fan_ctx *ctx, unsigned long pwm)
> > {
> > - struct pwm_fan_ctx *ctx = dev_get_drvdata(dev);
> > - unsigned long pwm, duty;
> > - ssize_t ret;
> > -
> > - if (kstrtoul(buf, 10, &pwm) || pwm > MAX_PWM)
> > - return -EINVAL;
> > -
> > - mutex_lock(&ctx->lock);
> > + unsigned long duty;
> > + int ret;
> >
> > if (ctx->pwm_value == pwm)
> > - goto exit_set_pwm_no_change;
> > + return 0;
> >
> Why did you move this check outside the lock ? With this change there
> is no guarantee that pwm_value wasn't changed while waiting for the
> lock.
Grrr. You are obviously right here. I will fix this. Thanks for spotting
Best regards,
Lukasz Majewski
>
> Guenter
>
> > + mutex_lock(&ctx->lock);
> > if (pwm == 0) {
> > pwm_disable(ctx->pwm);
> > goto exit_set_pwm;
> > @@ -66,13 +60,28 @@ static ssize_t set_pwm(struct device *dev,
> > struct device_attribute *attr,
> > exit_set_pwm:
> > ctx->pwm_value = pwm;
> > -exit_set_pwm_no_change:
> > - ret = count;
> > exit_set_pwm_err:
> > mutex_unlock(&ctx->lock);
> > return ret;
> > }
> >
> > +static ssize_t set_pwm(struct device *dev, struct device_attribute
> > *attr,
> > + const char *buf, size_t count)
> > +{
> > + struct pwm_fan_ctx *ctx = dev_get_drvdata(dev);
> > + unsigned long pwm;
> > + int ret;
> > +
> > + if (kstrtoul(buf, 10, &pwm) || pwm > MAX_PWM)
> > + return -EINVAL;
> > +
> > + ret = __set_pwm(ctx, pwm);
> > + if (ret)
> > + return ret;
> > +
> > + return count;
> > +}
> > +
> > static ssize_t show_pwm(struct device *dev,
> > struct device_attribute *attr, char *buf)
> > {
> > --
> > 2.0.0.rc2
> >
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2015-02-09 0:32 UTC|newest]
Thread overview: 329+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 10:13 [PATCH 0/9] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2014-12-18 10:13 ` [lm-sensors] " Lukasz Majewski
2014-12-18 10:13 ` Lukasz Majewski
2014-12-18 10:13 ` [PATCH 1/9] thermal: Provide stub for thermal_of_cooling_device_register() function Lukasz Majewski
2014-12-18 10:13 ` [lm-sensors] " Lukasz Majewski
2014-12-18 10:13 ` Lukasz Majewski
2014-12-18 10:13 ` [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Lukasz Majewski
2014-12-18 10:13 ` [lm-sensors] [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling dev Lukasz Majewski
2014-12-18 10:13 ` [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Lukasz Majewski
2014-12-18 10:42 ` Sjoerd Simons
2014-12-18 10:42 ` [lm-sensors] [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling Sjoerd Simons
2014-12-18 10:42 ` [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Sjoerd Simons
2014-12-19 15:32 ` Lukasz Majewski
2014-12-19 15:32 ` [lm-sensors] [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling Lukasz Majewski
2014-12-19 15:32 ` [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Lukasz Majewski
2014-12-19 16:02 ` Guenter Roeck
2014-12-19 16:02 ` [lm-sensors] [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling Guenter Roeck
2014-12-19 16:02 ` [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Guenter Roeck
2014-12-19 16:13 ` Lukasz Majewski
2014-12-19 16:13 ` [lm-sensors] [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling Lukasz Majewski
2014-12-19 16:13 ` [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-01-05 10:50 ` Sjoerd Simons
2015-01-05 10:50 ` [lm-sensors] [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling Sjoerd Simons
2015-01-05 10:50 ` [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Sjoerd Simons
2015-01-14 13:56 ` Lukasz Majewski
2015-01-14 13:56 ` [lm-sensors] [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling Lukasz Majewski
2015-01-14 13:56 ` [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-01-15 8:57 ` Sjoerd Simons
2015-01-15 8:57 ` [lm-sensors] [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling Sjoerd Simons
2015-01-15 8:57 ` [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Sjoerd Simons
2014-12-18 14:27 ` Guenter Roeck
2014-12-18 14:27 ` [lm-sensors] [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling Guenter Roeck
2014-12-18 14:27 ` [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Guenter Roeck
2014-12-19 16:25 ` Lukasz Majewski
2014-12-19 16:25 ` [lm-sensors] [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling Lukasz Majewski
2014-12-19 16:25 ` [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Lukasz Majewski
2014-12-18 10:13 ` [PATCH 3/9] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2014-12-18 10:13 ` [lm-sensors] " Lukasz Majewski
2014-12-18 10:13 ` Lukasz Majewski
2014-12-18 10:13 ` [PATCH 4/9] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2014-12-18 10:13 ` [lm-sensors] [PATCH 4/9] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooling devi Lukasz Majewski
2014-12-18 10:13 ` [PATCH 4/9] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2014-12-18 10:13 ` [PATCH 5/9] hwmon: thermal: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2014-12-18 10:13 ` [lm-sensors] " Lukasz Majewski
2014-12-18 10:13 ` Lukasz Majewski
2014-12-18 10:13 ` [PATCH 6/9] hwmon: thermal: Read PWM FAN configuration from device tree Lukasz Majewski
2014-12-18 10:13 ` [lm-sensors] " Lukasz Majewski
2014-12-18 10:13 ` Lukasz Majewski
2014-12-18 10:13 ` [PATCH 7/9] hwmon: thermal: Code for using PWM FAN as a cooling device Lukasz Majewski
2014-12-18 10:13 ` [lm-sensors] " Lukasz Majewski
2014-12-18 10:13 ` Lukasz Majewski
2014-12-18 10:13 ` [PATCH 8/9] hwmon: thermal: Provide 'default-pulse-width' property to setup FAN on boot Lukasz Majewski
2014-12-18 10:13 ` [lm-sensors] " Lukasz Majewski
2014-12-18 10:13 ` Lukasz Majewski
2014-12-18 10:13 ` [PATCH 9/9] hwmon: thermal: dts: Disable FAN on boot on the Odroid U3 Lukasz Majewski
2014-12-18 10:13 ` [lm-sensors] " Lukasz Majewski
2014-12-18 10:13 ` Lukasz Majewski
2014-12-22 16:27 ` [PATCH v2 0/8] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2014-12-22 16:27 ` [lm-sensors] " Lukasz Majewski
2014-12-22 16:27 ` Lukasz Majewski
2014-12-22 16:27 ` [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Lukasz Majewski
2014-12-22 16:27 ` [lm-sensors] " Lukasz Majewski
2014-12-22 16:27 ` Lukasz Majewski
2015-01-02 18:54 ` Eduardo Valentin
2015-01-02 18:54 ` [lm-sensors] [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() funct Eduardo Valentin
2015-01-02 18:54 ` [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Eduardo Valentin
2015-01-02 19:03 ` Eduardo Valentin
2015-01-02 19:03 ` [lm-sensors] [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() funct Eduardo Valentin
2015-01-02 19:03 ` [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Eduardo Valentin
2015-01-14 15:01 ` Lukasz Majewski
2015-01-14 15:01 ` [lm-sensors] [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() funct Lukasz Majewski
2015-01-14 15:01 ` [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Lukasz Majewski
2015-01-14 18:32 ` Eduardo Valentin
2015-01-14 18:32 ` [lm-sensors] [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() funct Eduardo Valentin
2015-01-14 18:32 ` [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Eduardo Valentin
2015-01-15 8:43 ` Lukasz Majewski
2015-01-15 8:43 ` [lm-sensors] [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() funct Lukasz Majewski
2015-01-15 8:43 ` [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Lukasz Majewski
2014-12-22 16:27 ` [PATCH v2 2/8] thermal: Provide stub for thermal_cdev_update() function Lukasz Majewski
2014-12-22 16:27 ` [lm-sensors] " Lukasz Majewski
2014-12-22 16:27 ` Lukasz Majewski
2015-01-02 18:40 ` Eduardo Valentin
2015-01-02 18:40 ` [lm-sensors] " Eduardo Valentin
2015-01-02 18:40 ` Eduardo Valentin
2015-01-14 15:07 ` Lukasz Majewski
2015-01-14 15:07 ` [lm-sensors] " Lukasz Majewski
2015-01-14 15:07 ` Lukasz Majewski
2015-01-14 18:28 ` Eduardo Valentin
2015-01-14 18:28 ` [lm-sensors] " Eduardo Valentin
2015-01-14 18:28 ` Eduardo Valentin
2014-12-22 16:27 ` [PATCH v2 3/8] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Lukasz Majewski
2014-12-22 16:27 ` [lm-sensors] [PATCH v2 3/8] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling Lukasz Majewski
2014-12-22 16:27 ` [PATCH v2 3/8] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-01-02 18:51 ` Eduardo Valentin
2015-01-02 18:51 ` [lm-sensors] [PATCH v2 3/8] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cool Eduardo Valentin
2015-01-02 18:51 ` [PATCH v2 3/8] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Eduardo Valentin
2014-12-22 16:27 ` [PATCH v2 4/8] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2014-12-22 16:27 ` [lm-sensors] " Lukasz Majewski
2014-12-22 16:27 ` Lukasz Majewski
2014-12-22 16:27 ` [PATCH v2 5/8] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2014-12-22 16:27 ` [lm-sensors] [PATCH v2 5/8] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooling d Lukasz Majewski
2014-12-22 16:27 ` [PATCH v2 5/8] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-01-02 18:52 ` Eduardo Valentin
2015-01-02 18:52 ` [lm-sensors] [PATCH v2 5/8] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooli Eduardo Valentin
2015-01-02 18:52 ` [PATCH v2 5/8] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Eduardo Valentin
2014-12-22 16:27 ` [PATCH v2 6/8] hwmon: thermal: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2014-12-22 16:27 ` [lm-sensors] [PATCH v2 6/8] hwmon: thermal: Extract __set_pwm() function to only modify PWM duty cyc Lukasz Majewski
2014-12-22 16:27 ` [PATCH v2 6/8] hwmon: thermal: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2014-12-29 12:52 ` Guenter Roeck
2014-12-29 12:52 ` [lm-sensors] [PATCH v2 6/8] hwmon: thermal: Extract __set_pwm() function to only modify PWM duty Guenter Roeck
2014-12-29 12:52 ` [PATCH v2 6/8] hwmon: thermal: Extract __set_pwm() function to only modify PWM duty cycle Guenter Roeck
2014-12-22 16:27 ` [PATCH v2 7/8] hwmon: thermal: Read PWM FAN configuration from device tree Lukasz Majewski
2014-12-22 16:27 ` [lm-sensors] " Lukasz Majewski
2014-12-22 16:27 ` Lukasz Majewski
2014-12-29 12:50 ` Guenter Roeck
2014-12-29 12:50 ` [lm-sensors] " Guenter Roeck
2014-12-29 12:50 ` Guenter Roeck
2014-12-22 16:27 ` [PATCH v2 8/8] hwmon: thermal: Code for using PWM FAN as a cooling device Lukasz Majewski
2014-12-22 16:27 ` [lm-sensors] " Lukasz Majewski
2014-12-22 16:27 ` Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 0/8] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2015-02-06 16:59 ` [lm-sensors] " Lukasz Majewski
2015-02-06 16:59 ` Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Lukasz Majewski
2015-02-06 16:59 ` [lm-sensors] " Lukasz Majewski
2015-02-06 16:59 ` Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 2/8] thermal: Provide stub for thermal_cdev_update() function Lukasz Majewski
2015-02-06 16:59 ` [lm-sensors] " Lukasz Majewski
2015-02-06 16:59 ` Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-02-06 16:59 ` [lm-sensors] [PATCH v3 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 4/8] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2015-02-06 16:59 ` [lm-sensors] " Lukasz Majewski
2015-02-06 16:59 ` Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-06 16:59 ` [lm-sensors] [PATCH v3 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Od Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-06 16:59 ` [lm-sensors] [PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cyc Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-06 18:27 ` Guenter Roeck
2015-02-06 18:27 ` [lm-sensors] [PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty Guenter Roeck
2015-02-06 18:27 ` [PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Guenter Roeck
2015-02-08 20:52 ` Lukasz Majewski [this message]
2015-02-08 20:52 ` [lm-sensors] [PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty Lukasz Majewski
2015-02-08 20:52 ` [PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree Lukasz Majewski
2015-02-06 16:59 ` [lm-sensors] " Lukasz Majewski
2015-02-06 16:59 ` Lukasz Majewski
2015-02-06 18:36 ` Guenter Roeck
2015-02-06 18:36 ` [lm-sensors] " Guenter Roeck
2015-02-06 18:36 ` Guenter Roeck
2015-02-08 21:36 ` Lukasz Majewski
2015-02-08 21:36 ` [lm-sensors] " Lukasz Majewski
2015-02-08 21:36 ` Lukasz Majewski
2015-02-09 4:40 ` Guenter Roeck
2015-02-09 4:40 ` [lm-sensors] " Guenter Roeck
2015-02-09 4:40 ` Guenter Roeck
2015-02-06 16:59 ` [PATCH v3 8/8] hwmon: pwm-fan: Code for using PWM FAN as a cooling device Lukasz Majewski
2015-02-06 16:59 ` [lm-sensors] " Lukasz Majewski
2015-02-06 16:59 ` Lukasz Majewski
2015-02-18 10:07 ` [PATCH v4 0/8] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2015-02-18 10:07 ` [lm-sensors] " Lukasz Majewski
2015-02-18 10:07 ` Lukasz Majewski
2015-02-18 10:07 ` [PATCH v4 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Lukasz Majewski
2015-02-18 10:07 ` [lm-sensors] " Lukasz Majewski
2015-02-18 10:07 ` Lukasz Majewski
2015-02-24 19:21 ` Eduardo Valentin
2015-02-24 19:21 ` [lm-sensors] [PATCH v4 1/8] thermal: Provide stub for thermal_of_cooling_device_register() funct Eduardo Valentin
2015-02-24 19:21 ` [PATCH v4 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Eduardo Valentin
2015-02-25 12:26 ` Lukasz Majewski
2015-02-25 12:26 ` [lm-sensors] [PATCH v4 1/8] thermal: Provide stub for thermal_of_cooling_device_register() funct Lukasz Majewski
2015-02-25 12:26 ` [PATCH v4 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Lukasz Majewski
2015-02-18 10:07 ` [PATCH v4 2/8] thermal: Provide stub for thermal_cdev_update() function Lukasz Majewski
2015-02-18 10:07 ` [lm-sensors] " Lukasz Majewski
2015-02-18 10:07 ` Lukasz Majewski
2015-02-24 19:21 ` Eduardo Valentin
2015-02-24 19:21 ` [lm-sensors] " Eduardo Valentin
2015-02-24 19:21 ` Eduardo Valentin
2015-02-18 10:07 ` [PATCH v4 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-02-18 10:07 ` [lm-sensors] [PATCH v4 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as Lukasz Majewski
2015-02-18 10:07 ` [PATCH v4 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-02-24 19:25 ` Eduardo Valentin
2015-02-24 19:25 ` [lm-sensors] [PATCH v4 3/8] Documentation: dts: Documentation entry to explain how to use PWM FA Eduardo Valentin
2015-02-24 19:25 ` [PATCH v4 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Eduardo Valentin
2015-02-18 10:07 ` [PATCH v4 4/8] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2015-02-18 10:07 ` [lm-sensors] " Lukasz Majewski
2015-02-18 10:07 ` Lukasz Majewski
2015-02-18 13:16 ` Andreas Färber
2015-02-18 13:16 ` [lm-sensors] " Andreas Färber
2015-02-18 13:16 ` Andreas Färber
2015-02-18 10:07 ` [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-18 10:07 ` [lm-sensors] [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Od Lukasz Majewski
2015-02-18 10:07 ` [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-24 19:37 ` Eduardo Valentin
2015-02-24 19:37 ` [lm-sensors] [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device i Eduardo Valentin
2015-02-24 19:37 ` [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Eduardo Valentin
2015-02-25 13:28 ` Lukasz Majewski
2015-02-25 13:28 ` [lm-sensors] [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device i Lukasz Majewski
2015-02-25 13:28 ` [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-25 18:30 ` Eduardo Valentin
2015-02-25 18:30 ` [lm-sensors] [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device i Eduardo Valentin
2015-02-25 18:30 ` [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Eduardo Valentin
2015-02-18 10:07 ` [PATCH v4 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-18 10:07 ` [lm-sensors] [PATCH v4 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cyc Lukasz Majewski
2015-02-18 10:07 ` [PATCH v4 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-18 10:07 ` [PATCH v4 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree Lukasz Majewski
2015-02-18 10:07 ` [lm-sensors] " Lukasz Majewski
2015-02-18 10:07 ` Lukasz Majewski
2015-02-21 0:26 ` Guenter Roeck
2015-02-21 0:26 ` [lm-sensors] " Guenter Roeck
2015-02-21 0:26 ` Guenter Roeck
2015-02-23 16:13 ` Lukasz Majewski
2015-02-23 16:13 ` [lm-sensors] " Lukasz Majewski
2015-02-23 16:13 ` Lukasz Majewski
2015-02-23 16:23 ` Guenter Roeck
2015-02-23 16:23 ` [lm-sensors] " Guenter Roeck
2015-02-23 16:23 ` Guenter Roeck
2015-02-23 16:51 ` Lukasz Majewski
2015-02-23 16:51 ` [lm-sensors] " Lukasz Majewski
2015-02-23 16:51 ` Lukasz Majewski
2015-02-23 16:59 ` Guenter Roeck
2015-02-23 16:59 ` [lm-sensors] " Guenter Roeck
2015-02-23 16:59 ` Guenter Roeck
2015-02-18 10:07 ` [PATCH v4 8/8] hwmon: pwm-fan: Code for using PWM FAN as a cooling device Lukasz Majewski
2015-02-18 10:07 ` [lm-sensors] " Lukasz Majewski
2015-02-18 10:07 ` Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2015-02-25 15:34 ` [lm-sensors] " Lukasz Majewski
2015-02-25 15:34 ` Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-02-25 15:34 ` [lm-sensors] [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-02-25 19:11 ` Eduardo Valentin
2015-02-25 19:11 ` [lm-sensors] [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FA Eduardo Valentin
2015-02-25 19:11 ` [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Eduardo Valentin
2015-02-25 19:13 ` Eduardo Valentin
2015-02-25 19:13 ` [lm-sensors] [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FA Eduardo Valentin
2015-02-25 19:13 ` [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Eduardo Valentin
2015-02-25 15:34 ` [PATCH v5 2/6] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2015-02-25 15:34 ` [lm-sensors] " Lukasz Majewski
2015-02-25 15:34 ` Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-25 15:34 ` [lm-sensors] [PATCH v5 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Od Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-25 18:49 ` Eduardo Valentin
2015-02-25 18:49 ` [lm-sensors] [PATCH v5 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device i Eduardo Valentin
2015-02-25 18:49 ` [PATCH v5 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Eduardo Valentin
2015-02-25 15:34 ` [PATCH v5 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-25 15:34 ` [lm-sensors] [PATCH v5 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cyc Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 5/6] hwmon: pwm-fan: Read PWM FAN configuration from device tree Lukasz Majewski
2015-02-25 15:34 ` [lm-sensors] " Lukasz Majewski
2015-02-25 15:34 ` Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device Lukasz Majewski
2015-02-25 15:34 ` [lm-sensors] " Lukasz Majewski
2015-02-25 15:34 ` Lukasz Majewski
2015-02-25 18:24 ` Eduardo Valentin
2015-02-25 18:24 ` [lm-sensors] " Eduardo Valentin
2015-02-25 18:24 ` Eduardo Valentin
2015-02-25 17:18 ` [PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Guenter Roeck
2015-02-25 17:18 ` [lm-sensors] " Guenter Roeck
2015-02-25 17:18 ` Guenter Roeck
2015-02-25 18:29 ` Eduardo Valentin
2015-02-25 18:29 ` [lm-sensors] " Eduardo Valentin
2015-02-25 18:29 ` Eduardo Valentin
2015-02-25 18:42 ` Guenter Roeck
2015-02-25 18:42 ` [lm-sensors] " Guenter Roeck
2015-02-25 18:42 ` Guenter Roeck
2015-02-26 13:59 ` [PATCH v6 " Lukasz Majewski
2015-02-26 13:59 ` [lm-sensors] " Lukasz Majewski
2015-02-26 13:59 ` Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-02-26 13:59 ` [lm-sensors] [PATCH v6 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 2/6] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2015-02-26 13:59 ` [lm-sensors] " Lukasz Majewski
2015-02-26 13:59 ` Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-26 13:59 ` [lm-sensors] [PATCH v6 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Od Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-26 13:59 ` [lm-sensors] [PATCH v6 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cyc Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 5/6] hwmon: pwm-fan: Read PWM FAN configuration from device tree Lukasz Majewski
2015-02-26 13:59 ` [lm-sensors] " Lukasz Majewski
2015-02-26 13:59 ` Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device Lukasz Majewski
2015-02-26 13:59 ` [lm-sensors] " Lukasz Majewski
2015-02-26 13:59 ` Lukasz Majewski
2015-02-26 14:12 ` Guenter Roeck
2015-02-26 14:12 ` [lm-sensors] " Guenter Roeck
2015-02-26 14:12 ` Guenter Roeck
2015-02-26 14:40 ` Lukasz Majewski
2015-02-26 14:40 ` [lm-sensors] " Lukasz Majewski
2015-02-26 14:40 ` Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND RESEND v6 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2015-03-04 12:03 ` [lm-sensors] [PATCH RESEND RESEND v6 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 f Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND RESEND v6 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-03-04 12:03 ` [lm-sensors] [PATCH RESEND v6 1/6] Documentation: dts: Documentation entry to explain how to use PWM Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 2/6] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2015-03-04 12:03 ` [lm-sensors] " Lukasz Majewski
2015-03-04 12:03 ` Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-03-04 12:03 ` [lm-sensors] [PATCH RESEND v6 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling devic Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-03-04 12:03 ` [lm-sensors] [PATCH RESEND v6 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM d Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 5/6] hwmon: pwm-fan: Read PWM FAN configuration from device tree Lukasz Majewski
2015-03-04 12:03 ` [lm-sensors] " Lukasz Majewski
2015-03-04 12:03 ` Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device Lukasz Majewski
2015-03-04 12:03 ` [lm-sensors] " Lukasz Majewski
2015-03-04 12:03 ` Lukasz Majewski
2015-08-11 13:07 ` [PATCH RESEND v6 0/3] dts: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2015-08-11 13:07 ` [PATCH RESEND v6 1/3] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-08-13 0:17 ` Krzysztof Kozlowski
2015-08-14 9:36 ` Kukjin Kim
2015-08-16 9:35 ` Krzysztof Kozlowski
2015-09-16 11:00 ` [PATCH RESEND v6 0/3] dts: thermal: Odroid U3: Provide support for Odroid U3 fan Thomas Pietrowski
2015-09-16 11:57 ` Krzysztof Kozlowski
2015-08-11 13:14 ` [PATCH RESEND v6 2/3] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2015-08-13 0:35 ` Krzysztof Kozlowski
2015-08-11 13:15 ` [PATCH RESEND v6 3/3] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-08-13 0:35 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150208215243.22085c97@jawa \
--to=l.majewski@majess.pl \
--cc=a.kesavan@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=jdelvare@suse.de \
--cc=k.debski@samsung.com \
--cc=kesavan.abhilash@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=kgene@kernel.org \
--cc=l.majewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.