From: Tony Lindgren <tony@atomide.com>
To: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-omap@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 11/14] ARM: omap2: use clkdev_create()
Date: Fri, 03 Apr 2015 23:49:37 +0000 [thread overview]
Message-ID: <20150403234937.GE18048@atomide.com> (raw)
In-Reply-To: <E1Ye59j-0001Bd-0T@rmk-PC.arm.linux.org.uk>
* Russell King <rmk+kernel@arm.linux.org.uk> [150403 10:14]:
> Rather than open coding the clkdev allocation, initialisation and
> addition, use the clkdev_create() helper.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c b/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c
> index 85e0b0c06718..b64d717bfab6 100644
> --- a/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c
> +++ b/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c
> @@ -232,14 +232,12 @@ void omap2xxx_clkt_vps_init(void)
> struct clk_hw_omap *hw = NULL;
> struct clk *clk;
> const char *parent_name = "mpu_ck";
> - struct clk_lookup *lookup = NULL;
>
> omap2xxx_clkt_vps_late_init();
> omap2xxx_clkt_vps_check_bootloader_rates();
>
> hw = kzalloc(sizeof(*hw), GFP_KERNEL);
> - lookup = kzalloc(sizeof(*lookup), GFP_KERNEL);
> - if (!hw || !lookup)
> + if (!hw)
> goto cleanup;
> init.name = "virt_prcm_set";
> init.ops = &virt_prcm_set_ops;
> @@ -249,15 +247,9 @@ void omap2xxx_clkt_vps_init(void)
> hw->hw.init = &init;
>
> clk = clk_register(NULL, &hw->hw);
> -
> - lookup->dev_id = NULL;
> - lookup->con_id = "cpufreq_ck";
> - lookup->clk = clk;
> -
> - clkdev_add(lookup);
> + clkdev_create(clk, "cpufreq_ck", NULL);
> return;
> cleanup:
> kfree(hw);
> - kfree(lookup);
> }
> #endif
> --
> 1.8.3.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-omap@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 11/14] ARM: omap2: use clkdev_create()
Date: Fri, 3 Apr 2015 16:49:37 -0700 [thread overview]
Message-ID: <20150403234937.GE18048@atomide.com> (raw)
In-Reply-To: <E1Ye59j-0001Bd-0T@rmk-PC.arm.linux.org.uk>
* Russell King <rmk+kernel@arm.linux.org.uk> [150403 10:14]:
> Rather than open coding the clkdev allocation, initialisation and
> addition, use the clkdev_create() helper.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c b/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c
> index 85e0b0c06718..b64d717bfab6 100644
> --- a/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c
> +++ b/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c
> @@ -232,14 +232,12 @@ void omap2xxx_clkt_vps_init(void)
> struct clk_hw_omap *hw = NULL;
> struct clk *clk;
> const char *parent_name = "mpu_ck";
> - struct clk_lookup *lookup = NULL;
>
> omap2xxx_clkt_vps_late_init();
> omap2xxx_clkt_vps_check_bootloader_rates();
>
> hw = kzalloc(sizeof(*hw), GFP_KERNEL);
> - lookup = kzalloc(sizeof(*lookup), GFP_KERNEL);
> - if (!hw || !lookup)
> + if (!hw)
> goto cleanup;
> init.name = "virt_prcm_set";
> init.ops = &virt_prcm_set_ops;
> @@ -249,15 +247,9 @@ void omap2xxx_clkt_vps_init(void)
> hw->hw.init = &init;
>
> clk = clk_register(NULL, &hw->hw);
> -
> - lookup->dev_id = NULL;
> - lookup->con_id = "cpufreq_ck";
> - lookup->clk = clk;
> -
> - clkdev_add(lookup);
> + clkdev_create(clk, "cpufreq_ck", NULL);
> return;
> cleanup:
> kfree(hw);
> - kfree(lookup);
> }
> #endif
> --
> 1.8.3.1
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/14] ARM: omap2: use clkdev_create()
Date: Fri, 3 Apr 2015 16:49:37 -0700 [thread overview]
Message-ID: <20150403234937.GE18048@atomide.com> (raw)
In-Reply-To: <E1Ye59j-0001Bd-0T@rmk-PC.arm.linux.org.uk>
* Russell King <rmk+kernel@arm.linux.org.uk> [150403 10:14]:
> Rather than open coding the clkdev allocation, initialisation and
> addition, use the clkdev_create() helper.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c b/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c
> index 85e0b0c06718..b64d717bfab6 100644
> --- a/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c
> +++ b/arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c
> @@ -232,14 +232,12 @@ void omap2xxx_clkt_vps_init(void)
> struct clk_hw_omap *hw = NULL;
> struct clk *clk;
> const char *parent_name = "mpu_ck";
> - struct clk_lookup *lookup = NULL;
>
> omap2xxx_clkt_vps_late_init();
> omap2xxx_clkt_vps_check_bootloader_rates();
>
> hw = kzalloc(sizeof(*hw), GFP_KERNEL);
> - lookup = kzalloc(sizeof(*lookup), GFP_KERNEL);
> - if (!hw || !lookup)
> + if (!hw)
> goto cleanup;
> init.name = "virt_prcm_set";
> init.ops = &virt_prcm_set_ops;
> @@ -249,15 +247,9 @@ void omap2xxx_clkt_vps_init(void)
> hw->hw.init = &init;
>
> clk = clk_register(NULL, &hw->hw);
> -
> - lookup->dev_id = NULL;
> - lookup->con_id = "cpufreq_ck";
> - lookup->clk = clk;
> -
> - clkdev_add(lookup);
> + clkdev_create(clk, "cpufreq_ck", NULL);
> return;
> cleanup:
> kfree(hw);
> - kfree(lookup);
> }
> #endif
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2015-04-03 23:49 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 17:11 [PATCH 00/14] Fix fallout from per-user struct clk patches Russell King - ARM Linux
2015-04-03 17:11 ` Russell King - ARM Linux
2015-04-03 17:11 ` Russell King - ARM Linux
2015-04-03 17:12 ` [PATCH 01/14] clk: update clk API documentation to clarify clk_round_rate() Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-07 8:47 ` [alsa-devel] " Ricard Wanderlof
2015-04-03 17:12 ` [PATCH 02/14] clkdev: drop __init from clkdev_add_table() Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 23:49 ` Tony Lindgren
2015-04-03 23:49 ` Tony Lindgren
2015-04-03 23:49 ` Tony Lindgren
2015-04-04 12:43 ` Robert Jarzmik
2015-04-04 12:43 ` Robert Jarzmik
2015-04-04 12:43 ` Robert Jarzmik
2015-04-04 12:43 ` Robert Jarzmik
2015-04-04 12:53 ` Russell King - ARM Linux
2015-04-04 12:53 ` Russell King - ARM Linux
2015-04-04 12:53 ` Russell King - ARM Linux
2015-04-06 19:04 ` Stephen Boyd
2015-04-06 19:04 ` Stephen Boyd
2015-04-06 19:04 ` Stephen Boyd
2015-04-07 10:05 ` Robert Jarzmik
2015-04-07 10:05 ` Robert Jarzmik
2015-04-07 10:05 ` Robert Jarzmik
2015-04-07 12:42 ` Russell King - ARM Linux
2015-04-07 12:42 ` Russell King - ARM Linux
2015-04-07 12:42 ` Russell King - ARM Linux
2015-04-06 5:50 ` Sekhar Nori
2015-04-06 5:51 ` Sekhar Nori
2015-04-06 5:50 ` Sekhar Nori
2015-04-06 5:50 ` Sekhar Nori
2015-04-03 17:12 ` [PATCH 04/14] clkdev: const-ify connection id to clk_add_alias() Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` [PATCH 05/14] clkdev: use clk_hw internally Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-06 20:18 ` Stephen Boyd
2015-04-06 20:18 ` Stephen Boyd
2015-04-06 20:18 ` Stephen Boyd
2015-04-03 17:12 ` [PATCH 06/14] clkdev: add clkdev_create() helper Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-06 20:19 ` Stephen Boyd
2015-04-06 20:19 ` Stephen Boyd
2015-04-06 20:19 ` Stephen Boyd
2015-04-07 12:43 ` Russell King - ARM Linux
2015-04-07 12:43 ` Russell King - ARM Linux
2015-04-07 12:43 ` Russell King - ARM Linux
2015-04-07 23:09 ` Stephen Boyd
2015-04-07 23:09 ` Stephen Boyd
2015-04-07 23:09 ` Stephen Boyd
2015-04-03 17:12 ` [PATCH 07/14] media: omap3isp: remove unused clkdev Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 17:12 ` Russell King
2015-04-03 21:44 ` Laurent Pinchart
2015-04-03 21:44 ` Laurent Pinchart
2015-04-03 21:44 ` Laurent Pinchart
2015-04-05 14:20 ` Russell King - ARM Linux
2015-04-05 14:20 ` Russell King - ARM Linux
2015-04-05 14:20 ` Russell King - ARM Linux
2015-04-07 9:42 ` Laurent Pinchart
2015-04-07 9:42 ` Laurent Pinchart
2015-04-07 9:42 ` Laurent Pinchart
2015-04-07 12:45 ` Russell King - ARM Linux
2015-04-07 12:45 ` Russell King - ARM Linux
2015-04-07 12:45 ` Russell King - ARM Linux
2015-04-07 14:38 ` Laurent Pinchart
2015-04-07 14:38 ` Laurent Pinchart
2015-04-07 14:38 ` Laurent Pinchart
2015-04-03 17:13 ` [PATCH 08/14] SH: use clkdev_add_table() Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` [PATCH 09/14] ARM: lpc32xx: convert to " Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` [PATCH 10/14] ARM: orion: use clkdev_create() Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-04 0:17 ` Andrew Lunn
2015-04-04 0:17 ` Andrew Lunn
2015-04-04 0:17 ` Andrew Lunn
2015-04-07 13:20 ` Gregory CLEMENT
2015-04-07 13:20 ` Gregory CLEMENT
2015-04-07 13:20 ` Gregory CLEMENT
2015-04-07 14:01 ` Russell King - ARM Linux
2015-04-07 14:01 ` Russell King - ARM Linux
2015-04-07 14:01 ` Russell King - ARM Linux
2015-04-07 14:20 ` Gregory CLEMENT
2015-04-07 14:20 ` Gregory CLEMENT
2015-04-07 14:20 ` Gregory CLEMENT
2015-04-03 17:13 ` [PATCH 11/14] ARM: omap2: " Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 23:49 ` Tony Lindgren [this message]
2015-04-03 23:49 ` Tony Lindgren
2015-04-03 23:49 ` Tony Lindgren
2015-04-03 17:13 ` [PATCH 12/14] ARM: omap2: use clkdev_add_alias() Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 23:50 ` Tony Lindgren
2015-04-03 23:50 ` Tony Lindgren
2015-04-03 23:50 ` Tony Lindgren
2015-04-03 17:13 ` [PATCH 13/14] ASoC: migor: use clkdev_create() Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` [PATCH 14/14] clk: s2mps11: " Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:13 ` Russell King
2015-04-03 17:16 ` [PATCH 00/14] Fix fallout from per-user struct clk patches Russell King - ARM Linux
2015-04-03 17:16 ` Russell King - ARM Linux
2015-04-03 17:16 ` Russell King - ARM Linux
2015-04-05 9:04 ` Geert Uytterhoeven
2015-04-05 9:04 ` Geert Uytterhoeven
2015-04-05 9:04 ` Geert Uytterhoeven
2015-04-05 9:04 ` Geert Uytterhoeven
2015-04-05 14:13 ` Russell King - ARM Linux
2015-04-05 14:13 ` Russell King - ARM Linux
2015-04-05 14:13 ` Russell King - ARM Linux
2015-04-05 14:13 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403234937.GE18048@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.